gofmt about ci-helpers

[kevina]

Yeah I think something like

GITDIR="$(pwd)"
cd "$(mktemp -d)"
git checkout --git-dir="$GITDIR"/.git
go fmt ./...

will work

[kevina]

How about find . -name '*.go' -print0 | xargs -0 gofmt -l so that we don't actually modify any files.

Is there some code go code we should avoid running the gofmt check on?

[Kubuxu]

In go-ipfs we run go fmt over all code but we might want to exclude /vendor/ for "reasons".

[Stebalien]

How about find . -name '*.go' -print0 | xargs -0 gofmt -l so that we don't actually modify any files.

SGTM.

Is there some code go code we should avoid running the gofmt check on?

Not that I can think of. However, we may run into issues with gx-go rw and gofmt. I'm not sure.

[Kubuxu]

Afaik, gx-go might format code, it runs the code through AST which when outputting formats it (I think).

[Stebalien]

Hm. Do we need to run this pre-install?

[kevina]

I don't like the idea of having to do this pre-install and not in the test script.

We could check out a clean copy in a tmpdir and run go fmt there...

[Stebalien]

I don't like the idea of having to do this pre-install and not in the test script.

I agree.

We could check out a clean copy in a tmpdir and run

Yuck but..., yes? I can't think of a better solution (it would also help us avoid any other contamination).

[Stebalien]

SGTM.

[kevina]

This is now done, but I had to use git clone -s.