ipfs / ci-helpers

Helper scripts for C.I.

IPFS is an open system to manage data without a central server

Check out our website at ipfs.tech.

For papers on IPFS, please see the Academic Papers section of the IPFS Docs.

License

MIT.

ci-helpers's Issues

Meta: libp2p repos still failing

These repos still need fixing, check off once done

• https://github.com/libp2p/go-libp2p-circuit
• https://github.com/libp2p/go-libp2p-swarm
• https://github.com/libp2p/go-peerstream
• https://github.com/libp2p/go-reuseport
• https://github.com/libp2p/go-stream-muxer

Also, for some reason tests are not enabled on:

• https://github.com/libp2p/go-msgio

Test go modules and gx

At least confirm that build with both passes.
Maybe also run tests on both.

Notes on standard .travis.yml file compenets

Most but not all the existing .travis.yml have this:

cache:
  directories:
    - $GOPATH/src/gx

notifications:
  email: false

If there where there I left it, if not, I didn't add it (for the most part).

Also some projects have:

sudo: false

I left this one alone, but wondering why some have it and not others. The projects that have it in libp2p:

./go-libp2p-pnet/.travis.yml:sudo: false
./go-libp2p-netutil/.travis.yml:sudo: false
./go-peerstream/.travis.yml:sudo: false
./go-libp2p-swarm/.travis.yml:sudo: false
./go-libp2p-transport/.travis.yml:sudo: false
./go-ws-transport/.travis.yml:sudo: false
./go-libp2p-crypto/.travis.yml:sudo: true
./go-testutil/.travis.yml:sudo: false
./go-libp2p-peer/.travis.yml:sudo: false
./go-libp2p-secio/.travis.yml:sudo: false
./go-libp2p-loggables/.travis.yml:sudo: false
./go-reuseport/.travis.yml:sudo: false

gofmt

It would be nice to also fail tests if go fmt ./... lists any files as being modified (formatted).

Fix repo permissions

• Give write permissions to the go team.
• Give admin permissions to the Admin team.
• Remove any other permissions.

travis ci script doesn't work with go modules

The script outputs the following log and error:

$ bash <(curl -s https://raw.githubusercontent.com/ipfs/ci-helpers/master/travis-ci/run-standard-tests.sh)
*** cd /tmp/tmp.bMIKMLkCCH
*** git -c advice.detachedHead=false clone -q -s /home/travis/gopath/src/github.com/libp2p/go-libp2p-secio .
*** go fmt ./...
*** cd /home/travis/gopath/src/github.com/libp2p/go-libp2p-secio
*** go vet ./...
*** Setting up test environment
net.ipv6.conf.lo.disable_ipv6 = 0
net.ipv6.conf.default.disable_ipv6 = 0
net.ipv6.conf.all.disable_ipv6 = 0
*** go build github.com/libp2p/go-libp2p-secio/v3
go: cannot find main module; see 'go help modules'

Source: https://travis-ci.org/libp2p/go-libp2p-secio/jobs/485661465

Orb environment doesn't play nice with CGO

• The orb environment does not include gcc in the images, but also does not set CGO_ENABLED=0.
• https://github.com/libp2p/go-libp2p-quic-transport makes use of github.com/klauspost/compress among other dependencies which default to attempting CGO compilation unless explicitly disabled.
• This leads to failures of the form:

  loadinternal: cannot find runtime/cgo
  /usr/local/go/pkg/tool/linux_amd64/link: running gcc failed: exit status 1
  /bin/ld: cannot find crti.o: No such file or directory
  /bin/ld: skipping incompatible /usr/lib/gcc/x86_64-linux-gnu/9/libgcc.a when searching for -lgcc
  /bin/ld: cannot find -lgcc
  

Do we think we can safely update the orb environment to either include CGO_ENABLED=0 or to provide a parameter for consumers to do so?

Add GOVETFLAGS

In some cases, we're not going to be able to fix all go vet errors and may need to disable some checks. Ideally, we'd just be able to silence specific issues but, we'll, we're dealing with the go devs here.

use a GitHub Action to distribute standard workflow templates across participating repos

We can use GitHub actions to

1. Create self-contained template workflows that repositories across the org can use (as a first step for unit testing, later maybe also for linting).
2. Use GitHub Actions to automatically create PRs in all participating repositories every time we make a change to those workflows. This solves the two main problems with our current setup:
   1. It ensures consistent and up-to-date workflows across all participating repositories.
   2. It makes sure that test failures resulting from a change to the workflow are surfaced immediately.

The current plan is to use this repository for a unit testing template, and use that workflow in some IPLD repositories first to gain some experience, and roll this out to other projects later.

See https://docs.google.com/document/d/1O0vFKxTNv9-JvfETAPUexY--93dC_7l3ZaPzIey-3c0/edit?usp=sharing for details.