ipropper / minidetector Goto Github PK

This is just a minor thing, but it'd be nice to have the current UA list
and search strings be tested in test_strategies.py

added webos

A quick setup screen, and maybe somethign explaining the strategies

minidetector does not detect Fennec as a mobile browser.

Please consider my patch.

wurfl = http://wurfl.sourceforge.net/

The WURFL is an "ambitious" configuration file that contains info about all 
known Wireless devices 
on earth. 

with that we can target better the mobile browser.

The Middleware should add Vary headers to responses. Similarly,
@vary_on_mobile should be defined.

I didn't find any contact info, so I'm going to leave a note here.

I've been working on a fork of your project here:

https://github.com/shelfworthy/minidetector

and at this point have added quite a few features. I'm curious what you guys 
think, and wanted to give you a heads up. I plan on keeping development pretty 
active as the code supports a app framework we're working on that sits on top 
of django.

Attached patch does it.

One can test with the Mobile emulator:
http://www.opera.com/developer/tools/mobile/

for ua in search_strings:
    s = request.META["HTTP_USER_AGENT"].lower()

should be

s = request.META["HTTP_USER_AGENT"].lower()
for ua in search_strings:
    ...

since s is invariant in the for loop.

This project needs a setup.py script.

Maybe it should use setuptools?

The 'detected' function calls

middleware.process_request

instead of

Middleware.process_request

Fixed in the attached patch.

The Amazon Kindle has a web browser:

Mozilla/4.0 (compatible; Linux 2.6.10) NetFront/3.3 Kindle/1.0 (screen 600x800

The summary says it preety much :)

I think the iPad is 50/50.  How would you go about omitting iPad from mobile 
detection?

I'm trying to use the request.mobile variable inside of a template. I've 
included the (minidetector) project in the django path and can, from inside of 
view code, print the request.mobile variable (True in the case of a mobile 
device). However, when I include the following template syntax in a template it 
prints nothing.

    <h1>request.mobile: -->{{ request.mobile }}<--</h1>

Do I need to include a something special in TEMPLATE_CONTEXT_PROCESSORS inside 
of my settings.py? I can see that it is available in my view (as noted), but is 
unavailable in my template. Any ideas?