irbull / p2diff Goto Github PK

Currently, p2diff is only printed to System.out. It would be very useful to also have it on a file (configured with some --output=" flag.

Steps to repro:

a) fetch this target platform definition and resolve it locally:

https://github.com/jbosstools/jbosstools-discovery/tree/f540ae28296228b9cfa6ca7c22f60fdf88dd5a5c

b) move the resulting folder somewhere, then apply this PR or (fetch the specific commit), and repeat.

jbosstools/jbosstools-discovery#158
https://github.com/nickboldt/jbosstools-discovery/tree/755325ea7e03fe3b3526868c56d4612b7b61340c

c) you should have two target platform sites now, which vary only in that one contains a newer version of maven.apt.feature (and contained plugins)

Screenshot of Beyond Compare showing the differences:

https://issues.jboss.org/secure/attachment/12382638/jbide17429_p2diff-jbtcentral.png

d) run p2diff on the sites, get no console output, no summary, no list of changed IUs

 ~/tmp/p2diff/p2diff -mode=all -query=all -onlylatest -ignorecase file:///home/nboldt/disco/jbtcentraltarget/multiple/target/jbtcentral-multiple.target.repo/ file:///tmp/jbtcentral-multiple.target.repo_2014-05-26_13-23_GOOD/

(Also tried with no modifier flags, same result.)

Note that my version of p2diff has worked for other sites. It's built from https://github.com/nickboldt/p2diff, not https://github.com/irbull/p2diff, but I think the code is the same.

See also: https://issues.jboss.org/browse/JBIDE-17429

We use embedded jar in our plugins. A typical situation where the current comparison strategies (default and deep) are falling short is where the embedded jar is SNAPSHOT but was updated. Neither of the current comparisons would then detect the new IUs would have to get published. A binary comparison would fix this.
@nickboldt cc

Would you or me do?