iros / d3.chart.base Goto Github PK

Hi! Just a quick question.

I noticed here all the attributes had an underscore in front (_width), whereas in the introduction, some had an underscore, but the xScale didn't.

Could you explain this pattern? I thought underscores typically represented private attributes.

I'm trying to understand the initAttr function:

  function _initAttr(internalName, d3Name, defaultValue) {
    if (!this.base.attr(d3Name)) {
      this[internalName] = defaultValue;
      this.base.attr(d3Name, defaultValue);
    } else {
      this[internalName] = this.base.attr(d3Name);
    }
  }

It seems like after you use it

    // make sure container height and width are set.
    _initAttr.call(this, "_width", "width", 200);
    _initAttr.call(this, "_height", "height", 200);

these lines become unnecessary:

 // setup some reasonable defaults
    chart._width  = chart.base.attr("width") || 200;
    chart._height = chart.base.attr("height") || 200;

since in either case (svg width/height are already set, or they're not) the initAttr function is assigning a value to this._width and this._height. What am I missing?

Do you think margins have a place in a base chart such as this one? How have you implemented margins in your work with d3.chart so far?