irvinm / tst-lock

Protect your tabs in TST by replacing the close "X" with a lock. Toggle via "Ctrl + Shift + Left Mouse Click"

Hi there 👋

tst-lock's Issues

Explore supporting custom lock graphics

Current lock content just uses the Unicode lock symbol. The content tag does support a URL() option, but wondering if that resource can be stored within the addon and referenced locally.

Exploring different ways to pass icon to TST

Below are some of the ways I tried to pass content to TST ... some worked, some didn't.

I just wanted to document this in case I wanted to explore other options.

function registerSelfToTST() {
  browser.runtime.sendMessage(kTST_ID, {
    type: "register-self",
    name: "TST-Lock",
    icons: browser.runtime.getManifest().icons,
    listeningTypes: ["tab-mousedown", "tab-mouseup"],
    style: `
      .tab.locked .closebox {
        pointer-events: none !important;
      }
      .tab:not(.faviconized).locked .closebox::after {
        background: none;

        /* Works */
        /* https://www.compart.com/en/unicode/U+1F512#UNC_DB */
        /* content: "🔒"; */
        /* content: url("http://icons.iconarchive.com/icons/oxygen-icons.org/oxygen/24/Actions-document-encrypt-icon.png"); */
        /* content: url("http://icons.iconarchive.com/icons/fatcow/farm-fresh/24/lock-icon.png"); */
        /* content: url("moz-extension://32b76189-c6cf-43d0-af5c-e10691134da7/lock.png"); */
        /* content: url('data:image/png;base64,iVBORw0KGgoAAAANSUhEUgAAABgAAAAYCAYAAADgdz34AAAD5ElEQVR42rWWX2gcVRTGv7uzs7Ozs/83m2xIumIKNbErYtq0ogYhvogCiVFTVKm+6EsrFHzy2beAvlgVKiAVsChobcECYiVCrCqlbYymRaPRkm6y22RnN7Ob7Py593oYtEltm8VIv+EwOzPnfj/OOXeGZVJK3E4FgdaaPHko2dk9MLpqzj3809kJ0RT8+3zPzk8f2Xe4jBYKoIUmjh/Upeu8WivNvtlcre1vy6ZfXK3b42bFfG1m8nDb/6rgzOevs+KfxfGGWTyYSkam9Xj+mBpKUFfnx05/8fWhtnS2N3rpxFi+d9jaEqBSmn+wePnXA7v37PpSyNizQ8+8dRUk8cHL71UbztGzZyYe78znnwLw/pZatDD343ChbwfryBfGffO/9ej+I8t9O+9+I6QxvjA7NbTlFrXn4l2ZTIIrwr5hmLnsHYtevbxmrVQSWx7y9p6CkELAti7fkFecv8CkkMzjkm0ZoKi6LTwP3BY1/EtrjlWVIPdAwMEmuumL9tk7I32dXbl9IUUbXaksFPRE+ggLBBcBCUYHGEOpvJA1l5Zeasu0zymqemylZn305CsnL7YEHH97WFNV9VT/4MiQuXARxT9m0FMYhKYnwD0bQrhgBKpbJqbPfYdMKo389h345eepr7iQjz1x4IS96ZC56wzcedfuvcmOAjSjE8nO+xA2EmBM0rM1SO5C8CYCwTDu2fUQFLqvR8LIZNv2Li6WBwBMbgro2NbbrRkZY25mgow4GTOIkucbG8kuXPl9GmurJqTwQAng3IGUHMl02IhG5LaW29TQpRtEA7a9DAgyBsAoyBEBmUAqEUQ8EqdLAU5Qz3XBCRSLJ6CrYa8loFa5Ch4Iwm02wL31fCk5pFpFZWmZTJuQBJScg1NIRr8VB6A1LQHfnC/hhef2wFox/YGuEwTNIgakkwR2fQDnHjhVIKREKmXg6IfTGHy+BeCTU1Ps6ZEHCFAjg40VCLhCQ6W8RADH771HIL9SbkNhEZz+9sqtK2AkSUqlYtFkuhuMFvANFdAjqFoUshkFdyw4tkPhwoGAhIJIWIcRCUU3eq0D1iHR++/t6DErRdTrdb8VGwhQ1FX8NvODPwPG/FuQAmABCcMgoOP0kEcMQP1WLYrrup7LZPNQtSoEd7FRQgC5XDudPUDC38ae5/mgRDIKVVFyADYFuI1GwzJLl+A6LrzrKqBkLYRGreJvTzKlkAQR/kvYqFIFnmsBcG76qWAkAHo6ofUP9rePqUElJiSua1FIC2OpVCRTD6B0Bp+LAAO4YNb52ebH1To/B2BNkv4Z3rUgBShUCsU//5dYXxMYfbd8zfO2/235CyRUGSky0aqyAAAAAElFTkSuQmCC'); */
        /* content: url('data:image/png;base64,iVBORw0KGgoAAAANSUhEUgAAABgAAAAYCAYAAADgdz34AAAAB3RJTUUH5AYYDC4WrSU8/QAABBpJREFUeJy1VG1olWUYvu77fd73HLeac0JkzG2G82NsiAxFQ3QaVlMiEvLHwqxICcF/1b8oCn/0QQUZgQhBECKU1Q9XiflDSs3m/FjOo1s6tU1ba2fudM523vd97rsf7znbzj7cDHrg+Xff18d9X89DuMshIkdVrXFd1NbWLVu8tKbO87zSTCbde7Gt7WziUnvH2LpJMaYD37hpc8MLL+18s7K8Yo1jHEdUwcTws9lMR8fl5o8/+uD1c61nEszsiMgEkkkJ8uC7X3lt13Pbnv8keSeJnt5eWGjUoQqPDebPewiu6w3sefuNZ5q//eYoEbGqyl0J8kqeenpL41t73mlO/H4l7EsNGgD+9c7O45l0+q/SsrKq8gVVq60fauWD86i0ZHZq144X6y+cP9dJxKQqMhUBAcB9JSWxLw5+ecGLxxdeu91Nd/qT5z/bu3fblUvtbTkRWLH6kceadu783DVmbl31EnPhbOvXu1/esUWBgn3wOPUMQBvWb2iYX15RfbuvDza0yU/fe/fJK5fa24jIEJEjIuaXn386cmD//ibH8/iPW91av2Ll5kW1tZWqaomIJyUAQA6DH65euO5qz00NIHSxteWrG11dNz3PKWJWMCsZB3BdjrecOH6s50bXrwOZNP2Z7PcWL6pexQSekkBV2ApkSExJX/Jvco2Dtt86TwKA70vGWoTWIgwtwiCQ4dACnZevnXFdg95kH7IaLxaF0JjRm7HqVeFvXInlSyqCWmKjgQWtq3ceXVpMniDGBcsjZoYvVQu4TpSgIF2zLFjb144fWxJ6PbdPNdHs4YjAbn08tuHgh/LD9+1Jc/KWVaIQW9dnm5Y9a5oQzgJYR+UIAcbiSMcQTnSHABRbVqW2v/qEaVy9HataE2EXEdhEaiJLa5fzVrGeWTz7Oz/rD3hxM4R5s05L/0BcFLYgcgrAoRhqSpt5aLif42aI5rqnfa+46IH6muGNrQnsY4ZjotlHTdlQlNKOlqVT3DjnMACCPxhjUWd8GEZWOIdS2DTnMBSEzKDHej+rb5XzIiIH+fI0g7qYtN9F1vUABYgUDnRyfAAKg2F1I7hAQSETB6M2zYhfAEhRVOe7CDMGRFMDTyBSAsV8IBDQP5FkGiGgiITyTAJoSLkQT/kfFvhQJUCjgGq+hwpjOgJGjoI9OzPsUQ4oS6FQTCDI1VqC9R0Q6z05IMcCZAt6JiX4zw4cwfg8/E8OpiEYdTBzAoCmdpB/aKKqCkAChmTdnIOZHVUCk4WSVckBaj6mlItpzJBLIHglWbgmO2Pw/AkCgNQhz0TfNeWTrhoZS9yyx6zVAEoklnEv14akTOQMDUvqaq89lcMVjkYDC4D3HcseaOkMDxXFiEVFiBREmPYCClGV4lkUHjrlv3/0YthKAItC/gWYUiVDPGS12QAAAABJRU5ErkJggg=='); */

        /* Doesn't work */
        /* content: url(myURL); */
        /* content: url(browser.runtime.getURL('/lock.png')); */
        /* content: url(moz-extension://__MSG_@@extension_id__/lock.png); */
        /* content: url(lock.png); */
        /* content: url('/lock.png'); */

        /* Current selection */
        content: "🔒";          
        line-height: 1;
        mask: none;
      }
    `,
  });
}

Add menu item to TST to lock tab

Closing locked tab results in new tab without lock

• TST 3.5.15 \ TST-Lock 1.0.3
• Create tab
• Lock tab
• Right-click on TST tab and select "Close Tab"
• Original lock tab closes
• New tab (same URL) is opened without the lock
• Right-click on TST tab and select "Close Tab" (Or now click on "X")
• Tab closes

Workaround is to either close tab twice or remove lock then close tab.

Evaluate if the initial call to registerSelfToTST() is needed

There is an initial call, then I added another call after the "ready" message is sent.

It seems to work now, but wondering if the first call is really needed or not.

Locks not restored on Firefox start-up (v1.1.2)

Logging seems to show that "ready" event was never received, but did receive a "wait-for-shutdown" event.

Add-on is working fine otherwise. Restarting Firefox gets the locks loaded properly.

Allow option to select from a set of lock icons

• Better lock icons are already in the "images" folder and exposed outside the addon.
• Might need to just convert PNGs to base64 strings to pass to TST.
• Not sure if passing a variable to TST will work after setting it to the string.

Add number of locked tabs to the addon badge

Just like notifications for other add-ons, display the number of tabs locked on the add-on badge.

TST upgrade problem while browser is running

Scenario:

• TST is installed and running.
• TST-Lock is installed and running.
• TST upgrades its version when the browser is running.
• TST-Lock no longer displays locked tabs.
• Workaround: Disable\enable TST-Lock OR restart browser.

Observations:

• Trying to reproduce in Sandbox ... could not do it. Every upgrade worked fine.
• Guess is that either TST is not sending some notification OR TST-Lock needs to monitor for a broken promise from TST to then try to re-initiate communications.

Successful upgrade:

Integrate lock information with "Tab Session Manager" session management

• Lock information is currently handled by this addon by storing the lock state as part of get\setTabValue.
• This works well within the current session.
• Information will be lost if the session is lost.
• If TSM then restores a session, no lock information will exist in the new session.
• Ideally would be best to tie into TSM such that the tab information is saved as part of the "session" which could then be restored.
• TabValue functions can only be get\set from the addon who created it. (Either TST-Lock or TSM)
• Else would need to pass information to an "owner" of the info thus complicating the scenario.

---

• sessions.setTabValue()
• TSM save.js
• Would need a means to ask TSM to save and restore information. (Would TST-Lock need to ask TSM for info during start-up each time?)
• Given that TSM hasn't had a real check-in for several months, might just want to fork the project and customize.