isaacplmann / ngrx-query Goto Github PK

Currently the supported methods for HttpOptions are: 'DELETE' | 'GET' | 'HEAD' | 'POST' | 'PUT', however PATCH and OPTIONS are also a valid methods and it would be nice if the the method field in HttpOptions supported them. Right now I'm getting around the problem by simply bypassing the typing with method: <any>'PATCH'.

I've begun integrating this into our project as it looks like a promising way to cut down repetition for requests (of which there are a considerable amount). One small thing I ran into however was adding params to the requests -- which we do for almost all requests -- which now has to be done with string concatenation. This feels fairly clunky compared to e.g. @angular/http/common which allows passing a map of the params.

What is your opinion on providing a optional key params to the RequestParam type? If you are interested I can see if I can make a PR.

Hey man,

Super excited to stumble across ngrx-query. It's exactly what I've been looking for for reducing boilerplate and managing api state in my app. Do you have examples of the best way to use this with ngrx/effects?

Thanks,
Jonathan