The badavi from isbadawi

Replace mode

5. Replace mode                         *Replace* *Replace-mode* *mode-replace*

Enter Replace mode with the "R" command in normal mode.

In Replace mode, one character in the line is deleted for every character you
type.  If there is no character to delete (at the end of the line), the
typed character is appended (as in Insert mode).  Thus the number of
characters in a line stays the same until you get to the end of the line.
If a <NL> is typed, a line break is inserted and no character is deleted.

Be careful with <Tab> characters.  If you type a normal printing character in
its place, the number of characters is still the same, but the number of
columns will become smaller.

If you delete characters in Replace mode (with <BS>, CTRL-W, or CTRL-U), what
happens is that you delete the changes.  The characters that were replaced
are restored.  If you had typed past the existing text, the characters you
added are deleted.  This is effectively a character-at-a-time undo.

If the 'expandtab' option is on, a <Tab> will replace one character with
several spaces.  The result of this is that the number of characters in the
line increases.  Backspacing will delete one space at a time.  The original
character will be put back for only one space that you backspace over (the
last one).  {Vi does not have the 'expandtab' option}

ctags support

ctags format is not hard to parse. Can at least implement badavi -t, :tag, and the tag stack.

Large file support

i.e. don't read the whole file into memory.

insert mode completion

:help ins-completion, :help 'complete'

an empty buffer is created even when invoked with a file

Can see by running :ls that there is always a [No Name] buffer

gv (re-enter visual mode with last selection)

variants of :set command

Right now we support these

:set opt: set boolean option to true, or show value of int or string option
:set noopt: set boolean option to false
:set opt=val: set string or int option to value
:set opt!: toggle boolean option
:set opt?: show value of option

According to :help set-option, vim also supports these

Most of these make sense to add, except maybe :set opt&vi, :set opt&vim, :set termcap

Memory leak in editor_jump_to_tag

(I've already fixed this, just trying out GitHub projects convert to issue feature)

Undoing edits at end-of-file causes problems

Try e.g. dj at the bottom of the file and undoing it.
Weird garbage seen on the screen and occasionally a segfault.

Indenting

autoindent, smartindent, expandtab, shiftwidth, tabstop, softtabstop...

It would be nice to get useful output out of LSan in the tests, but there's a lot of noise because the tests themselves allocate things without freeing. Some leaks could maybe be suppressed (e.g. LSAN_OPTIONS=suppressions=<(echo "leak:test_*__initialize")) but it would be better to fix.

Some structs like editor, buffer, gapbuf don't have free functions because they stay around for the life of the program (for now), so those would have to be added.

Scripting (e.g. vimL, or lua)

Command & search histories

jumping to a tag leaves cursor line at the bottom of the window

It would be better to scroll the window down so the cursor line is centered.

built-in LSP client

alternate file name (ctrl-^)

Macros

Horizontal splits

Not any harder to implement than vertical splits.
Main open question is the best way to go up, down, left, right. It's easy now with a singly linked list going left to right.

swapfile

Special registers

From :help registers

Occasional crash closing a window with equalalways on

Can't consistently reproduce, but closing a split window in a complicated layout sometimes segfault.

incsearch

Visual mode

Need a way for modes to affect the drawing.
(Could also use this to draw the cursor in / and : modes.)

<<, >>

viminfo

Text objects

Easy to implement -- just don't want to have too much duplication with motion code.

Investigate termbox forks

nsf/termbox is not maintained anymore.

This fork seems interesting: https://github.com/tomas/termbox
Also came across https://github.com/nullgemm/termbox_next

Resizing splits

Line wrapping

Especially now with splits, horizontal scrolling is kind of lame.

`:<num>` / `:-<num>` doesn't work

badavi <file> +<line> is also broken, not clear since when.
Both are implemented using editor_send_keys to translate to <num>G

:Explore

virtualedit option

Cursors get confused when editing same buffer in multiple splits

The window cursor is just an offset from the start of the file, so if the file changes the cursor gets stale.

Autocommands

Isolate termbox dependency

There are references to termbox sprinkled throughout the code. Could imagine a struct terminal with function pointers wrapping the termbox api.
One advantage would be that we could set up a mock terminal for testing. This would let us test the code in draw.c, and also clean this up:

badavi/draw.c

Lines 351 to 357 in 63feceb

 // FIXME(ibadawi): Hack to make the tests run. 

 // If termbox wasn't initialized (like in the tests), let's not try to draw, 

 // because we can hit a segfault when we try to access the tb_cell buffer. 

 // (search_motion() calls editor_draw(), which is why the tests draw). 

 if (tb_width() == -1) { 

 return; 

 }

	// FIXME(ibadawi): Hack to make the tests run.
	// If termbox wasn't initialized (like in the tests), let's not try to draw,
	// because we can hit a segfault when we try to access the tb_cell buffer.
	// (search_motion() calls editor_draw(), which is why the tests draw).
	if (tb_width() == -1) {
	return;
	}

isbadawi / badavi Goto Github PK

badavi's People

Contributors

Stargazers

Watchers

Forkers

badavi's Issues

Recommend Projects

Recommend Topics

Recommend Org

Jobs