GithubHelp home page GithubHelp logo

ember-cordova-keyboard's People

Contributors

ahmacleod avatar alexblom avatar anulman avatar cah-danmonroe avatar kbullaughey avatar runspired avatar

Stargazers

 avatar  avatar  avatar  avatar

Watchers

 avatar  avatar  avatar

ember-cordova-keyboard's Issues

Keyboard

How does one get the height of the keyboard?

Failing unit tests

Hi,

The build has been failing since this PR was merged - #10. Is there an ETA on when it will be fixed?

Thank you.

document.body height not being reset when keyboard closes after typing into multiple inputs

This looks like an issue with ionic-plugin-keyboard, but I thought it could be mitigated here.

I noticed that when entering text into an input and then closing the keyboard, everything works fine. But when entering text into an input, selecting another input, and then closing the keyboard, the body height stays small (as if the keyboard is still open).

I added a few console.log statements and noticed that the native.keyboardshow event is firing twice after the native.keyboardhide event when switching inputs. With the way ember-cordova-keyboard is coded to handle the body resizing, this._height is being reset to the initial body height, and then set to the calculated height because of the subsequent native.keyboardshow event that fires.

I think by just wrapping the line of code that sets this._height in a condition to check for isVisible this issue would be mitigated:

if (!this._keyboard.isVisible) {
  this._height = document.body.style.height || '';
}

Here is a screen capture of the issue:
cordova-keyboard-bug

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    ๐Ÿ–– Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. ๐Ÿ“Š๐Ÿ“ˆ๐ŸŽ‰

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google โค๏ธ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.