isleofcode / splicon Goto Github PK

View Code? Open in Web Editor NEW

12.0 12.0 7.0 93 KB

Generate cordova/splash files from a single svg, and update config.xml

License: MIT License

JavaScript 100.00%

splicon's People

Contributors

Stargazers

Watchers

Forkers

kitsunde jordanyee rachid aaronfischer viviedu msftenhanceprovenance aboveproperty

splicon's Issues

Missing 120x120 and 152x152

Not sure if this is the proper place to submit something like this or not.
But, starting with a fresh icon.svg and generating via splicon I got this error during the validate/upload process to iOS.

Reference: http://fschr.co/2n3s0B2B0G2o

My SVG doesn't seem to get converted correctly.

My SVG (https://dl.dropboxusercontent.com/u/7948781/potb.svg):

All icon files just show the background:

The first one above is by using svg2png directly, so it seems like the issue is with splicon.

Needs to make 1024px icon per apple requirements

Apple has updated their store requirements and now you have to supply a 1024x1024 image.

https://stackoverflow.com/questions/46309992/missing-marketing-icon-ios-cordova

It doesn't seem to work on the cli as the readme suggests

I tried doing this:

Using the cli, from your cordova project, simply run:
splicon-icons

Which doesn't seem to work:

$ npm install  splicon -g
# splicon-icons
module.js:442
    throw err;
    ^

Error: Cannot find module '../lib/icon-task'
    at Function.Module._resolveFilename (module.js:440:15)
    at Function.Module._load (module.js:388:25)
    at Module.require (module.js:468:17)
    at require (internal/module.js:20:19)
    at Object.<anonymous> (/usr/local/lib/node_modules/splicon/bin/splicon-icons.js:8:23)
    at Module._compile (module.js:541:32)
    at Object.Module._extensions..js (module.js:550:10)
    at Module.load (module.js:458:32)
    at tryModuleLoad (module.js:417:12)
    at Function.Module._load (module.js:409:3)

I'm on node v6.3.1

Remaining release tasks

Also handle splash generation;
Testing
CLI should parse opts (source, dest, config.xml path)
Allow ios platform selection by ios/ipad/iphone vs just 'ios'

iPad Pro icon missing

Hi,

not 100% sure, but I think the iPad Pro icon is missing.

According to here:
https://cordova.apache.org/docs/en/latest/config_ref/images.html

The iPad Pro uses:

<icon src="res/ios/[email protected]" width="167" height="167" />

Maintain Comments in Config

As reported by kitsunde, comments in config.xml are not maintained after splicon updates the config file.

Fail to generate icons /splahes with an error :


Error: write EPIPE
    at exports._errnoException (util.js:1007:11)
    at WriteWrap.afterWrite (net.js:793:14)
v3ss@hexcode ~/ondr-mobile/ember-cordova/cordova $ splicon-splashes
Generating cordova splashes for
events.js:160
      throw er; // Unhandled 'error' event
      ^

Error: write EPIPE
    at exports._errnoException (util.js:1007:11)
    at WriteWrap.afterWrite (net.js:793:14)

Android app icons are too small

Hello,

We employ Corber to turn our Ember web app into 10 themed native Android and iOS apps. All is working well, except for this one issue:

Issue

Our Android app icons are only 50% their desired size on a stock Android 8.1.0 phone.

Our 10 Corber-Ember apps installed:

Desired outcome

To have no white space around the icons.
For the icons to be Adaptive Icons as introduced in Android 8.0.

Examples of how icons should and could look like:

For reproducing

Phone:

Brand: Essential
Model: PH-1
Android version: 8.1.0
Build number: OPM1.180104.267

Ember app:

package.json

"corber": "1.2.9",
"cordova": "7.1.0",
"ember-cli": "~2.18.2",
"ember-cordova-events": "^0.1.1",
"ember-cordova-platform": "^0.1.0",
"ember-cordova-splash": "^0.1.5",

Next steps

Is there anything we can do or test to resolve this?