isthatcentered / charlies-factory Goto Github PK

View Code? Open in Web Editor NEW

2.0 2.0 0.0 1.46 MB

Makes making objects easy

JavaScript 7.12% TypeScript 92.88%

charlies-factory's People

Contributors

Stargazers

Watchers

charlies-factory's Issues

Pass iteration index to pack() function

GEMS = pack( 2, () => makeGem( faker => ({
    id: faker.random.uuid(),
}) ) )

Here, having the ability to use the index as id instead of a faker function would be nice

Add ability to generate multiple objects at a time

Api might be something like

times(3, makeThing(faker => ({ ...overides })))

// or
factory.times(3, makeThing(faker => ({ ...overides })))

// or 
makeThing.times(3) // nice but hard to override

Make types more explicit

Currently, the type suggestion shows

That's not very useful. As a user, I want to know clearly what type of primitive I can pass to the function.

Pass a per factory made index number

Not sure about that one, specially mixed with faker & the iterator passed to pack().

Here's what it would look like:

test( `Each generated item has it's own per factory "made" ID`, () => {
    const makeThing      = factory( ( faker, id ) => ({ id }) ), // id is passed as second argument of generator function
          makeOtherThing = factory( ( faker, id ) => ({ id }) )
			
    expect( makeThing().id ).toBe( 1 )
    expect( makeThing().id ).toBe( 2 )
    expect( makeThing().id ).toBe( 3 )
    expect( makeThing().id ).toBe( 4 )
			
    expect( makeOtherThing().id ).toBe( 1 )
    expect( makeOtherThing().id ).toBe( 2 )
    expect( makeOtherThing().id ).toBe( 3 )
    expect( makeOtherThing().id ).toBe( 4 )
} )