itamart / moodle-mod_dataform Goto Github PK

posted issue in Moodle tracker; couldn't delete this entry

Imported some pictures in via a zip file - try to edit them....

Warning: current() expects parameter 1 to be array, null given in C:\inetpub\wwwroot\moodle\mod\dataform\entries_class.php on line 1014 Warning: current() expects parameter 1 to be array, null given in C:\inetpub\wwwroot\moodle\mod\dataform\entries_class.php on line 1014 Warning: current() expects parameter 1 to be array, null given in C:\inetpub\wwwroot\moodle\mod\dataform\entries_class.php on line 1014 Warning: current() expects parameter 1 to be array, null given in C:\inetpub\wwwroot\moodle\mod\dataform\entries_class.php on line 1014 Warning: current() expects parameter 1 to be array, null given in C:\inetpub\wwwroot\moodle\mod\dataform\entries_class.php on line 1014 Warning: current() expects parameter 1 to be array, null given in C:\inetpub\wwwroot\moodle\mod\dataform\entries_class.php on line 1014 Warning: current() expects parameter 1 to be array, null given in C:\inetpub\wwwroot\moodle\mod\dataform\entries_class.php on line 1014 Warning: current() expects parameter 1 to be array, null given in C:\inetpub\wwwroot\moodle\mod\dataform\entries_class.php on line 1014 Warning: current() expects parameter 1 to be array, null given in C:\inetpub\wwwroot\moodle\mod\dataform\entries_class.php on line 1014 Warning: current() expects parameter 1 to be array, null given in

and also a database error

Debug info: SQLState: 42000

Error Code: 8127

Message: [Microsoft][SQL Server Native Client 10.0][SQL Server]Column "mdl_dataform_entries.timecreated" is invalid in the ORDER BY clause because it is not contained in either an aggregate function or the GROUP BY clause.

SELECT COUNT(e.id) FROM mdl_dataform_entries e
JOIN mdl_user u ON u.id = e.userid
LEFT JOIN mdl_groups g ON g.id = e.groupid LEFT JOIN mdl_dataform_contents c1 ON (c1.entryid = e.id AND c1.fieldid = 1) WHERE e.dataid = '1' AND e.grading = '0' AND e.id <= '1' ORDER BY e.timecreated ASC
[array (
0 => '1',
1 => 0,
2 => 1,
)]
Stack trace:
line 394 of \lib\dml\moodle_database.php: dml_read_exception thrown
line 252 of \lib\dml\sqlsrv_native_moodle_database.php: call to moodle_database->query_end()
line 368 of \lib\dml\sqlsrv_native_moodle_database.php: call to sqlsrv_native_moodle_database->query_end()
line 773 of \lib\dml\sqlsrv_native_moodle_database.php: call to sqlsrv_native_moodle_database->do_query()
line 807 of \lib\dml\sqlsrv_native_moodle_database.php: call to sqlsrv_native_moodle_database->get_recordset_sql()
line 566 of \mod\dataform\entries_class.php: call to sqlsrv_native_moodle_database->get_records_sql()
line 212 of \mod\dataform\entries_class.php: call to dataform_entries->get_entries()
line 264 of \mod\dataform\view\view_class.php: call to dataform_entries->set_content()
line 486 of \mod\dataform\mod_class.php: call to dataform_view_base->display()
line 65 of \mod\dataform\view.php: call to dataform->display()

When data on the page is exported using the "Export all" or "Export page" links from CSV view using mod_dataform release 3.3.2 on Totara 12, Entry state field types are exported with the surrounding HTML node present, instead of just the inner HTML value of that field. The hope is that this can be corrected in a future release so that for example the value of "Accepted" would be exported for the given field, instead of the following entire node:

<span class="entrystate Accepted currentstate">Accepted</span>

Noting this is happening on Totara 12 which is based on Moodle 3.3, so we cannot upgrade to newer mod_dataform 3.5.5.

Hi there,

We appear to have an issue with the attached dataform, when duplicated in anyway on Moodle (Duplicate or back-up/restore) attempting to add new entries fails with the following:

Error reading from database

More information about this error

×Debug info: You have an error in your SQL syntax; check the manual that corresponds to your MySQL server version for the right syntax to use near 'AS DECIMAL(65,7)) ASC' at line 1
SELECT e.id, e.dataid, e.state, e.timecreated, e.timemodified, e.userid, e.groupid, e.type , u.id AS uid ,u.picture,u.firstname,u.lastname,u.firstnamephonetic,u.lastnamephonetic,u.middlename,u.alternatename,u.imagealt,u.email,u.idnumber,u.username FROM mdl_dataform_entries e JOIN mdl_user u ON u.id = e.userid LEFT JOIN mdl_dataform_contents c128 ON c128.fieldid = 128 AND c128.entryid = e.id WHERE e.dataid = ? AND e.userid = ? AND e.groupid = ? ORDER BY u.lastname ASC, CAST(c128. AS DECIMAL(65,7)) ASC
[array (
0 => '13',
1 => '6766',
2 => 0,
)]
Error code: dmlreadexception
×Stack trace:
line 486 of /lib/dml/moodle_database.php: dml_read_exception thrown
line 1245 of /lib/dml/mysqli_native_moodle_database.php: call to moodle_database->query_end()
line 234 of /mod/dataform/classes/entry_manager.php: call to mysqli_native_moodle_database->get_records_sql()
line 142 of /mod/dataform/classes/entry_manager.php: call to mod_dataform_entry_manager->fetch_entries()
line 332 of /mod/dataform/classes/pluginbase/dataformview.php: call to mod_dataform_entry_manager->set_content()
line 315 of /mod/dataform/classes/pluginbase/dataformview.php: call to mod_dataform\pluginbase\dataformview->set_entries_content()
line 466 of /mod/dataform/classes/dataform.php: call to mod_dataform\pluginbase\dataformview->display()
line 71 of /mod/dataform/view.php: call to mod_dataform_dataform->display()

This has been tested on another Moodle site where the same behaviour occurs, in that a restored version of it will fail when adding new entries, and a copy with the same settings made from scratch works but a duplicate of that will not.

This is occurring on a Moodle 3.5.6 instance. The error should recreate by restoring the attached file .mbz file in the .zip into a course. If you'd like to test the form when it's working it seems you will need to create it from scratch.

Any ideas what may be caused this and what the solution may be? Thanks for any help that can be offered.

dataform error.zip

Kind regards,

Sam

Warning: Declaration of mod_dataform\plugininfo\dataformfield::load_settings(mod_dataform\plugininfo\part_of_admin_tree $adminroot, $parentnodename, $hassiteconfig) should be compatible with core\plugininfo\base::load_settings(part_of_admin_tree $adminroot, $parentnodename, $hassiteconfig) in /opt/lampp/htdocs/moodle/mod/dataform/classes/plugininfo/dataformfield.php on line 212

Warning: Declaration of mod_dataform\plugininfo\dataformview::load_settings(mod_dataform\plugininfo\part_of_admin_tree $adminroot, $parentnodename, $hassiteconfig) should be compatible with core\plugininfo\base::load_settings(part_of_admin_tree $adminroot, $parentnodename, $hassiteconfig) in /opt/lampp/htdocs/moodle/mod/dataform/classes/plugininfo/dataformview.php on line 212

I am using Moodle 3.3.1 (Build: 20170710) with Dataform 3.0.4 (2015111604). In a group peer review activity, I get notified when students upload their first draft, review, or final draft. When I grade their review, they do not receive an email. Can you please help me and find out what I need to change so that students will receive an email notification after I have graded their review?

As I couldn't attach the Dataform preset file, I uploaded the file to my Dropbox. HERE is the link.

I recently upgraded to Moodle 3.3.4 (Build: 20180208), and upgraded mod_dataform to 3.3.2, afterwards got this error:

Debug info: Unknown column 'e.type' in 'field list'
SELECT e.id, e.dataid, e.state, e.timecreated, e.timemodified, e.userid, e.groupid, e.type , u.id AS uid ,u.picture,u.firstname,u.lastname,u.firstnamephonetic,u.lastnamephonetic,u.middlename,u.alternatename,u.imagealt,u.email,u.idnumber,u.username FROM mdl_dataform_entries e JOIN mdl_user u ON u.id = e.userid WHERE e.dataid = ? ORDER BY e.id ASC 
[array (
0 => '11',
)]
Error code: dmlreadexception
Stack trace:
line 486 of /lib/dml/moodle_database.php: dml_read_exception thrown
line 1216 of /lib/dml/mysqli_native_moodle_database.php: call to moodle_database->query_end()
line 234 of /mod/dataform/classes/entry_manager.php: call to mysqli_native_moodle_database->get_records_sql()
line 142 of /mod/dataform/classes/entry_manager.php: call to mod_dataform_entry_manager->fetch_entries()
line 332 of /mod/dataform/classes/pluginbase/dataformview.php: call to mod_dataform_entry_manager->set_content()
line 315 of /mod/dataform/classes/pluginbase/dataformview.php: call to mod_dataform\pluginbase\dataformview->set_entries_content()
line 466 of /mod/dataform/classes/dataform.php: call to mod_dataform\pluginbase\dataformview->display()
line 71 of /mod/dataform/view.php: call to mod_dataform_dataform->display()

as per https://moodle.org/plugins/mod_dataform, it seems there are others experiencing this error, too.

Hi Itamar,

Thank you for the updated versions. I upgraded Dataform, Dataform access-view and Dataform notification to the version for Moodle 3.0. During the upgrade of Dataform, I got a "missing file" for Dataform view and had to manually add the folder. Now the Plugins overview looks like this:

With kind regards,
Hartmut

I'm thrilled to hear in the other open issue you are working on a new version release. Currently, it appears that the interface for adding and editing dataforms is broken when installing on Moodle (in 3.0.1-3.3+) using PHP 7, but seems to work with PHP 5.6 on those releases. With the release of Moodle 3.4, Moodle has dropped support for PHP 5.6. Is PHP 7 support expected with your next release?

Hello, I am having an issue when I try to write a comment.
The reference on my view is ##comments## and I tried with ##comments:inline## too and same error. The error is a pop-up window telling me "dataform/invaliddataform" and the comment is not submitted.

I checked the availability of posting comments in my platflorm and it is enabled.

Any suggestions??

Thank you very much. This mod is awesome!

If you try to add picture field in v2.8.6 there's no way how to specify dimensions of the image. Everything works fine on master.

Hi Itamar,

We recently upgraded to Moodle 3.0.1 and use the theme Shoehorn. When I tried to access a new Dataform activity today, I couldn't view it and got the following debug message:

Debug info: Argument 1 passed to mod_dataform_entry_manager::get_sql_query() must be an instance of mod_dataform\pluginbase\dataformfilter, null given, called in [dirroot]/mod/dataform/classes/entry_manager.php on line 294 and defined
Error code: codingerror
Stack trace:
line 418 of /lib/setuplib.php: coding_exception thrown
line 149 of /mod/dataform/classes/entry_manager.php: call to default_error_handler()
line 294 of /mod/dataform/classes/entry_manager.php: call to mod_dataform_entry_manager->get_sql_query()
line 134 of /mod/dataform/classes/entry_manager.php: call to mod_dataform_entry_manager->fetch_entries()
line 312 of /mod/dataform/classes/pluginbase/dataformview.php: call to mod_dataform_entry_manager->set_content()
line 295 of /mod/dataform/classes/pluginbase/dataformview.php: call to mod_dataform\pluginbase\dataformview->set_entries_content()
line 463 of /mod/dataform/classes/dataform.php: call to mod_dataform\pluginbase\dataformview->display()
line 71 of /mod/dataform/view.php: call to mod_dataform_dataform->display()

Here is an overview of all additional plugins:
Plugins_ Plugins overview.pdf

With kind regards,
Hartmut

It seems I have to click every submodule plugin to completely remove the plug.
(The main issue is that we have 30 servers 😢 )
Please advise

dataformfield
entryactions חסר מהדיסק
dataformfield_entryactions
תוסף 2014051300 הסרה
entryauthor חסר מהדיסק
dataformfield_entryauthor
תוסף 2014051300 הסרה
entrygroup חסר מהדיסק
dataformfield_entrygroup
תוסף 2014051300 הסרה
entrystate חסר מהדיסק
dataformfield_entrystate
תוסף 2014051300 הסרה
entrytime חסר מהדיסק
dataformfield_entrytime
תוסף 2014051300 הסרה
file חסר מהדיסק
dataformfield_file
תוסף 2014051300 הסרה
number חסר מהדיסק
dataformfield_number
תוסף 2014051300 הסרה
picture חסר מהדיסק
dataformfield_picture
תוסף 2014051300 הסרה
radiobutton חסר מהדיסק
dataformfield_radiobutton
תוסף 2014051300 הסרה
ratingmdl חסר מהדיסק
dataformfield_ratingmdl
תוסף 2014051300 הסרה
select חסר מהדיסק
dataformfield_select
תוסף 2014051300 הסרה
selectmulti חסר מהדיסק
dataformfield_selectmulti
תוסף 2014051300 הסרה
text חסר מהדיסק
dataformfield_text
תוסף 2014051300 הסרה
textarea חסר מהדיסק
dataformfield_textarea
תוסף 2014051300 הסרה
time חסר מהדיסק
dataformfield_time
תוסף 2014051300 הסרה
url חסר מהדיסק
dataformfield_url
תוסף 2014051300 הסרה
dataformview
aligned חסר מהדיסק
dataformview_aligned
תוסף 2014051300 הסרה
csv חסר מהדיסק
dataformview_csv
תוסף 2014051300 הסרה
grid חסר מהדיסק
dataformview_grid
תוסף 2014051300 הסרה
interval חסר מהדיסק
dataformview_interval
תוסף 2014051300 הסרה
rss חסר מהדיסק
dataformview_rss
תוסף 2014051300 הסרה
tabular חסר מהדיסק
dataformview_tabular
תוסף 2014051300 הסרה

Hello Itamar,
at first, thanks for all the hard work you have done on this project. I can imagine those hours. Anyway, I wanted to ask about the status of this project. I think a lot of people use your plugin at their sites, but there has been no activity here on github or at official plugin site for quite a long time.
You mentioned tversions for moodle 3.5 and 3.6 in discussions on March 11 2019

Just about to release for 3.5 and 3.6. I've made a couple of major changes in the auto activity grading feature and access rules feature. The auto activity grading has been moved to a ad-hoc task and now requires adding a designated field to the activity in order to activate the grading. The field can be configured to trigger grading on entry events or on submission. The three current access rule plugins (view, entry, field) have been consolidated into one. There is currently no direct upgrade for these changes so I'm wondering, how many are actually using these two features.

Can you please post some of your thoughts about this plugin, please? Many of us need to make decision wheater to stay with the plugin and hack it for new versions or abandon your plugin and look for sth else.

Thank you Martin