Iterable SDK hanging my app about swift-sdk

[jbelkins]

Apple's documentation for UNUSerNotificationCenter's getNotificationSettings(completion:) method says the completion block "may execute [the completion] block on a background thread" (my emphasis on "may".)

I would read this to imply that the completion block may be called on the main thread under some circumstances, which would explain the deadlock that apparently is happening in my app.

In any case, it's poor practice to wait the main thread on a semaphore while stuff happens on other threads, and this code should be changed to not block the main thread that way.

[tapashmajumder]

@jbelkins Thank you for brining this to our attention. We have not seen this issue locally.

We will greatly appreciate if you can try our solution and provide feedback once we commit this to a branch.

[tapashmajumder]

@jbelkins Agreed. Our code earlier was non-blocking and this code was introduced via due to some other problems. We will be looking at this issue with high priority.

[jbelkins]

Thanks for your prompt attention. Please tag me when you publish a fix and I'll ship it as soon as I can.
FYI I just filed an Iterable support ticket citing this Github issue as well.

[tapashmajumder]

Thanks. The ticket is implemented and is being reviewed. We will be publishing a fix soon.

[tapashmajumder]

@jbelkins We have the fix merged in master branch. Would you be able to try that?

[jbelkins]

@tapashmajumder Might be middle of next week before I can put up a new app release. If you can get this tested at your end, you should go ahead & release it.

And if I do ship this fix before it's published, rather than take everything in master, I'll lock to this commit: bccfb50 Would that work?

[tapashmajumder]

@jbelkins Yes that is the right commit if you can release.

Master currently has a security fix which we would like to release together with other security tickets that we are currently working on. So it may take us some time (probably around 7-10 days or so) to publish our next release.

[jbelkins]

@tapashmajumder Just shipped this fix today. I should be able to say whether this is fixed in about a week or so.

[tapashmajumder]

Hi @jbelkins Thank you so much. Please keep us updated. We will be releasing a new version with this and a few other fixes in a week or two.

[jbelkins]

I’ve had this fix in production for about 9 days now and no reoccurrences thus far. I think this can be closed now.

Please let me know when this ships in a stable release.

[tapashmajumder]

@jbelkins That is great news. I will update when we ship this change.

[tapashmajumder]

This issue is fixed in latest release 6.4.0. Closing.