itplusx / flexible_pages Goto Github PK

Currently the field l18n_cfg is not taken into account when fetching pages for the PageList CE. This has the effect, that pages where the the Hide default language of page or Hide page if no translation for current language exists checkboxes are set are being fetched as well even though they should not.

I would propose to dump the usage of the DatabaseQueryProcessor for this purpose and and write a custom PageListProcessor. In this processor we could easily make use of methods like \TYPO3\CMS\Frontend\Page\PageRepository::isPageSuitableForLanguage to determine if a page should be rendered in the specific language.

According to composer definition only PHP 7.2 is supported, while accordind to Typo3 upto PHP 8 is supported.

Updating dependencies
Your requirements could not be resolved to an installable set of packages.

  Problem 1
    - Root composer.json requires itplusx/flexible-pages ^2.2 -> satisfiable by itplusx/flexible-pages[v2.2.0].
    - itplusx/flexible-pages v2.2.0 requires php ^7.2 -> your php version (8.0.0; overridden via config.platform, actual: 8.0.13) does not satisfy that requirement.

Hello, when I want to install the extension I get the following error message in the console, even with the dev branch

Problem 1
- Conclusion: don't install itplusx/flexible-pages v2.1.1
- Conclusion: remove symfony/finder v5.1.8
- Installation request for itplusx/flexible-pages ^2.1 -> satisfiable by itplusx/flexible-pages[v2.1.0, v2.1.1].
- Conclusion: don't install symfony/finder v5.1.8
- itplusx/flexible-pages v2.1.0 requires symfony/finder ^4.4 -> satisfiable by symfony/finder[v4.4.0, v4.4.1, v4.4.10, v4.4.11, v4.4.12, v4.4.13, v4.4.14, v4.4.15, v4.4.16, v4.4.17, v4.4.18, v4.4.2, v4.4.3, v4.4.4, v4.4.5, v4.4.6, v4.4.7, v4.4.8, v4.4.9].
- Can only install one of: symfony/finder[v4.4.0, v5.1.8].
- Can only install one of: symfony/finder[v4.4.1, v5.1.8].
- Can only install one of: symfony/finder[v4.4.10, v5.1.8].
- Can only install one of: symfony/finder[v4.4.11, v5.1.8].
- Can only install one of: symfony/finder[v4.4.12, v5.1.8].
- Can only install one of: symfony/finder[v4.4.13, v5.1.8].
- Can only install one of: symfony/finder[v4.4.14, v5.1.8].
- Can only install one of: symfony/finder[v4.4.15, v5.1.8].
- Can only install one of: symfony/finder[v4.4.16, v5.1.8].
- Can only install one of: symfony/finder[v4.4.17, v5.1.8].
- Can only install one of: symfony/finder[v4.4.18, v5.1.8].
- Can only install one of: symfony/finder[v4.4.2, v5.1.8].
- Can only install one of: symfony/finder[v4.4.3, v5.1.8].
- Can only install one of: symfony/finder[v4.4.4, v5.1.8].
- Can only install one of: symfony/finder[v4.4.5, v5.1.8].
- Can only install one of: symfony/finder[v4.4.6, v5.1.8].
- Can only install one of: symfony/finder[v4.4.7, v5.1.8].
- Can only install one of: symfony/finder[v4.4.8, v5.1.8].
- Can only install one of: symfony/finder[v4.4.9, v5.1.8].
- Installation request for symfony/finder (locked at v5.1.8) -> satisfiable by symfony/finder[v5.1.8].

There is also an mountpoint variant of a page (if content_from_pid is set). We should consider to make this editable with a mountpointIcon option.

Example:

dokType: 87
label: 'My Custom pageType'
iconSet:
  defaultIcon:
    # 'source' or 'identifier'
  hideInMenuIcon:
    # 'source' or 'identifier'
  rootPageIcon:
    # 'source' or 'identifier'
  mountpointIcon:
    # 'source' or 'identifier'

We should make the defaultIcon setting optional and create generic icons if no icons are defined. With this improvement the minimum setup of a new page type would be only dokType and label.

I think it's better to keep the README slim and to add additional information (like https://github.com/itplusx/flexible_pages#2-registering-custom-pages-types or https://github.com/itplusx/flexible_pages#2-registering-custom-pages-types) as Documentation.

We could either use the GitHub Wiki for that or even the TYPO3 recommended way (https://docs.typo3.org/m/typo3/reference-coreapi/master/en-us/ExtensionArchitecture/Documentation/Index.html)