ixhbinphoenix / bne

bne's Issues

bug: Weirdly formatted LBs in LBOS plan

The Lernbuero in the second lesson on wednesday is formatted to be a single lesson with two teachers and two rooms. Either we accomodate for this type of lesson, or we talk with the Oberstufenleitung

wrong grammar used at index page

"Dein Tag auf einen Blick" ist falsch. Dein im Akkusativ ist "deinen". Richtig wäre dementsprechend: "Deinen Tag auf einen Blick" [1]

serviceWorker not included in SSR-bundle

The .ts files including the service Worker aren´t bundled on build, because they aren´t imported anywhere, but only loaded during runtime. Therefore they don´t exist in the finished bundle.

Recreation:

Start pnpm preview with node as the serverless adapter.
Open dev tools and get the 404 error

Fixes:
Find a good way to include the files in the finished bundle.
The best approach to me currently is to change the rollup config into bundling the files seperatly

login method returns 500 Internal Server Error if user does not exist

The login method returns 500 Internal Server Error, if the user you try to login does not exists

feat(timetable): select from all classes

Give users the choice to view the timetable of all different classes.
Should be pretty simple. Add the class as a query parameter to the backend and then fetch the data from untis for that class.

chore: Unit testing

ci: Make clippy check run within nix

Vercel Internal Server Error CryptoJS

When the branch deploys to Vercel, the build is successfull, but the browser shows that it has crashed.
This seems to be caused by a wrong import of the CryptoJS module, since it is a CommonJS module which is imported via a named import. Oddly enough, I could not recreate the error on my machine, it only happens on Vercel.
The problem is that all other normal ways to import it result in the same error.

Ways to fix: Find a working way to import CryptoJS to vercel.

Lbs not counted when in triple lesson

LBs that are directoy before or after their own double-lesson are merged into triple lessons and therefore not counted as LBs.
We should change how lessons are chained, because triple lessons don't exist in Oberstufe, unless they are Sports or Exams

i18n

bug: Looking too far into the Future DOSs the API

If you look to far into the future (Summer break) you will get an Untis Error. This wouldn't be a Problem if we didn't just recently introduce re-trying if it fails, which in this case results in an infinite loop of requests until you get ratelimited

feat: Add Desktop notifications

Send Push Notifications to the client, if a lesson is cancelled.

1. Add a Service Worker to periodically fetch data from the Server
2. Check if there are new cancelled lessons
3. If so, send a notification to the client

Lessons without subject are counted as LBs

Lessons without subjects are treated like LBs, but they are infact buggy data from untis

Inter font not loading on vercel

The Inter font is not loading on desktop when opening the vercel deployment.
Oddly enough it is working on mobile (safari) and localhost on desktop.

Recreate:
Open https://bne-git-frontendfixes-ixhbinphoenix.vercel.app

Open Dev Console and see the error

Fix:
Find out why the font doesn't load on vercel.

bug: Single exam lessons get counted as LBs of that teacher

Markdown content crashes vercel deployment

Markdown content seems to brake vercel´s deployment.

Impressum

Adress is wrong in the Impressum.
The Correct Adress is Beethovenstraße 28 not 18

Increase rate limit

We have way too many server resources to rate limit normal usage

Add a regression issue label

Free room panic

get_free_rooms panics in line 687 because index is out of bounds.

Better Contact Page

Backend always error on valid /get_timetable in prod

When a user (that has manually changed the JSESSIONID cookie to apply to both domains) tries requesting their timetable or the lernbüros, the backend server instantly exists with Code 0 without any traces in the logs, not even the request that caused the crash is mentioned. This does not happen in debug builds, where the methods still dont work, but return a 'Untis done fucked up' error instead of instantly exiting.

I will provide logs later today

Bump actix-session-surrealdb to 0.1.8

Also bumps:

• MSRV -> 1.75
• actix-session -> 0.9.0
• surrealdb -> 1.1.0

More descriptive error messages when getting rate-limited

Currently, when getting rate-limited in the Stundenplan or lernbueros, a JSON parse error (not really readable for normal people) is displayed. This tells most users nothing and should instead be replaced with an error message telling them they're going too fast. While we're at it, we should increase the rate-limit.

Upgrade Astro to v4

Somewhere along the way Astro added better support for env variables which we need for better prod deploys. I tried it, didn't fucking work, so It's @Sxyntheon 's Problem now

feat: timetable for empty rooms

lernbuero api sends wrongs lessons sometime

The lernbuero API sometimes sends wrong lessons.
They all seem to be Q2 lessons and may be caused by Zusatzkursen or Abiturprüfungen.

Recreate:
Open the lernbuero page and check the data against Untis

Solve:
Find the reason for this problem and fix it :)

chore: Rewrite our HTTP Error responses so they can be the correct codes

get_timetable panics when length of lessons is 0

get_timetable panics if len is 0. This seems to occur durng holidays.
The error leads the GET request to just end and send nothing back to the client.

Remove LBs in Sporthalle

JSESSIONID Cookie not set correctly for both domains

Currently the JSESSIONID cookie is assigned to "theschedule.de", which excludes the api server (api.theschedule.de) from accessing it. The correct way to make it accessible to both subdomains is settings the cookie domain to ".theschedule.de", but for some reason just setting this domain in the document.cookie string doesn't work

Specific LBs not shown

Monday the N0 LB from KGÜN is in the 6th and 7th Lesson which is wrong since only the one in the 7th Lesson is a Lernbüro.

FSMI LB in the 7th Lesson on Friday isn't shown.

SGEU LB in the 3th Lesson on Thursday isn't shown.

Tuesday 3th Lesson DMÄN LB isn't shown.

The 2 LBs from JMÜL on Thursday in the 1st and 2nd Lesson aren't shown since they don't count as LBs according to Untis

Friday in the last Lesson there is a N0 LB that isn't shown by MVME

Higher visibility for cancelled lessons

Currently it's quite hard to see if a lesson is cancelled, being indicated only by struck-through room number and teacher. Instead of only showing the room and teacher struck-through we should somehow mark the whole lesson as cancelled, implementation details pending.

Caching Lernbüros

We should cache lernbüros because they are the same for everyone, but they should be updated frequently too keep up with cancelled lessons

PWA Icons corrupted on Vercel Deployment

The PWA Icons can not be loaded in vercel deployments because the files are corrupted.
Building and running local doesn´t produce this error.

My first guess would be that Vercel handles png images in a special way that breaks them in our case.

I´d like someone else take a look at this to verify if I missed something.

Don't filter cancelled lernbueros

Cancelled lernbueros should still show up in the plan so that students

1. Know that they're still there
2. Can write EVA or go to a parallel lernbuero

feat: 'Loading...' popup on the LB Plan

get_lernbueros requests can take upwards of 700ms and it would be pretty nice for users to know that its actually doing something in that time

No more 'coming soon'!

feat: Support Teacher accs

api returns "---" instead of null

The backend server returns --- if a lesson doesn´t take place. null would be easier to process on the frontend.

ci: Only run docker build and clippy in commits that affect backend/flake

regression: Lernbueros partially 'slide'

In the Lernbuero plan, some lernbueros, or sometimes only parts of the lernbuero like the teacher label, are displayed in the wrong spots.

This was previously not the case and must have been introduced in one of the merges yesterday.

Single lessons from additional classes are counted as LBs

Single lessons from ZK classes like Geschichte ZK in Q2 are counted as LBs, eventough they aren´t open

bug: Double LB in LBOS gets recognized as block lesson

The double lb by schmitte in the 5th and 6th lesson on wednesday from the LBOS plan doesnt get recognised as a LB, partly because both lessons are entered as Info. Options here are the same as #120