j7b / jsplayground Goto Github PK

$ go run generate.go github.com/hajimehoshi/ebiten
Building in /tmp/jsplayground-518207278
Installing additional packages
Couldn't add get for imports.json
Couldn't add -m for imports.json
Using GOROOT /usr/local/go/src
JS Playground packages at /tmp/jsplayground-518207278/pkg

Probably something misunderstands that 'get' and '-m' are kind of package?

This is a complicated but not unreasonably - basically jsplayground.go needs to detect it's running in a node environment and preload what jsplayground looks for in playground from pkg in the gopath first and goroot second on the assumption gopherjs serve won't work without the gopherjs pkg's somewhere and use the baked-in map that becomes imports.json

Now there are two main packages in the same directory, and I was confused that the binary 'jsplayground' indicated which main package. Can we separate them in separate directories?

BTW, I think gopherjs install github.com/j7b/jsplayground doesn't make sense at https://github.com/j7b/citesting/blob/master/.travis.yml and the jsplayground binary is already installed by go get -v github.com/j7b/jsplayground.

fasttest.html can't be executed with such pkg. Is this correct?

https://github.com/j7b/jsplayground/blob/master/jsplayground.go#L190

In theory, executing a goroutine is deferred by infinite time, so it looks like there is not guarantee that g.packages[path] = p is called before accessing g.packages[path]. Is the goroutine there really needed?