Repo for containing issues as part of new project boards demo
jackeallen / newprojectboardsdemo Goto Github PK
View Code? Open in Web Editor NEWRepo for containing issues as part of new project boards demo
Repo for containing issues as part of new project boards demo
Lock spectrum viewer window sidebar in position.
Sidebar is not locked in place which means it's easy for the user to minimise and potentially struggle to understand how to get back again.
What is the acceptance criteria?
Why it is needed?
Where required files/links are
Open | Closed |
---|---|
![]() |
![]() |
verbose instructions for the reviewer to test changes
As a User: I would like the export spectrum button to be disabled if there is not a currently active stack in the spectrum viewer window as currently this causes a ValueError.
The export spectrum button should be disabled if there is not a currently active stack in the spectrum viewer window.
What is the acceptance criteria?
Why it is needed?
Where required files/links are
verbose instructions for the reviewer to test changes
File > Load dataset > Sample
Create "Add ROI" button to spectrum viewer window which can create multiple ROIs.
No functionality exists for this feature yet.
What is the acceptance criteria?
Why it is needed?
Where required files/links are
verbose instructions for the reviewer to test changes
Normalise drop-down is enabled when the window first opens even though the checkbox is unticked by default. Toggling the checkbox after that has the correct enable/disable behaviour, though.
Under the spectrum plot add a text status line that shows the min and max values of the current range. Similar to the line profile values in the recon window.
ToF range: 100 - 800
I've pushed everything I've prepared on this to branch 1498-add-spectrum-viewer, so you should be able to pick the branch up to start looking at the ROI side when you're ready. The things I've put in place are:
Adding "Spectrum Viewer" to the "Workflows" menu in the main window. Clicking this option opens the spectrum viewer in a new window (this is why I wasn't keen to put it into PR at this stage, although if this was temporarily removed the rest could probably go in if needed).
The layout for the new window has a splitter, the same as the recon and operations windows use, to separate the section for input fields and the section for the image. The layout is likely to need resizing/settings tweaks as you continue to work on it, particularly around what happens when you re-size.
I've setup the two dropdowns to populate with stacks from the main window using the DatasetSelectorWidget. The second dropdown can be enabled and disabled with a checkbox. For now I've left it so that the checkbox simply enables and disables the dropdown, I figured we could decide further down the line if there was a need for it to do anything with the contents of the dropdown when the state changes.
The second dropdown will automatically try to select a flat for the selected sample dataset, if one is available. I've noticed that if you keep the window open, delete all the datasets in the main window and then (with the window still open) reload a dataset it doesn't correctly select the flat. This seemed a very minor, niche issue and so I didn't want to delay handing this over to fix it. I can continue to investigate and comment here with anything I find about how to resolve it, though.
Runtime error if delete all but a single image stack while spectrum viewer window is opened - to reproduce, load a dataset and then load an image to the tree view. Open spectrum viewer window. Delete the dataset so that only the image stack is in the tree view. A runtime error should occur.
SpectrumViewerWindowPresenter currently has things like self.view.spectrum.spectrum.clearPlots()
and self.view.spectrum.image.setImage()
. Add methods to the view to hide the details from the presenter.
Allow all ROIs added to spectrum viewer window to be draggable.
Can create ROIs, but unable to move/drag them implemented as part of #1620
What is the acceptance criteria?
Why it is needed?
Where required files/links are
verbose instructions for the reviewer to test changes
Allow normalising to an open beam, by enabling a checkbox.
Spectrum should show sample / open. (with divide by zero handled safely)
Allow all ROIs added to be viewed within a table in the spectrum viewer window sidebar using the reconstruction windows COR table for design inspiration (See umbrella issue for image of COR table).
The table should display the name (ID) for each ROI added and a key to describe the colour each ROI is set too using squares e.g. ๐ฆ ๐ฅ ๐ฉ
ROI | Colour |
---|---|
roi_id_1 | ๐ฉ |
Can create ROIs, but unable to see them in a table in the sidebar.
What is the acceptance criteria?
Why it is needed?
Where required files/links are
verbose instructions for the reviewer to test changes
Implement CSV export in the spectrum viewer window
A bit more needs to be done when switching stacks.
Auto Zoom if sized changed
Auto levels?
Handle switching to None
Handle selected stack being closed in main window.
When the spectrum window is first opened no stack is shown. The first sample stack should be shown.
Current work around is to select a different stack and then reselect the one that you want to see.
Double check that available flat stacks are selected by default in the open beam dropdown, including when the window first opens, even if "flat" doesn't appear in the file name.
Add a Region of Interest rectangle to the image view in the spectrum window.
The spectrum should show the values for the RoI area.
Encapsulate deep calls made from the view through to the SpectrumWidget, i.e. self.spectrum.image.setImage in the view would become self.spectrum.set_image() and self.spectrum.spectrum.plot becomes self.spectrum.plot(), etc.
CSV should have sample, open and normalised values.
Add a range control to the spectrum.
Update the main view with the selected subset
As an instrument Scientist, I want to create multiple ROIs within the spectrum viewer window.
Acceptance Criteria
why it is needed?
Where required files/links are
Reconstruction Window COR Table:
Verbose instructions for the reviewer to test changes
(To be filled out on completion of ticket)
Add an image view and spectrum viewer to the spectrum viewer dialog.
A declarative, efficient, and flexible JavaScript library for building user interfaces.
๐ Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
An Open Source Machine Learning Framework for Everyone
The Web framework for perfectionists with deadlines.
A PHP framework for web artisans
Bring data to life with SVG, Canvas and HTML. ๐๐๐
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
Some thing interesting about web. New door for the world.
A server is a program made to process requests and deliver data to clients.
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
Some thing interesting about visualization, use data art
Some thing interesting about game, make everyone happy.
We are working to build community through open source technology. NB: members must have two-factor auth.
Open source projects and samples from Microsoft.
Google โค๏ธ Open Source for everyone.
Alibaba Open Source for everyone
Data-Driven Documents codes.
China tencent open source team.