jackrl / bomberguy Goto Github PK

Project downloaded: 3.2.2015 12:30

The project seems to be in quite a good shape already. The classes, their interaction and the packages are logical, and the class diagram was easy to interpret. Everything in the source code seemed to be well named and divided into logical methods, and well placed comments helped reading it. The structure of the program seems to support adding more levels and other functionality later.

I tried very hard to find something I would fix, but it seemed like a mission impossible. The only thing I could think of is the small amount of tests: most of the classes weren’t JUnit-tested at all, and classes like Level could have used a few more tests. Besides that I could only find some typos in comments (”controll” in Controller etc.), but nothing that would really matter.

I couldn’t get the project to work with NetBeans on Windows (”unloadable”), so I couldn’t run it or see the test results. Maybe that could have been instructed more clearly in the instructions, although it wasn’t really required at this point I suppose. So, if the game runs just well already, I don’t know how much more tests would really help at this point, besides support adding more functionality.

The enemy class wasn't implemented yet, but when it is, maybe it could use a generic class Enemy which would then be extended by different enemy types. Unless there's supposed to be only 1. Same goes for Power-ups and Walls.

All in all: good job, keep it up.