bomberguy's People
bomberguy's Issues
Code review
Project downloaded: 3.2.2015 12:30
The project seems to be in quite a good shape already. The classes, their interaction and the packages are logical, and the class diagram was easy to interpret. Everything in the source code seemed to be well named and divided into logical methods, and well placed comments helped reading it. The structure of the program seems to support adding more levels and other functionality later.
I tried very hard to find something I would fix, but it seemed like a mission impossible. The only thing I could think of is the small amount of tests: most of the classes weren’t JUnit-tested at all, and classes like Level could have used a few more tests. Besides that I could only find some typos in comments (”controll” in Controller etc.), but nothing that would really matter.
I couldn’t get the project to work with NetBeans on Windows (”unloadable”), so I couldn’t run it or see the test results. Maybe that could have been instructed more clearly in the instructions, although it wasn’t really required at this point I suppose. So, if the game runs just well already, I don’t know how much more tests would really help at this point, besides support adding more functionality.
The enemy class wasn't implemented yet, but when it is, maybe it could use a generic class Enemy which would then be extended by different enemy types. Unless there's supposed to be only 1. Same goes for Power-ups and Walls.
All in all: good job, keep it up.
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.