jackw / eyeglass-image-dimensions

An eyeglass module giving node-sass the same image dimension functionality found in ruby compass.

eyeglass-image-dimensions

An eyeglass module to give node-sass the same image dimension functionality found in ruby compass.

Setup

To use image dimensions first install eyeglass then eyeglass-image-dimensions:

npm install eyeglass eyeglass-image-dimensions --save-dev

Then add the following to your sass file/s:

@import 'image-dimensions';

Usage

image-width

returns the width of the image in pixels.

width: image-width($image);

image-height

returns the height of the image in pixels.

height: image-height($image);

image-dimensions

returns a space separated list consisting of the width and height of an image in pixels.

background-size: image-dimensions($image);

eyeglass-image-dimensions's Issues

Consider using ">=0.8.0" for eyeglass "needs"

Hi,

I'm getting this messages when I compile my SASS files:

The following modules are incompatible with eyeglass 1.2.1:
  image-dimensions needed eyeglass ^0.8.0

Is it possible to change the compatibility line to "needs": ">=0.8.0" ?

As mentioned in sass-breakpoint issue #174:

It maintains current compatibility and future proofs against 1.x releases of eyeglass.

Joanna's feedback

In eyeglass-exports.js line 47, there's no need to loop through each module's assets to get the filepath. Since asset is a map, a map lookup using asset.coerce.get(file) should get the necessary information.

eg-image-width and eg-image-height should each return a Sass number rather than a string. This can be done using sassUtils.castToSass.

eg-image-dimensions should return a space-delimited Sass list. This can be done by calling sassUtils.castToSass on a 2-element array of SassDimensions with the separator set to false.

The convention we've been using is to import eyeglass modules without the eyeglass- prefix. This would just require adding an eyeglass field to package.json and setting the name to image-dimensions.

If the user passes in a real file path rather than an asset path, we should check that it's an absolute rather than a relative file path.

Update the readme to include image-dimensions.

Let's add some tests for the module.