jackyho112 / react-html-attributes Goto Github PK

Hi,

thanks for the great package! It saved me a lot of trouble.

I was wondering if there's a reason why onClick is only considered valid for a tags?

I am writing a parser that builds a React component tree from an HTML string. I have slowly been adding to a map of html attribute names to their React counterparts. It would be nice not to have to do this manually, and I stumbled across this library which gives us all the React attribute names, but not what their "native" names are.

Would a utility function that maps an attribute name to its React equivalent be something that you would be interested in adding to this library?

e.g.

toReactAttribute('allowfullscreen')
//=> 'allowFullScreen'

Cheers

It seems that npm has a version 1.4.3 of this package, and it's unclear what that actually is.

Perhaps we could have a new release (>1.4.3) both here and on npm? I am interested in recent additions, e.g. onFocus, onKeyDown, etc, which are not yet available in the released package.

According to React documentation, form elements should support the following events:

• onChange
• onInput
• onInvalid
• onSubmit

However, they don't seem to be accepted as props in the definition of form

I'm unsure what this is. Could you explain that a little?

@jackyho112 I think you should update the Code of Conduct with your contact information?

html-element-attributes is currently listed as both a peer and regular dependency in package.json. Is this by design?

{
  "dependencies": {
    "html-element-attributes": "^1.0.0"
  },
  "peerDependencies": {
    "html-element-attributes": "^1.0.0"
  },
}

The presence of the peer dependency is currently causing issues with the installation of paypal/glamorous. On npm 2, it leads to an extraneous dependency error and similarly can lead to a missing peer dependency error.

Would it make sense to remove the peer dependency?

Thanks for the work you put into creating this project.

I was looking at the tests files and noticed one test checking if the array is alphabetically sorted. (see here).

Looking at the regex test we have, it looks like it's only checking that the first letter of the first element in the array is an alphabet character, or -. It makes no assumptions about any of the elements actually being in alphabetical order.

For example,

[
  ['carrot', 'apple', 'banana'],
  ['apple', 'carrot', 'banana'],
  ['banana', 'apple', 'carrot'],
]
// would pass your test

Even if the regex test did work, does the ordering of the elements matter?