jaebooker / 2c-2s Goto Github PK

Challenge 1 Feedback : 5/20

Overall: Looks like you copied the starter code and got started on some solid code, but did not finish. Always make sure the code runs on the provided test case before turning in . Be sure to ask for help if you are not understanding how to approach the code.

Feedback based on Challenge 1 Rubric:

• Works: 0
  • Edges are: crashes - need to send the object not the str key to the method get_id.
  • Does not read from file (code is commented out but doesn't work when uncommented.
• Documentation: 1
  • Not all methods have doc strings.
  • No attribution given for code copied from tutorial sample (add a line at the top)
• Code Organization: 2
  • class structure for starter code
  • separate printing from computational functions.
• Testing: 2
  • Has a few tests and some error handling for inputs

Challenge 2 Feedback : 0/20 - re-submit without direct copy.

Overall: This code is copied directly from Ed Mann (https://eddmann.com/posts/depth-first-search-and-breadth-first-search-in-python/) . Thank you for quoting the source, but you need to be able to write the code based on the inspiration, not just copy. Please redo on your own.

(It also doesn't work because you don't read from a file and it isn't documented. Tests for the shortest path method are ok - make sure to add tests for all methods.

Your commit messages are not meaningful. Make sure you are doing committing for each significant change and the commit messages clearly define the changes made.

Feedback based on Challenge 2 Rubric: 5/20 (but giving a score of 0 until updated without direct copy)

• Works: 0
  • Does not read from file
  • Does not give output
• Documentation: 1
  • Not all methods have doc strings.
  • Attribution is given, but code is not commented or modified to meet challenge standards. Inspiration does not mean copy.
• Code Organization: 2
  • Organization of BFS methods is exceptional - rewrite it so you understand it (instead of copy) and this will be a good approach.
  • Consider standardizing naming to graph terminology. You use links and edges to represent edges. You use node and vertex (pick one)
• Testing: 2
  • Has a few tests and some error handling for inputs

Hello, I was just checking your tutorial progress and wanted to note something regarding tests.

• You must write at least one unit test in order for your work to be considered for a grade. Furthermore, if you write only one test, you must score higher in another category on the rubric.