jakelin / swiftlanguageweather

Swift Language Weather is an iOS weather app developed in Swift 4.

Swift Language Weather

SwiftWeather has renamed to Swift Language Weather. Because this repo is ranked number one in Google when we search "Swift Weather", I got an email from Swift Weather Company's lawyer to ask me to change the name because they said they are the owner of U.S. Trademark SWIFT WEATHER. After discussed with them, they were not happy with the name SwiftyWeather. Now the new project name is Swift Language Weather. More details can be found on Issue: Open source project using a registered trademark.

Swift Language Weather is an iOS weather app developed in Swift 4. The app has been actively upgrading to adopt the latest features of iOS and Swift language.

Notices

The current version is working with Xcode Version Xcode 9.1 (9B55). If you are using different Xcode version, please check out the previous releases.

Version 4

This version has been upgraded to support iOS 10+ only using Swift 4.

There is three major version of the app released before.

• V1.0 - Support iOS 7+ using CocoaPods and AFNetworking. README.v1.md and Release V1 - Using CocoaPods and AFNetworking
• V2.0 - Support iOS 8+ using Carthage, Alamofire, and SwiftyJSON. README.v2.md and Release V2.0
• V2.1 - Support iOS 8+ using Alamofire and SwiftyJSON. This version has removed Carthage because some developers don't have a paid Apple iOS developer account, and they have issues to build Carthage packages.
• V3.0 - Support iOS 9+ and Swift 3.

Screenshots

Features

• Swift Programming Language
• Design-driven development - Sketch design file

• Custom UIView

• @IBDesignable and @IBInspectable - Reusable UI components

• UIStackView

• Size Classes - Support different devices with adaptive layout

• MVVM - Reactively update ViewController UI from ViewModel
• Protocol-Oriented Programming - We use Protocol-Oriented Programming in IBAnimatable open source project.
• Value-based programming - Use immutable value anywhere.
• Icon fonts － Use Weather Icons
• SwiftyJSON
• Core Location
• App indexing like CoreSpotlight and NSUserActivity
• Unit Tests
• UI Tests
• Animations

How to build

1. Clone the repository

$ git clone https://github.com/JakeLin/SwiftLanguageWeather.git

2. Install pods

$ cd SwiftLanguageWeather
$ pod install

3. Open the workspace in Xcode

$ open "SwiftWeather.xcworkspace"

4. Sign up on openweathermap.org/appid to get an appid

$ mkdir .access_tokens
$ echo "your-openweathermap-appid" > .access_tokens/openweathermap

Please replace "your-openweathermap-appid" with your actual appid key.

5. Compile and run the app in your simulator

6. If you don't see any data, please check "Simulator" -> "Debug" -> "Location" to change the location.

Requirements

• Xcode 9
• iOS 10+
• Swift 4

swiftlanguageweather's Issues

Could not find member 'subscript'

Hey Jake,

I have what looks like a genuine compiler error when I try to build on my machine.

/Users/peacock/SwiftWeather/Swift Weather/ViewController.swift:79:59: Could not find member 'subscript'

I'm looking into what this could be - something to do with the subscript index on the wrong dictionary element? Forgive me, I'm new to Swift and am largely stabbing in the dark.

I'll keep poking away. :-)

Cheers,
David

iPhone < 5s temperature overlap

If you have temperature in F and use iPhone 5 or 4s, in portrait mode temperature is partially cut.

you might set minimum font size to scale down temperature label a bit

minimumFontSize="18" do the job

version 1 swift compile error,over 15 syntax error

is that cause of the xcode update?

can not build in xcode7-beta4 swift2

hi, I cloned the repo and try to build it in xcode7-beta, and have encounted following build issues.

1. carthage update . error.
   solved.
   1). upgrade carthage to 0.8;
   2). modify Cartfile to

github "Alamofire/Alamofire" "swift-2.0"
github "SwiftyJSON/SwiftyJSON" "xcode7"

Then in xcode, hit Cmd+B, It compliant several errors.
Swift Compiler Error.
Ditto Error.
PBXCp Error.
and so on.
then I stucked at this point. anyone helps?

carthage update failed

*** Fetching SwiftyJSON
*** Fetching Alamofire
*** Checking out Alamofire at "1.3.0"
*** Checking out SwiftyJSON at "2.2.0"
*** xcodebuild output can be found in /var/folders/tf/9pwp1f4s0lv1n861vsyg7mph0000gn/T/carthage-xcodebuild.CBhSqT.log
*** Building scheme "Alamofire iOS" in Alamofire.xcworkspace
** BUILD FAILED **

The following build commands failed:
Check dependencies
(1 failure)
Code Sign error: No code signing identities found: No valid signing identities (i.e. certificate and private key pair) matching the team ID “(null)” were found.
CodeSign error: code signing is required for product type 'Framework' in SDK 'iOS 8.4'
A shell task failed with exit code 65

No such file or directory

diff: /../Podfile.lock: No such file or directory

diff: /Manifest.lock: No such file or directory

error: The sandbox is not in sync with the Podfile.lock. Run 'pod install' or update your CocoaPods installation.

any plan to convert to swift 3?

Temperature result differs from result of other services

Run the app with location London and compare the result with:

https://www.google.de/webhp?sourceid=chrome-instant&ion=1&espv=2&ie=UTF-8#q=weather+london

and

http://openweathermap.org/city/2643743

The results differ a lot.

Correct Image and Font Scale on different Devices?

How do you get the correct Image and Font Scale on different Devices?

I made a stackoverflow question here:
http://stackoverflow.com/questions/30514110/correct-image-and-font-scale-on-different-devices

Thank you for help.

code signing fails with shell script error

mkdir -p /Users/admin/Library/Developer/Xcode/DerivedData/SwiftWeather-alwclfhptqhdecgwwmjsnbhkpwzh/Build/Products/Debug-iphoneos/SwiftWeather.app/Frameworks
rsync --delete -av --filter P .*.?????? --filter "- CVS/" --filter "- .svn/" --filter "- .git/" --filter "- .hg/" --filter "- Headers" --filter "- PrivateHeaders" --filter "- Modules" "/Users/admin/Library/Developer/Xcode/DerivedData/SwiftWeather-alwclfhptqhdecgwwmjsnbhkpwzh/Build/Products/Debug-iphoneos/SwiftyJSON/SwiftyJSON.framework" "/Users/admin/Library/Developer/Xcode/DerivedData/SwiftWeather-alwclfhptqhdecgwwmjsnbhkpwzh/Build/Products/Debug-iphoneos/SwiftWeather.app/Frameworks"
building file list ... done
SwiftyJSON.framework/
SwiftyJSON.framework/Info.plist
SwiftyJSON.framework/SwiftyJSON

sent 408334 bytes received 70 bytes 816808.00 bytes/sec
total size is 408046 speedup is 1.00
Code Signing /Users/admin/Library/Developer/Xcode/DerivedData/SwiftWeather-alwclfhptqhdecgwwmjsnbhkpwzh/Build/Products/Debug-iphoneos/SwiftWeather.app/Frameworks/SwiftyJSON.framework with Identity iPhone Developer: Shekhar Dhotre (4HB6BX3A7J)
/usr/bin/codesign --force --sign A2213B378436E8FFE12E0DFF41B91353E3D57E9A --preserve-metadata=identifier,entitlements '/Users/admin/Library/Developer/Xcode/DerivedData/SwiftWeather-alwclfhptqhdecgwwmjsnbhkpwzh/Build/Products/Debug-iphoneos/SwiftWeather.app/Frameworks/SwiftyJSON.framework'
/Users/admin/Library/Developer/Xcode/DerivedData/SwiftWeather-alwclfhptqhdecgwwmjsnbhkpwzh/Build/Products/Debug-iphoneos/SwiftWeather.app/Frameworks/SwiftyJSON.framework: unknown error -1=ffffffffffffffff
Command /bin/sh failed with exit code 1

requestWhenInUseAuthorization issue

When stopped at the interface asking for WhenInUseAuthorization long enough,
the app will not work until relaunch.
I think the problem is caused by this func in LocationService.swift:

func requestLocation() {
    locationManager.requestWhenInUseAuthorization()
    locationManager.requestLocation()
  }

How viewModel's didSet works since WeatherViewModel is a class

Since WeatherViewModel is a class rather than struct, how viewModel's didSet works after its properties update.
PS: viewModel is a property of WeatherViewController.

swift compiler err

no such module "Alamofire "

follow you "readme", can't fine "Carthage update"

my Xcode version :6.3.1

carthage build faild for segmentation fault 11

*** Fetching SwiftyJSON
*** Fetching Alamofire
*** Checking out Alamofire at "1.2.2"
*** Checking out SwiftyJSON at "2.2.0"
*** xcodebuild output can be found in /var/folders/fz/rlgkcxdn54gcf9lj6t7jf3gm0000gn/T/carthage-xcodebuild.rCGG7b.log
*** Building scheme "Alamofire iOS" in Alamofire.xcworkspace
A shell task failed with exit code 65
Segmentation fault: 11

Xcode Version 6.3.2 (6D2105)
carthage version 0.7.3

Error: Could not find member 'subscript'

I get the above mentioned error at this line in the viewController

if let tempResult = (jsonResult["main"]?["temp"]? as? Double) {

Project does not compile. Build fails - tested with xcode beta 2

Building project failed

I followed the instruction to build to project. However, in the Carthage/build/ios folder, there is only the alamofire.framework but the swfityJSON is missing.

Need the help of the author？

cat: .access_tokens/openweathermap: No such file or directory
error: Missing OpenWeatherMap access token
error: Get an access token from http://openweathermap.org/appid, then create a new file at .access_tokens/openweathermap that contains the access token.

City images are not correct

In weather result screen , city image is static , and it is not correct. Maybe it can be used Flickr API

IBOutlets should be weak

IBOutlet properties should be weak so views can be deallocated by ARC when view controller is deallocated

Error on build

Hi, following the installation instructions the app won't compile:

4) Sign up on openweathermap.org/appid to get an appid, then replace your one in OpenWeatherMapService.swift
private let appId = "your appid from openweathermap.org/appid"

there is no such thing as private let appId in openWeathermapservice.swift.
Looked through the code and it seems like the app tries to get the appid form the plist file.

    // get appId from Info.plist
    let filePath = NSBundle.mainBundle().pathForResource("Info", ofType: "plist")!
    let parameters = NSDictionary(contentsOfFile:filePath)
    let appId = ""

    components.queryItems = [NSURLQueryItem(name:"lat", value:String(location.coordinate.latitude)),
                             NSURLQueryItem(name:"lon", value:String(location.coordinate.longitude)),
                             NSURLQueryItem(name:"appid", value:String(appId))]

    return components.URL
  }
}

I've tried inserting the appid I got from openweathermap inside the let appid but it still doesn't work.

error on compile:

cat: /Users/Ben/.access_tokens/openweathermap: No such file or directory
error: Missing OpenWeatherMap access token
error: Get an access token from http://openweathermap.org/appid, then create a new file at /Users/Ben/.access_tokens/openweathermap that contains the access token.

课程的图片在哪里

build fail

――― MARKDOWN TEMPLATE ―――――――――――――――――――――――――――――――――――――――――――――――――――――――――――

Command

/Applications/CocoaPods.app/Contents/Resources/bundle/bin/pod install

Report

• What did you do?
• What did you expect to happen?
• What happened instead?

Stack

   CocoaPods : 1.0.0.rc.1
        Ruby : ruby 2.2.3p173 (2015-08-18 revision 51636) [x86_64-darwin15]
    RubyGems : 2.5.0
        Host : Mac OS X 10.11.5 (15F34)
       Xcode : 7.3.1 (7D1014)
         Git : git version 2.6.2
Ruby lib dir : /Applications/CocoaPods.app/Contents/Resources/bundle/lib
Repositories : master - https://github.com/CocoaPods/Specs.git @ 9ea777182c3ec95fceda7ee698324f29535b774b

Plugins

cocoapods-check           : 0.2.1.beta.1
cocoapods-deintegrate     : 1.0.0.rc.1
cocoapods-plugins         : 1.0.0.rc.1
cocoapods-plugins-install : 0.0.1
cocoapods-search          : 1.0.0.rc.1
cocoapods-stats           : 1.0.0.rc.1
cocoapods-trunk           : 1.0.0.rc.1
cocoapods-try             : 1.0.0.rc.1

Podfile

platform :ios, '9.0'
use_frameworks!

target 'SwiftWeather' do
    pod 'SwiftyJSON', :git => 'https://github.com/SwiftyJSON/SwiftyJSON.git', :branch => 'xcode7.1'
end

target 'SwiftWeatherTests' do
    pod 'Quick'
    pod 'Nimble'
end

Error

NoMethodError - undefined method `include?' for nil:NilClass
/Applications/CocoaPods.app/Contents/Resources/bundle/lib/ruby/gems/2.2.0/gems/cocoapods-deintegrate-1.0.0.rc.1/lib/cocoapods/deintegrator.rb:57:in `block in deintegrate_shell_script_phase'
/Applications/CocoaPods.app/Contents/Resources/bundle/lib/ruby/gems/2.2.0/gems/cocoapods-deintegrate-1.0.0.rc.1/lib/cocoapods/deintegrator.rb:56:in `select'
/Applications/CocoaPods.app/Contents/Resources/bundle/lib/ruby/gems/2.2.0/gems/cocoapods-deintegrate-1.0.0.rc.1/lib/cocoapods/deintegrator.rb:56:in `deintegrate_shell_script_phase'
/Applications/CocoaPods.app/Contents/Resources/bundle/lib/ruby/gems/2.2.0/gems/cocoapods-deintegrate-1.0.0.rc.1/lib/cocoapods/deintegrator.rb:22:in `block in deintegrate_target'
/Applications/CocoaPods.app/Contents/Resources/bundle/lib/ruby/gems/2.2.0/gems/cocoapods-1.0.0.rc.1/lib/cocoapods/user_interface.rb:63:in `section'
/Applications/CocoaPods.app/Contents/Resources/bundle/lib/ruby/gems/2.2.0/gems/cocoapods-deintegrate-1.0.0.rc.1/lib/cocoapods/deintegrator.rb:21:in `deintegrate_target'
/Applications/CocoaPods.app/Contents/Resources/bundle/lib/ruby/gems/2.2.0/gems/cocoapods-deintegrate-1.0.0.rc.1/lib/cocoapods/deintegrator.rb:8:in `block (2 levels) in deintegrate_project'
/Applications/CocoaPods.app/Contents/Resources/bundle/lib/ruby/gems/2.2.0/gems/cocoapods-deintegrate-1.0.0.rc.1/lib/cocoapods/deintegrator.rb:7:in `each'
/Applications/CocoaPods.app/Contents/Resources/bundle/lib/ruby/gems/2.2.0/gems/cocoapods-deintegrate-1.0.0.rc.1/lib/cocoapods/deintegrator.rb:7:in `block in deintegrate_project'
/Applications/CocoaPods.app/Contents/Resources/bundle/lib/ruby/gems/2.2.0/gems/cocoapods-1.0.0.rc.1/lib/cocoapods/user_interface.rb:63:in `section'
/Applications/CocoaPods.app/Contents/Resources/bundle/lib/ruby/gems/2.2.0/gems/cocoapods-deintegrate-1.0.0.rc.1/lib/cocoapods/deintegrator.rb:6:in `deintegrate_project'
/Applications/CocoaPods.app/Contents/Resources/bundle/lib/ruby/gems/2.2.0/gems/cocoapods-1.0.0.rc.1/lib/cocoapods/installer.rb:499:in `block (3 levels) in deintegrate_if_different_major_version'
/Applications/CocoaPods.app/Contents/Resources/bundle/lib/ruby/gems/2.2.0/gems/cocoapods-1.0.0.rc.1/lib/cocoapods/config.rb:39:in `with_changes'
/Applications/CocoaPods.app/Contents/Resources/bundle/lib/ruby/gems/2.2.0/gems/cocoapods-1.0.0.rc.1/lib/cocoapods/installer.rb:499:in `block (2 levels) in deintegrate_if_different_major_version'
/Applications/CocoaPods.app/Contents/Resources/bundle/lib/ruby/gems/2.2.0/gems/cocoapods-1.0.0.rc.1/lib/cocoapods/installer.rb:498:in `each'
/Applications/CocoaPods.app/Contents/Resources/bundle/lib/ruby/gems/2.2.0/gems/cocoapods-1.0.0.rc.1/lib/cocoapods/installer.rb:498:in `block in deintegrate_if_different_major_version'
/Applications/CocoaPods.app/Contents/Resources/bundle/lib/ruby/gems/2.2.0/gems/cocoapods-1.0.0.rc.1/lib/cocoapods/user_interface.rb:63:in `section'
/Applications/CocoaPods.app/Contents/Resources/bundle/lib/ruby/gems/2.2.0/gems/cocoapods-1.0.0.rc.1/lib/cocoapods/installer.rb:495:in `deintegrate_if_different_major_version'
/Applications/CocoaPods.app/Contents/Resources/bundle/lib/ruby/gems/2.2.0/gems/cocoapods-1.0.0.rc.1/lib/cocoapods/installer.rb:132:in `block in prepare'
/Applications/CocoaPods.app/Contents/Resources/bundle/lib/ruby/gems/2.2.0/gems/cocoapods-1.0.0.rc.1/lib/cocoapods/user_interface.rb:144:in `message'
/Applications/CocoaPods.app/Contents/Resources/bundle/lib/ruby/gems/2.2.0/gems/cocoapods-1.0.0.rc.1/lib/cocoapods/installer.rb:131:in `prepare'
/Applications/CocoaPods.app/Contents/Resources/bundle/lib/ruby/gems/2.2.0/gems/cocoapods-1.0.0.rc.1/lib/cocoapods/installer.rb:113:in `install!'
/Applications/CocoaPods.app/Contents/Resources/bundle/lib/ruby/gems/2.2.0/gems/cocoapods-1.0.0.rc.1/lib/cocoapods/command/install.rb:37:in `run'
/Applications/CocoaPods.app/Contents/Resources/bundle/lib/ruby/gems/2.2.0/gems/claide-1.0.0.rc.1/lib/claide/command.rb:334:in `run'
/Applications/CocoaPods.app/Contents/Resources/bundle/lib/ruby/gems/2.2.0/gems/cocoapods-1.0.0.rc.1/lib/cocoapods/command.rb:50:in `run'
/Applications/CocoaPods.app/Contents/Resources/bundle/lib/ruby/gems/2.2.0/gems/cocoapods-1.0.0.rc.1/bin/pod:55:in `<top (required)>'
/Applications/CocoaPods.app/Contents/Resources/bundle/bin/pod:23:in `load'
/Applications/CocoaPods.app/Contents/Resources/bundle/bin/pod:23:in `<main>'

――― TEMPLATE END ――――――――――――――――――――――――――――――――――――――――――――――――――――――――――――――――

[!] Oh no, an error occurred.

Search for existing GitHub issues similar to yours:
https://github.com/CocoaPods/CocoaPods/search?q=undefined+method+%60include%3F%27+for+nil%3ANilClass&type=Issues

If none exists, create a ticket, with the template displayed above, on:
https://github.com/CocoaPods/CocoaPods/issues/new

Be sure to first read the contributing guide for details on how to properly submit a ticket:
https://github.com/CocoaPods/CocoaPods/blob/master/CONTRIBUTING.md

Don't forget to anonymize any private data!

Carthage build fails

Hi,

I just tried to build your project with Carthage, but I can't go around the issue that Alamofire fails to build due to dependencies. Would you know what is wrong here?

Thanks in advance,
Tiago

xyz:~/Developer/Swift Projects/SwiftWeather-master$ carthage build
*** xcodebuild output can be found in /var/folders/_x/721jc7bj30xfpwf7zn_4sq900000gn/T/carthage-   xcodebuild.UNMFDA.log
*** Building scheme "Alamofire iOS" in Alamofire.xcworkspace
** BUILD FAILED **


The following build commands failed:
    Check dependencies
(1 failure)

doesn't compile in xcode 9

with
pod 'SwiftyJSON' which downloads version 4.0.0 the line let json = JSON(data: unwrappedData)
in file OpenWeatherMapSerivice doesn't compile anymore.

it reports error:
Call can throw, but it is not marked with 'try' and the error is not handled

build failed ):

Error Domain=com.apple.dt.IDESourceControlErrorDomain Code=-1 "Missing extension: public.vcs.subversion" UserInfo=0x7ff7e3e702e0 {NSLocalizedDescription=Missing extension: public.vcs.subversion}
Object: <IDESourceControlManager: 0x7ff7e3d84330>
Method: -loadRepositories
Thread: <NSThread: 0x7ff7e1435b60>{number = 1, name = main}

Can do nothing in my iPhone 5s

Hi JakeLin

I just install the app in my iPhone 5s with 9.1 SDK version. I only can see This page and I can do nothing else.

Error finding location

Error finding location: The operation couldn’t be completed. (kCLErrorDomain error 0.)
I just accepted the location permission message,but nothing happened,throw an error as above..

Open source project using a registered trademark

I received an email from Swift Weather Company. They said they are the owner of U.S. Trademark Registration No. 4175355 for the mark SWIFT WEATHER. And the open source project is in direct conflict with their federal trademark rights. They requested me to change the name of this application and refrain from further use of their mark for any purpose thereafter.

I don't earn any money from this project (even one cent😅). I am seeking advice to handle this issue. I have some potential ideas as below:

1. Modify the README.md file to add some description of Swift Weather Company. Some of the open source projects have sponsors in their README.md. We can do something similar but without charging Swift Weather Company. That can help Swift Weather Company attract more user to use their services.
2. Rename the project. Because there are some external links to the current project from other GitHub projects, blog posts etc. It may cause some problem with the redirection. If we need to rename the project, there some options:
   • SwiftWeatherApp: I am not sure is it same as the current project name SwiftWeather because it still has SwiftWeather within the name.
   • SwiftiOSWeather: It is a little bit weird for me by adding iOS in between. But that should be different from the SWIFT WEATHER trademark.
   • Any better name?

I prefer the first option but am seeking more advice to create a win-win situation.

Fuzzy about the function in Observable.swift

Thanks for your time!This project is really awesome!I dont understand the whole meaning of funcs in Observerable.swift,Could you please convert it into some Objective-C style funcs?Many thanks

how to compile pods_SwiftWeather.framework

Can you provide some instructions on how to compile and import Pods_SwiftWeather.framework? pod install generated the pod project, but it does not appear to be able to build into any target in XCode 7.

Compilation error - AFHTTPRequestOperationManager()

Hey there,

Trying to build this in Xcode 6 Beta 2; I get a few instances of this:

SwiftWeather/Swift Weather/ViewController.swift:51:23: Use of unresolved identifier 'AFHTTPRequestOperationManager'

Am I doing something bone-headed or have I stumbled across a problem here?

Building project failed lost Alamofire

/Users/CTT/Documents/myGitHub/SwiftWeather/SwiftWeatherService/WeatherService.swift:11:8: No such module 'Alamofire'

Why this?

Feature Request

Hi Jake Lin,

Great app! Is it possible to help working in this project? I would like to add a forecast feature and a forecast widget in the notification center. May I fork the project and then make a pull request when I implemented the stuff?

kind regards,

Marc

building error

*** Fetching SwiftyJSON
*** Fetching Alamofire
*** Checking out Alamofire at "1.1.2"
*** Checking out SwiftyJSON at "2.1.3"
*** xcodebuild output can be found in /var/folders/ww/cwp872vd4l14zbc060nmtwp00000gn/T/carthage-xcodebuild.0vAgR7.log
*** Building scheme "Alamofire" in Alamofire.xcworkspace
2015-04-11 17:32:30.852 xcodebuild[3165:177328] [MT] DVTAssertions: Warning in /SourceCache/IDEFrameworks/IDEFrameworks-7569/IDEFoundation/SourceControl/Model/IDESourceControlManager.m:423
Details: Error Domain=com.apple.dt.IDESourceControlErrorDomain Code=-1 "Missing extension: public.vcs.subversion" UserInfo=0x7fc403e8cd50 {NSLocalizedDescription=Missing extension: public.vcs.subversion}
Object: <IDESourceControlManager: 0x7fc401642280>
Method: -loadRepositories
Thread: <NSThread: 0x7fc401436220>{number = 1, name = main}
Please file a bug at http://bugreport.apple.com with this warning message and any useful information you can provide.
** BUILD FAILED **

The following build commands failed:
CompileSwift normal x86_64 /Users/liucheng/Downloads/SwiftWeather-master/Carthage/Checkouts/Alamofire/Source/Alamofire.swift
CompileSwiftSources normal x86_64 com.apple.xcode.tools.swift.compiler
(2 failures)

Update README with Swift3 version

I was deceived by the READE and I had some trouble trying to run from Xcode 7, then I realized the project is already converted to Swift3.