jakesankey / line-diff-details

Atom plugin to review/revert individual line changes

PLEASE NOTE THAT THIS PROJECT IS NOT CURRENTLY UNDER FURTHER DEVELOPMENT.

Line Diff Details

View the git diff for a line by clicking the line number. Optionally revert to or copy original content.

line-diff-details's Issues

Uncaught TypeError: undefined is not a function

[Enter steps to reproduce below:]

1. ...
2. ...

Atom Version: 0.196.0 ⚠️ in 1.0 API Preview Mode ⚠️
System: Mac OS X 10.10.3
Thrown From: line-diff-details package, v1.0.0

Stack Trace

Uncaught TypeError: undefined is not a function

At /Users/jinlong/.atom/packages/line-diff-details/lib/line-diff-worker.coffee:58

TypeError: undefined is not a function
  at LineDiffWorker.findFileDiffs (/Users/jinlong/.atom/packages/line-diff-details/lib/line-diff-worker.coffee:58:29)
  at LineDiffWorker.calculateDiffDetails (/Users/jinlong/.atom/packages/line-diff-details/lib/line-diff-worker.coffee:72:22)
  at HTMLDivElement.<anonymous> (/Users/jinlong/.atom/packages/line-diff-details/lib/line-diff-worker.coffee:30:24)
  at HTMLDivElement.jQuery.event.dispatch (/Applications/Atom.app/Contents/Resources/app.asar/node_modules/jquery/dist/jquery.js:4435:9)
  at HTMLDivElement.elemData.handle (/Applications/Atom.app/Contents/Resources/app.asar/node_modules/jquery/dist/jquery.js:4121:28)

Commands

     -4:49.2.0 fuzzy-finder:toggle-git-status-finder (atom-text-editor.editor.is-focused)
     -4:46.9.0 editor:consolidate-selections (atom-text-editor.editor.mini)
     -4:46.9.0 core:cancel (atom-text-editor.editor.mini)
     -4:02.2.0 command-palette:toggle (atom-text-editor.editor.is-focused)
     -3:38.6.0 core:paste (atom-text-editor.editor.mini)
     -3:38 core:confirm (atom-text-editor.editor.mini)
  2x -3:22.1.0 editor:newline (atom-text-editor.editor.is-focused)
  4x -3:19.9.0 core:backspace (atom-text-editor.editor.is-focused)
  6x -3:15.7.0 core:undo (atom-text-editor.editor.is-focused)
     -1:50.1.0 core:paste (atom-text-editor.editor.mini)
     -1:49.7.0 core:confirm (atom-text-editor.editor.mini)
     -0:26.5.0 editor:delete-line (atom-text-editor.editor.is-focused)
     -0:16.5.0 core:undo (atom-text-editor.editor.is-focused)
     -0:13.5.0 editor:delete-line (atom-text-editor.editor.is-focused)
     -0:04.4.0 core:undo (atom-text-editor.editor.is-focused)
     -0:02.1.0 editor:newline (atom-text-editor.editor.is-focused)

Config

{
  "core": {}
}

Installed Packages

# User
autocomplete-css, v0.6.0
autocomplete-html, v0.6.0
autocomplete-paths, v1.0.2
autocomplete-php, v0.2.6
autocomplete-plus, v2.12.1
autocomplete-python, v0.3.0
color-picker, v1.7.0
git-history, v2.5.0
git-tab-status, v1.7.0
line-diff-details, v1.0.0
linter, v0.12.1
minimap, v4.8.0

# Dev
No dev packages

atom-text-editor.Object.defineProperty.get is deprecated.

The contents of atom-text-editor elements are no longer encapsulated
within a shadow DOM boundary. Please, stop using shadowRoot and access
the editor contents directly instead.

atom-text-editor.Object.defineProperty.get (/usr/share/atom-beta/resources/app.asar/src/text-editor-element.js:58:18)
LineDiffWorker.update (/home/sami/.atom/packages/line-diff-details/lib/line-diff-worker.coffee:30:51)
<unknown> (/home/sami/.atom/packages/line-diff-details/lib/line-diff-worker.coffee:3:61)
Function.module.exports.Emitter.simpleDispatch (/usr/share/atom-beta/resources/app.asar/node_modules/event-kit/lib/emitter.js:25:14)
Emitter.emit (/usr/share/atom-beta/resources/app.asar/node_modules/event-kit/lib/emitter.js:129:28)
<unknown> (/usr/share/atom-beta/resources/app.asar/node_modules/text-buffer/lib/text-buffer.js:1417:25)

MessageBubble displays after first line, not the bottom of entire change

As you see on the image, if more than 1 lines were changed, the MessageBubble shows in the first line, so it's not possible to easy compare changes. I think MessageBubble should be shown just below the last changed line of the change, so you can easily compare old code with new one.

Failed to load the line-diff-details package

Atom: 1.21.0 x64
Electron: 1.6.9
OS: Mac OS X 10.12.6
Thrown From: line-diff-details package 1.9.0

Stack Trace

Failed to load the line-diff-details package

At ENOENT, node_modules/typescript/bin/lib.d.ts not found in /Applications/Atom.app/Contents/Resources/app.asar

Error: ENOENT, node_modules/typescript/bin/lib.d.ts not found in /Applications/Atom.app/Contents/Resources/app.asar
    at notFoundError (ELECTRON_ASAR.js:115:19)
    at Object.fs.readFileSync (ELECTRON_ASAR.js:514:9)
    at TypeScriptSimple.createService (/Applications/Atom.app/Contents/Resources/app/node_modules/typescript-simple/index.js:71:73)
    at TypeScriptSimple.compile (/Applications/Atom.app/Contents/Resources/app/node_modules/typescript-simple/index.js:60:43)
    at Object.exports.compile (/Applications/Atom.app/Contents/Resources/app/src/typescript.js:54:53)
    at Object.compile (/Applications/Atom.app/Contents/Resources/app/src/package-transpilation-registry.js:79:33)
    at compileFileAtPath (/Applications/Atom.app/Contents/Resources/app/src/compile-cache.js:97:37)
    at Object.value [as .ts] (/Applications/Atom.app/Contents/Resources/app/src/compile-cache.js:238:26)
    at Module.load (module.js:488:32)
    at tryModuleLoad (module.js:447:12)
    at Function.Module._load (module.js:439:3)
    at Module.require (/app.asar/static/index.js:47:45)
    at require (internal/module.js:20:19)
    at customRequire (/Applications/Atom.app/Contents/Resources/app/static/<embedded>:96:26)
    at Package.module.exports.Package.requireMainModule (/Applications/Atom.app/Contents/Resources/app/src/package.js:903:35)
    at /Applications/Atom.app/Contents/Resources/app/src/package.js:158:34
    at Package.module.exports.Package.measure (/Applications/Atom.app/Contents/Resources/app/src/package.js:99:21)
    at Package.module.exports.Package.load (/Applications/Atom.app/Contents/Resources/app/src/package.js:144:18)
    at PackageManager.loadAvailablePackage (/Applications/Atom.app/Contents/Resources/app/src/package-manager.js:617:16)
    at config.transact (/Applications/Atom.app/Contents/Resources/app/src/package-manager.js:530:20)
    at Config.module.exports.Config.transact (/Applications/Atom.app/Contents/Resources/app/src/config.js:342:22)
    at PackageManager.loadPackages (/Applications/Atom.app/Contents/Resources/app/src/package-manager.js:528:23)
    at /Applications/Atom.app/Contents/Resources/app/src/atom-environment.js:821:34

Commands

  8x -0:11.3.0 core:copy (atom-notification.fatal.icon.icon-bug.native-key-bindings.has-detail.has-close.has-stack)

Non-Core Packages

line-diff-details 1.9.0 

Using new block-decorations

Would be nice to use recently announced block decorations to show local diffs instead of the popup (which overlaps with the other code).

Clicking line number results in.... nothing? Atom v1.18

Atom v1.18.0 (installed on Archlinux via pacman)
line-diff-details v1.8
No other packages installed

When I hover over line number, it is highlighted, so that much is working. However, when I click on it, the highlighting disappears and no bubble appears.
Not sure how I can debug.

Shows whole file

When clicking on a changed/added line this package just shows me the whole file (the old version) again:

Okay one thing it changes: It removes every space/tab used for indenting.

I think that's not what it's intended to do...

Additionally if I click on Revertit also reverts the whole file. I also don't know whether this is intended as I thought it would probably only revert the single line...

"Uncaught TypeError: Cannot read property 'length' of undefined" when deleting lines

1. Delete a non empty line
2. try to see the diff

Atom Version: 0.187.0
System: linux 3.13.0-49-generic
Thrown From: line-diff-details package, v1.0.0

Stack Trace

Uncaught TypeError: Cannot read property 'length' of undefined

At /home/stu/.atom/packages/line-diff-details/lib/line-diff-worker.coffee:37

TypeError: Cannot read property 'length' of undefined
    at LineDiffWorker.decorateDiffMarkers (/home/stu/.atom/packages/line-diff-details/lib/line-diff-worker.coffee:65:65)
    at HTMLDivElement.<anonymous> (/home/stu/.atom/packages/line-diff-details/lib/line-diff-worker.coffee:55:24)
    at HTMLDivElement.jQuery.event.dispatch (/usr/share/atom/resources/app/node_modules/jquery/dist/jquery.js:4430:9)
    at HTMLDivElement.elemData.handle (/usr/share/atom/resources/app/node_modules/jquery/dist/jquery.js:4116:28)

Commands

Config

{
  "core": {
    "themes": [
      "one-dark-ui",
      "atom-dark-syntax"
    ]
  }
}

Installed Packages

# User
line-diff-details, v1.0.0
minimap, v4.7.6

# Dev
No dev packages

Uncaught TypeError: Cannot read property 'replace' of undefined

[Enter steps to reproduce below:]

1. click gutter highlight

Atom Version: 1.5.3
System: Microsoft Windows 7 Professional
Thrown From: line-diff-details package, v1.2.0

Stack Trace

Uncaught TypeError: Cannot read property 'replace' of undefined

At /C:/Users/jteal/.atom/packages/line-diff-details/lib/line-diff-worker.coffee:122

TypeError: Cannot read property 'replace' of undefined
    at LineDiffWorker.findFileDiffs (file:///C:/Users/jteal/.atom/packages/line-diff-details/lib/line-diff-worker.coffee:67:110)
    at LineDiffWorker.calculateDiffDetails (file:///C:/Users/jteal/.atom/packages/line-diff-details/lib/line-diff-worker.coffee:84:22)
    at HTMLDivElement.<anonymous> (file:///C:/Users/jteal/.atom/packages/line-diff-details/lib/line-diff-worker.coffee:32:24)
    at HTMLDivElement.jQuery.event.dispatch (C:\Users\jteal\AppData\Local\atom\app-1.5.3\resources\app.asar\node_modules\jquery\dist\jquery.js:4435:9)
    at HTMLDivElement.elemData.handle (C:\Users\jteal\AppData\Local\atom\app-1.5.3\resources\app.asar\node_modules\jquery\dist\jquery.js:4121:28)

Commands

Config

{
  "core": {
    "disabledPackages": [
      "metrics"
    ]
  }
}

Installed Packages

# User
language-cfml, v0.12.0
line-diff-details, v1.2.0
minimap, v4.19.0
minimap-git-diff, v4.1.8
project-manager, v2.7.6
python-tools, v0.6.7
svn, v0.0.9

# Dev
No dev packages

Uncaught TypeError: deprecationSite.getFileName is not a function

This happens when I have files that are modified in my working copy, and I try to split a pane.

Atom Version: 1.2.0
System: Ubuntu 15.10
Thrown From: line-diff-details package, v1.1.3

Stack Trace

Uncaught TypeError: deprecationSite.getFileName is not a function

At /usr/share/atom/resources/app.asar/node_modules/grim/lib/grim.js:56

TypeError: deprecationSite.getFileName is not a function
  at Object.global.__grim__.deprecate (/usr/share/atom/resources/app.asar/node_modules/grim/lib/grim.js:56:36)
  at TextEditor.module.exports.TextEditor.onDidChangeScrollTop (/usr/share/atom/resources/app.asar/src/text-editor.js:375:12)
  at LineDiffWorker.registerEditor (/home/nkovacs/.atom/packages/line-diff-details/lib/line-diff-worker.coffee:5:17)
  at /home/nkovacs/.atom/packages/line-diff-details/lib/line-diff-details.ts:8:28
  at /usr/share/atom/resources/app.asar/src/workspace.js:287:16
  at /usr/share/atom/resources/app.asar/src/workspace.js:352:18
  at Emitter.module.exports.Emitter.emit (/usr/share/atom/resources/app.asar/node_modules/event-kit/lib/emitter.js:86:11)
  at PaneContainer.module.exports.PaneContainer.addedPaneItem (/usr/share/atom/resources/app.asar/src/pane-container.js:375:27)
  at /usr/share/atom/resources/app.asar/src/pane-container.js:353:19
  at /usr/share/atom/resources/app.asar/src/pane-container.js:97:16
  at Emitter.module.exports.Emitter.emit (/usr/share/atom/resources/app.asar/node_modules/event-kit/lib/emitter.js:86:11)
  at PaneContainer.module.exports.PaneContainer.didAddPane (/usr/share/atom/resources/app.asar/src/pane-container.js:293:27)
  at Pane.module.exports.Pane.setContainer (/usr/share/atom/resources/app.asar/src/pane.js:98:26)
  at PaneAxis.module.exports.PaneAxis.addChild (/usr/share/atom/resources/app.asar/src/pane-axis.js:144:13)
  at PaneAxis.module.exports.PaneAxis.insertChildAfter (/usr/share/atom/resources/app.asar/src/pane-axis.js:216:19)
  at Pane.module.exports.Pane.split (/usr/share/atom/resources/app.asar/src/pane.js:706:23)
  at Pane.module.exports.Pane.splitRight (/usr/share/atom/resources/app.asar/src/pane.js:668:19)
  at atom-pane.commandRegistry.add.pane:split-right (/usr/share/atom/resources/app.asar/src/register-default-commands.js:194:32)
  at CommandRegistry.module.exports.CommandRegistry.handleCommandEvent (/usr/share/atom/resources/app.asar/src/command-registry.js:260:29)
  at /usr/share/atom/resources/app.asar/src/command-registry.js:3:61
  at KeymapManager.module.exports.KeymapManager.dispatchCommandEvent (/usr/share/atom/resources/app.asar/node_modules/atom-keymap/lib/keymap-manager.js:533:16)
  at KeymapManager.module.exports.KeymapManager.handleKeyboardEvent (/usr/share/atom/resources/app.asar/node_modules/atom-keymap/lib/keymap-manager.js:356:22)
  at WindowEventHandler.module.exports.WindowEventHandler.handleDocumentKeydown (/usr/share/atom/resources/app.asar/src/window-event-handler.js:99:36)
  at HTMLDocument.<anonymous> (/usr/share/atom/resources/app.asar/src/window-event-handler.js:3:61)

Commands

     -0:08.4.0 pane:split-right (atom-text-editor.editor.is-focused)
     -0:05.9.0 editor:consolidate-selections (atom-text-editor.editor.is-focused)
     -0:05.9.0 core:cancel (atom-text-editor.editor.is-focused)
     -0:02.3.0 pane:split-right (atom-text-editor.editor.is-focused)

Config

{
  "core": {
    "packagesWithKeymapsDisabled": [
      "buffer-pos"
    ],
    "disabledPackages": [
      "language-jade",
      "linter-jade"
    ]
  }
}

Installed Packages

# User
atom-jade, v0.3.0
buffer-pos, v0.3.0
editorconfig, v1.2.2
go-plus, v3.5.2
go-rename, v0.3.0
highlight-selected, v0.11.1
line-diff-details, v1.1.3
linter, v1.11.1
linter-eslint, v5.1.0
minimap, v4.16.0
minimap-find-and-replace, v4.3.2
minimap-git-diff, v4.1.8
minimap-highlight-selected, v4.3.1
minimap-selection, v4.3.1
nuclide-file-watcher, v0.0.32
nuclide-flow, v0.0.32

# Dev
No dev packages

"Uncaught TypeError: Cannot read property 'length' of undefined" when deleting lines

This seems to be a duplicate of #1, but since it has been closed, I choose to open a new issue. I could not find any workaround to this problem.

[Enter steps to reproduce below:]

1. Add a project folder that is a git repository
2. Make changes to a file
3. Attempt to see any changes.

Atom Version: 0.202.0
System: Microsoft Windows 8.1 Pro
Thrown From: line-diff-details package, v1.1.1

Stack Trace

Uncaught TypeError: Cannot read property 'length' of undefined

At C:\Users\Antoine Aubry\.atom\packages\line-diff-details\lib\line-diff-worker.coffee:44

TypeError: Cannot read property 'length' of undefined
  at LineDiffWorker.decorateDiffMarkers (C:\Users\Antoine Aubry\.atom\packages\line-diff-details\lib\line-diff-worker.coffee:44:67)
  at HTMLDivElement.<anonymous> (C:\Users\Antoine Aubry\.atom\packages\line-diff-details\lib\line-diff-worker.coffee:34:14)
  at HTMLDivElement.jQuery.event.dispatch (C:\Users\Antoine Aubry\AppData\Local\atom\app-0.202.0\resources\app.asar\node_modules\jquery\dist\jquery.js:4435:9)
  at HTMLDivElement.elemData.handle (C:\Users\Antoine Aubry\AppData\Local\atom\app-0.202.0\resources\app.asar\node_modules\jquery\dist\jquery.js:4121:28)

Commands

     -1:14.4.0 command-palette:toggle (atom-text-editor.editor.is-focused)
     -1:09.3.0 core:confirm (atom-text-editor.editor.mini.is-focused)
     -1:09.3.0 git-log:show (atom-text-editor.editor)
     -1:08.1.0 core:confirm (atom-text-editor.editor.mini.is-focused)
     -0:51.7.0 settings-view:open (ul.list-inline.tab-bar.inset-panel)
     -0:46 core:confirm (atom-text-editor.editor.mini.is-focused)

Config

{
  "core": {
    "themes": [
      "atom-dark-ui",
      "atom-dark-syntax"
    ],
    "audioBeep": false
  }
}

Installed Packages

# User
git-log, v0.4.1
language-powershell, v2.0.1
language-puppet, v0.12.0
line-diff-details, v1.1.1
remote-edit, v1.7.2

# Dev
No dev packages

Keyboard shortcuts

Thanks for a great package, this is very useful!

It would be useful to have keyboard shortcuts for this. Or to export a command for the command palette (so the user could add a key binding). One key binding to toggle the diff details on the current line and when the window is open something like Esc to close, Ctrl-c to copy and Ctrl-r to revert?

It would also be nice if the window closed when you click outside of it.

Disables navigation to preferences from the menu

After installing this plug-in it disables the ability to navigate to the preference page from the menu. the shortcut still works though (cmd,)

Uncaught TypeError: Cannot read property 'length' of undefined

I was able to reproduce the error first mentioned in #18. Removed second line of file, when clicking on line 1 to see changes popup, I get this error.
Atom 1.9.5
line-diff-details 1.3.5

Ability to select/copy from MessageBubble

Hi,

I think it may be quite nice to have an ability to copy changed code from MessageBubble.
Right now it's not even selectable.

Failed to activate the line-diff-details package

Just opening the Atom editor...

Atom Version: 1.7.3
System: Mac OS X 10.11.5
Thrown From: line-diff-details package, v1.3.4

Stack Trace

Failed to activate the line-diff-details package

At Cannot read property 'onDidChangeScrollTop' of null

TypeError: Cannot read property 'onDidChangeScrollTop' of null
    at LineDiffWorker.registerEditor (/Users/federicozivolo/.atom/packages/line-diff-details/lib/line-diff-worker.coffee:5:30)
    at /Users/federicozivolo/.atom/packages/line-diff-details/lib/line-diff-details.ts:7:28
    at Workspace.module.exports.Workspace.observeTextEditors (/Applications/Atom.app/Contents/Resources/app.asar/src/workspace.js:307:9)
    at LineDiffDetails.activate (/Users/federicozivolo/.atom/packages/line-diff-details/lib/line-diff-details.ts:5:24)
    at Package.module.exports.Package.activateNow (/Applications/Atom.app/Contents/Resources/app.asar/src/package.js:183:20)
    at /Applications/Atom.app/Contents/Resources/app.asar/src/package.js:156:32
    at Package.module.exports.Package.measure (/Applications/Atom.app/Contents/Resources/app.asar/src/package.js:92:15)
    at /Applications/Atom.app/Contents/Resources/app.asar/src/package.js:149:26
    at Package.module.exports.Package.activate (/Applications/Atom.app/Contents/Resources/app.asar/src/package.js:146:34)
    at PackageManager.module.exports.PackageManager.activatePackage (/Applications/Atom.app/Contents/Resources/app.asar/src/package-manager.js:538:21)
    at /Applications/Atom.app/Contents/Resources/app.asar/src/package-manager.js:519:29
    at Config.module.exports.Config.transactAsync (/Applications/Atom.app/Contents/Resources/app.asar/src/config.js:337:18)
    at PackageManager.module.exports.PackageManager.activatePackages (/Applications/Atom.app/Contents/Resources/app.asar/src/package-manager.js:514:19)
    at PackageManager.module.exports.PackageManager.activate (/Applications/Atom.app/Contents/Resources/app.asar/src/package-manager.js:497:46)
    at /Applications/Atom.app/Contents/Resources/app.asar/src/atom-environment.js:754:28

Commands

Config

{
  "core": {
    "disabledPackages": [
      "selection-highlight",
      "tree-view-git-modified",
      "project-dropdown",
      "recent-projects",
      "project-manager",
      "project-plus"
    ]
  }
}

Installed Packages

# User
Stylus, v3.0.0
auto-indent, v0.5.0
editorconfig, v1.4.1
highlight-selected, v0.11.2
language-stylus, v0.2.0
line-diff-details, v1.3.4
linter, v1.11.4
linter-eslint, v7.2.2
linter-jshint, v2.1.0
markdown-table-formatter, v2.8.3
open-recent, v5.0.0
project-viewer, v0.2.32
react, v0.15.0
synced-sidebar, v0.4.3

# Dev
No dev packages

Use same font?

With the current preview it's sometimes hard to see the difference. It might help to use the same font as the code. This way the code will line up with the code and it might be easier to spot differences.

Doesn't show up at all

Clicking the line number does nothing. Is it because of conflicts with other packages?

TextEditor.editorElement is deprecated.

TextEditor.prototype.editorElement has always been private, but now
it is gone. Reading the editorElement property still returns a
reference to the editor element but this field will be removed in a
later version of Atom, so we recommend using the element property instead.

TextEditor.editorElement (<embedded>:2383:20)
LineDiffWorker.registerEditor (/Users/rileyschriner/.atom/packages/line-diff-details/lib/line-diff-worker.coffee:19:48)
<unknown> (/Users/rileyschriner/.atom/packages/line-diff-details/lib/line-diff-details.ts:11:28)
Workspace.observeTextEditors (<embedded>:26080:15)
LineDiffDetails.activate (/Users/rileyschriner/.atom/packages/line-diff-details/lib/line-diff-details.ts:9:24)
Package.activateNow (<embedded>:69225:25)

Failed to load the line-diff-details package -- Error: Cannot find module 'jquery'

Steps To Reproduce

1. start atom

Atom: 1.14.4 x64
Electron: 1.3.13
OS: Ubuntu 16.04.2
Thrown From: line-diff-details package 1.5.0

Stack Trace

Failed to load the line-diff-details package

At Cannot find module 'jquery'

Error: Cannot find module 'jquery'
    at Module._resolveFilename (module.js:455:15)
    at Module._resolveFilename (/opt/atom/resources/electron.asar/common/reset-search-paths.js:35:12)
    at Function.Module._resolveFilename (/app.asar/src/module-cache.js:383:52)
    at Function.Module._load (module.js:403:25)
    at Module.require (module.js:483:17)
    at require (/app.asar/src/native-compile-cache.js:50:27)
    at /packages/line-diff-details/lib/line-diff-details.ts:1:29)
    at Module._compile (/app.asar/src/native-compile-cache.js:109:30)
    at /app.asar/src/compile-cache.js:216:21)
    at Module.load (module.js:473:32)
    at tryModuleLoad (module.js:432:12)
    at Function.Module._load (module.js:424:3)
    at Module.require (module.js:483:17)
    at require (/app.asar/src/native-compile-cache.js:50:27)
    at Package.module.exports.Package.requireMainModule (/app.asar/src/package.js:796:27)
    at /app.asar/src/package.js:123:28
    at Package.module.exports.Package.measure (/app.asar/src/package.js:96:15)
    at Package.module.exports.Package.load (/app.asar/src/package.js:110:12)
    at PackageManager.module.exports.PackageManager.loadPackage (/app.asar/src/package-manager.js:468:14)
    at /app.asar/src/package-manager.js:412:19
    at Config.module.exports.Config.transact (/app.asar/src/config.js:312:16)
    at PackageManager.module.exports.PackageManager.loadPackages (/app.asar/src/package-manager.js:407:19)
    at /app.asar/src/atom-environment.js:794:28

Commands

Non-Core Packages

atom-terminal 0.8.0 
autoupdate-packages 1.3.1 
browser-plus 0.0.87 
browser-refresh 0.9.0 
build 0.67.0 
build-cargo 2.0.0 
busy 0.7.0 
cargo-test-runner 0.1.0 
docblockr 0.9.1 
firewatch-syntax 1.1.1 
git-control 0.8.2 
git-history 3.2.0 
git-log 0.4.1 
git-plus 7.3.3 
git-time-machine 1.5.6 
gruvbox-plus-syntax 1.3.1 
imdone-atom 2.1.21 
language-rust 0.4.9 
line-diff-details 1.5.0 
linter 1.11.23 
linter-rust 0.7.2 
linter-tidy 2.3.0 
merge-conflicts 1.4.4 
minimap 4.26.8 
minimap-git-diff 4.3.1 
platformio-ide-terminal 2.4.0 
project-manager 3.3.3 
racer 0.20.0 
rust-api-docs-helper 0.5.1 
theme-switcher 1.1.0 
tool-bar 1.0.1 
travis-ci-status 1.3.1 

Uncaught TypeError: Cannot read property 'length' of undefined

Atom points to #7, but this is probably a different issue with a similar error message.

I got this error after doing a commit from the command line, going back to Atom, and clicking on a diff marker in the gutter, which shouldn't have been there anymore.

Making some minor edit in the file hides the stale diff markers and everything is back to normal. So, the real bug is probably in git-diff, but an if-guard in line-diff-details probably wouldn't hurt.

Atom Version: 1.7.0-beta2
System: Ubuntu 15.10
Thrown From: line-diff-details package, v1.2.0

At /home/sami/.atom/packages/line-diff-details/lib/line-diff-worker.coffee:44

TypeError: Cannot read property 'length' of undefined
    at LineDiffWorker.decorateDiffMarkers (/home/sami/.atom/packages/line-diff-details/lib/line-diff-worker.coffee:44:67)
    at HTMLDivElement.<anonymous> (/home/sami/.atom/packages/line-diff-details/lib/line-diff-worker.coffee:34:14)
    at HTMLDivElement.jQuery.event.dispatch (/usr/share/atom-beta/resources/app.asar/node_modules/jquery/dist/jquery.js:4435:9)
    at HTMLDivElement.elemData.handle (/usr/share/atom-beta/resources/app.asar/node_modules/jquery/dist/jquery.js:4121:28)

Function.extractParams is deprecated.

Assigning custom properties to a marker when creating/copying it is
deprecated. Please, consider storing the custom properties you need in
some other object in your package, keyed by the marker's id property.

Function.extractParams (/usr/share/atom/resources/app.asar/node_modules/text-buffer/lib/marker.js:43:14)
MarkerLayer.markRange (/usr/share/atom/resources/app.asar/node_modules/text-buffer/lib/marker-layer.js:196:71)
DisplayMarkerLayer.markBufferRange (/usr/share/atom/resources/app.asar/node_modules/text-buffer/lib/display-marker-layer.js:90:62)
TextEditor.markBufferRange (/usr/share/atom/resources/app.asar/src/text-editor.js:1753:38)
LineDiffWorker.decorateDiffMarkers (/home/adonisk/.atom/packages/line-diff-details/lib/line-diff-worker.coffee:84:28)
HTMLDivElement.<anonymous> (/home/adonisk/.atom/packages/line-diff-details/lib/line-diff-worker.coffee:57:24)

If changes are too large, you can not access to copy, close or revert buttons

I have such issue when do refactoring. The window with changes becomes too big, so buttons and some text just will go out of the screen. No scroll, no shortcuts - so i can't quit this window and have to reopen the tab with the file again...

Uncaught TypeError: Cannot read property 'length' of null

1. Modify any line
2. Click on the line number to show the line-diff

Atom Version: 0.198.0
System: linux 3.16.0-37-generic
Thrown From: line-diff-details package, v1.0.0

Stack Trace

Uncaught TypeError: Cannot read property 'length' of null

At /home/subesokun/.atom/packages/line-diff-details/lib/line-diff-worker.coffee:66

TypeError: Cannot read property 'length' of null
  at LineDiffWorker.findDiffForLine (/home/subesokun/.atom/packages/line-diff-details/lib/line-diff-worker.coffee:66:9)
  at LineDiffWorker.calculateDiffDetails (/home/subesokun/.atom/packages/line-diff-details/lib/line-diff-worker.coffee:75:20)
  at HTMLDivElement.<anonymous> (/home/subesokun/.atom/packages/line-diff-details/lib/line-diff-worker.coffee:30:24)
  at HTMLDivElement.jQuery.event.dispatch (/opt/atom/resources/app.asar/node_modules/jquery/dist/jquery.js:4435:9)
  at HTMLDivElement.elemData.handle (/opt/atom/resources/app.asar/node_modules/jquery/dist/jquery.js:4121:28)

Commands

     -0:04.2.0 docblockr:parse-enter (atom-text-editor.editor.is-focused)
     -0:04.1.0 editor:newline (atom-text-editor.editor.is-focused)

Config

{
  "core": {
    "disabledPackages": [],
    "themes": [
      "one-dark-ui",
      "monokai"
    ]
  }
}

Installed Packages

# User
autocomplete-plus, v2.14.1
docblockr, v0.6.3
editorconfig, v1.0.0
file-icons, v1.5.5
line-diff-details, v1.0.0
linter, v0.12.2
linter-jshint, v0.1.4
minimap, v4.8.0
minimap-git-diff, v4.1.2
monokai, v0.14.0
project-manager, v1.15.5
project-view, v0.1.2
revert-buffer, v0.5.0

# Dev
No dev packages

Uncaught TypeError: Cannot read property 'length' of undefined

[Enter steps to reproduce below:]

1. Open a file with added lines
2. Click on line gutter to reveal diff on any change

Atom Version: 1.0.2
System: Microsoft Windows 8.1
Thrown From: line-diff-details package, v1.1.2

Stack Trace

Uncaught TypeError: Cannot read property 'length' of undefined

At C:\Users\matti_000\.atom\packages\line-diff-details\lib\line-diff-worker.coffee:44

TypeError: Cannot read property 'length' of undefined
  at LineDiffWorker.decorateDiffMarkers (C:\Users\matti_000\.atom\packages\line-diff-details\lib\line-diff-worker.coffee:44:67)
  at HTMLDivElement.<anonymous> (C:\Users\matti_000\.atom\packages\line-diff-details\lib\line-diff-worker.coffee:34:14)
  at HTMLDivElement.jQuery.event.dispatch (C:\Users\matti_000\.atom\packages\line-diff-details\node_modules\atom-space-pen-views\node_modules\space-pen\node_modules\jquery\dist\jquery.js:4435:9)
  at HTMLDivElement.elemData.handle (C:\Users\matti_000\.atom\packages\line-diff-details\node_modules\atom-space-pen-views\node_modules\space-pen\node_modules\jquery\dist\jquery.js:4121:28)

Commands

Config

{
  "core": {
    "themes": [
      "one-dark-ui",
      "base16-tomorrow-dark-theme"
    ],
    "autoHideMenuBar": true,
    "disabledPackages": [
      "git-log",
      "git-control",
      "show-origin",
      "symbols-tree-view"
    ]
  }
}

Installed Packages

# User
line-diff-details, v1.1.2

# Dev
No dev packages

osx 11.4 atom 1.57.0 shows nothing ?

osx 11.4 atom 1.57.0 shows nothing ?
is this package OR the PLUS package still compatible ?

i install it, restarted atom, but it never shows me that inline diffs

TextEditor.onDidChangeScrollTop is deprecated.

This is now a view method. Call TextEditorElement::onDidChangeScrollTop instead.

TextEditor.onDidChangeScrollTop (/Applications/Atom.app/Contents/Resources/app.asar/src/text-editor.js:429:12)
LineDiffWorker.registerEditor (/Users/mathijsvanvelde/.atom/packages/line-diff-details/lib/line-diff-worker.coffee:16:19)
<unknown> (/Users/mathijsvanvelde/.atom/packages/line-diff-details/lib/line-diff-details.ts:8:28)
Workspace.observeTextEditors (/Applications/Atom.app/Contents/Resources/app.asar/src/workspace.js:307:9)
LineDiffDetails.activate (/Users/mathijsvanvelde/.atom/packages/line-diff-details/lib/line-diff-details.ts:6:24)
Package.activateNow (/Applications/Atom.app/Contents/Resources/app.asar/src/package.js:183:20)

Failed to load the line-diff-details package

1. I just tried to install the plugin

Atom: 1.25.0 x64
Electron: 1.7.11
OS: Mac OS X 10.13.3
Thrown From: line-diff-details package 1.9.0

Stack Trace

Failed to load the line-diff-details package

At ENOENT, node_modules/typescript/bin/lib.d.ts not found in /Applications/Atom.app/Contents/Resources/app.asar

Error: ENOENT, node_modules/typescript/bin/lib.d.ts not found in /Applications/Atom.app/Contents/Resources/app.asar
    at notFoundError (ELECTRON_ASAR.js:115:19)
    at Object.fs.readFileSync (ELECTRON_ASAR.js:513:9)
    at TypeScriptSimple.createService (/Applications/Atom.app/Contents/Resources/app/node_modules/typescript-simple/index.js:71:73)
    at TypeScriptSimple.compile (/Applications/Atom.app/Contents/Resources/app/node_modules/typescript-simple/index.js:60:43)
    at Object.exports.compile (/Applications/Atom.app/Contents/Resources/app/src/typescript.js:54:53)
    at Object.compile (/Applications/Atom.app/Contents/Resources/app/src/package-transpilation-registry.js:79:33)
    at compileFileAtPath (/Applications/Atom.app/Contents/Resources/app/src/compile-cache.js:98:37)
    at Object.value [as .ts] (/Applications/Atom.app/Contents/Resources/app/src/compile-cache.js:239:26)
    at Module.load (module.js:488:32)
    at tryModuleLoad (module.js:447:12)
    at Function.Module._load (module.js:439:3)
    at Module.require (/app.asar/static/index.js:47:45)
    at require (internal/module.js:20:19)
    at customRequire (/Applications/Atom.app/Contents/Resources/app/static/<embedded>:96:26)
    at Package.requireMainModule (/Applications/Atom.app/Contents/Resources/app/src/package.js:782:33)
    at measure (/Applications/Atom.app/Contents/Resources/app/src/package.js:143:22)
    at Package.measure (/Applications/Atom.app/Contents/Resources/app/src/package.js:88:25)
    at Package.load (/Applications/Atom.app/Contents/Resources/app/src/package.js:129:16)
    at PackageManager.loadAvailablePackage (/Applications/Atom.app/Contents/Resources/app/src/package-manager.js:618:16)
    at PackageManager.loadPackage (/Applications/Atom.app/Contents/Resources/app/src/package-manager.js:551:25)
    at PackageManager.activatePackage (/Applications/Atom.app/Contents/Resources/app/src/package-manager.js:689:23)
    at /Applications/Atom.app/Contents/Resources/app/node_modules/settings-view/lib/package-manager.js:491:35
    at exit (/Applications/Atom.app/Contents/Resources/app/node_modules/settings-view/lib/package-manager.js:128:22)
    at triggerExitCallback (/Applications/Atom.app/Contents/Resources/app/src/buffered-process.js:267:15)
    at bufferStream (/Applications/Atom.app/Contents/Resources/app/src/buffered-process.js:280:15)
    at Socket.stream.on (/Applications/Atom.app/Contents/Resources/app/src/buffered-process.js:164:13)
    at emitOne (events.js:101:20)
    at Socket.emit (events.js:191:7)
    at Pipe._handle.close [as _onclose] (net.js:510:12)

Commands

     -6:09.7.0 editor:toggle-line-comments (input.hidden-input)
     -6:09.3.0 core:save (input.hidden-input)
  2x -5:45.9.0 find-and-replace:select-next (input.hidden-input)
     -5:28.8.0 editor:newline (input.hidden-input)
     -5:27.7.0 autocomplete-plus:confirm (input.hidden-input)
     -5:27.7.0 snippets:expand (atom-text-editor.editor.typescript-editor.is-focused.autocomplete-active)
     -5:25.3.0 autocomplete-plus:confirm (input.hidden-input)
     -5:24.8.0 core:save (input.hidden-input)
     -3:09.1.0 core:backspace (input.hidden-input)
     -3:07.3.0 core:confirm (input.hidden-input)
     -1:59 editor:newline (input.hidden-input)
     -1:50.8.0 fuzzy-finder:toggle-file-finder (input.hidden-input)
     -1:48.9.0 editor:consolidate-selections (input.hidden-input)
     -1:48.9.0 core:cancel (input.hidden-input)
  4x -0:54.4.0 core:backspace (input.hidden-input)
     -0:50.9.0 core:confirm (input.hidden-input)

Non-Core Packages

atom-ide-ui 0.5.3 
atom-typescript 12.3.8 
clipboard-history 0.6.6 
file-icons 2.1.18 
highlight-selected 0.13.1 
line-diff-details 1.9.0 
minimap 4.29.8 
monokai 0.24.0 
platformio-ide-terminal 2.8.1 
vertical-tabs 1.0.7 

Uncaught TypeError: Cannot read property 'repo' of null

I get the following error when trying to click on the number to get the diff.

Atom Version: 1.0.0
System: Mac OS X 10.10.3
Thrown From: line-diff-details package, v1.1.1

Stack Trace

Uncaught TypeError: Cannot read property 'repo' of null

At /Users/dbarroso/.atom/packages/line-diff-details/lib/line-diff-worker.coffee:66

TypeError: Cannot read property 'repo' of null
  at LineDiffWorker.findFileDiffs (/Users/dbarroso/.atom/packages/line-diff-details/lib/line-diff-worker.coffee:66:83)
  at LineDiffWorker.calculateDiffDetails (/Users/dbarroso/.atom/packages/line-diff-details/lib/line-diff-worker.coffee:80:22)
  at HTMLDivElement.<anonymous> (/Users/dbarroso/.atom/packages/line-diff-details/lib/line-diff-worker.coffee:32:24)
  at HTMLDivElement.jQuery.event.dispatch (/Applications/3d_Party/Atom.app/Contents/Resources/app.asar/node_modules/jquery/dist/jquery.js:4435:9)
  at HTMLDivElement.elemData.handle (/Applications/3d_Party/Atom.app/Contents/Resources/app.asar/node_modules/jquery/dist/jquery.js:4121:28)

Commands

     -4:58.2.0 core:move-up (atom-text-editor.editor.is-focused)
  3x -4:58 core:move-left (atom-text-editor.editor.is-focused)
     -4:57.2.0 editor:consolidate-selections (atom-text-editor.editor.is-focused)
     -4:56.8.0 core:move-left (atom-text-editor.editor.is-focused)
  4x -4:56.4.0 editor:add-selection-below (atom-text-editor.editor.is-focused)
     -4:55.4.0 core:move-up (atom-text-editor.editor.is-focused)
  6x -4:55 editor:add-selection-above (atom-text-editor.editor.is-focused)
     -4:53.5.0 editor:consolidate-selections (atom-text-editor.editor.is-focused)
     -4:47.7.0 core:confirm (atom-text-editor.editor.mini.is-focused)
     -4:33 editor:select-line (atom-text-editor.editor.is-focused)
     -4:32 editor:consolidate-selections (atom-text-editor.editor.is-focused)
     -4:32 core:cancel (atom-text-editor.editor.is-focused)
     -4:14.3.0 application:add-project-folder (ol.tree-view.full-menu.list-tree.has-collapsable-children.focusable-panel)
     -1:39.2.0 core:cancel (a.btn-issue.btn.btn-error)
     -1:28.7.0 git-diff:toggle-diff-list (ol.tree-view.full-menu.list-tree.has-collapsable-children.focusable-panel)
     -0:40.9.0 settings-view:open (atom-text-editor.editor.is-focused)

Config

{
  "core": {}
}

Installed Packages

# User
atom-jinja2, v0.5.0
line-diff-details, v1.1.1

# Dev
No dev packages

The popup box showing the diff does not disappear on mouse click.

I noticed that once you click on a line to show the diff a box pops up with different options (green, orange, blue) the box does not disappear when you do a mouse click outside of the box.

This is minor bug since you can make it disappear by scrolling or by clicking the green close button.
But still would be so nice if this could be fixed. I think its kind of intuitive that if the popup loses focus it should go away.

Deprecated selector in `line-diff-details/styles/line-diff-details.less`

In line-diff-details/styles/line-diff-details.less:

Starting from Atom v1.13.0, the contents of atom-text-editor elements are no longer encapsulated within a shadow DOM boundary. This means you should stop using :host and ::shadow pseudo-selectors, and prepend all your syntax selectors with syntax--. To prevent breakage with existing style sheets, Atom will automatically upgrade the following selectors:

• atom-text-editor::shadow .line-diff-added => atom-text-editor.editor .line-diff-added

• atom-text-editor::shadow .line-diff-modified => atom-text-editor.editor .line-diff-modified

• atom-text-editor::shadow .line-diff-removed => atom-text-editor.editor .line-diff-removed

• atom-text-editor::shadow .line-diff-marker => atom-text-editor.editor .line-diff-marker

Automatic translation of selectors will be removed in a few release cycles to minimize startup time. Please, make sure to upgrade the above selectors as soon as possible.

Deprecated selector in `line-diff-details\styles\line-diff-details.less`

In line-diff-details\styles\line-diff-details.less:

Starting from Atom v1.13.0, the contents of atom-text-editor elements are no longer encapsulated within a shadow DOM boundary. This means you should stop using :host and ::shadow pseudo-selectors, and prepend all your syntax selectors with syntax--. To prevent breakage with existing style sheets, Atom will automatically upgrade the following selectors:

• atom-text-editor::shadow .line-diff-added => atom-text-editor.editor .line-diff-added

• atom-text-editor::shadow .line-diff-modified => atom-text-editor.editor .line-diff-modified

• atom-text-editor::shadow .line-diff-removed => atom-text-editor.editor .line-diff-removed

• atom-text-editor::shadow .line-diff-marker => atom-text-editor.editor .line-diff-marker

Automatic translation of selectors will be removed in a few release cycles to minimize startup time. Please, make sure to upgrade the above selectors as soon as possible.

remove console.logs

there are some leftover console logs in the source. it is annoying when I try to debug something else in atom

Broken for submodules

line-diff-details hasn't been working for a long time, and I miss the functionality. :(

Atom's error popup points to #3, but since that issue and other similar issues are closed, I thought I'd open a new one. The error happens for edited, added and deleted lines.

Stack trace below:

TypeError: Cannot read property 'length' of null
    at LineDiffWorker.findDiffForLine (/home/sami/.atom/packages/line-diff-details/lib/line-diff-worker.coffee:77:9)
    at LineDiffWorker.calculateDiffDetails (/home/sami/.atom/packages/line-diff-details/lib/line-diff-worker.coffee:87:20)
    at HTMLDivElement.<anonymous> (/home/sami/.atom/packages/line-diff-details/lib/line-diff-worker.coffee:32:24)
    at HTMLDivElement.jQuery.event.dispatch (/usr/share/atom-beta/resources/app.asar/node_modules/jquery/dist/jquery.js:4435:9)
    at HTMLDivElement.elemData.handle (/usr/share/atom-beta/resources/app.asar/node_modules/jquery/dist/jquery.js:4121:28)

Atom 1.3.0-beta5, line-diff-details 1.1.3, Ubuntu 15.10.