jakmobius / easyhtml Goto Github PK

The EditorSwitcherView class is huge. This class handles the layout of the editors entirely: 2d-layout, 3d-layout, all transition animations and so on. At a minimum, the 2d and 3d layout should have been split into two different managers that would switch when needed.

And generally speaking, the original design with the 3d-layout switch has already been removed from Safari on iOS (but it is still used in the Mail application). It might be worth replacing it with a current one.

It causes subsequent opened editors to be blank, as editor dispatcher runs out of tabs to give away to the newly opened window.

downloadFolderFTP, downloadFolderSFTP, and copyFolderRecursivelyAsync methods are too complex and have a lot of code duplication Inside them. The FTPUniversalSession class is also too complex. The code for FTP and SFTP should not be mixed in the same file.

Application crashes with the following error:

EasyHTML/LanguagePreferencesMenu.swift:87: Fatal error: Unexpectedly found nil while unwrapping an Optional value

Light color themes making UINavigationViews pitch white. The header and footer text in UITableViews is unreadable in dark theme.

The big grey buttons in the primary settings menu are unresponsive.