jamarino / intervaltree Goto Github PK

Hey @jamarino, first, kudos for creating this library!

It seems that the project contains no license.
There is a MIT license link in the NuGet page that navigates to https://licenses.nuget.org/MIT, which is generic license text with placeholders.

AFAIK, no one can legally use your library until there is an explicit license that allows otherwise.
Could you please add a LICENSE file to the project?

Hi @jamarino!
Thanks again for this library, so far it does exactly what I need.
There was a minor issue I came across.
I happened to incorrectly add a reversed interval to QuickIntervalTree (from greater than to).
No validation errors occurred.
However, when attempted to run Query, I got a System.Exception saying "Excessive recursion detected".
If reverse intervals cause such behavior, wouldn't it be better to validate from and to in the Add method?
Could save the users some time looking for their bugs.

Here is the reproduction:

var tree = new QuickIntervalTree<int, string>();

tree.Add(100, 200, "abc");
tree.Add(10, 20, "def");
tree.Add(-100, -200, "uvw"); // incorrect; should be (-200, -100)
tree.Add(50, 150, "xyz");

tree.Query(-150, 150).ToArray(); // System.Exception here

System.Exception : Excessive recursion detected, aborting to prevent stack overflow. Please check thread safety.
   at Jamarino.IntervalTree.QuickIntervalTree`2.<Build>g__BuildRec|18_0(Int32 min, Int32 max, Int32 nodeIndex, Int32 recursionLevel)
   at Jamarino.IntervalTree.QuickIntervalTree`2.<Build>g__BuildRec|18_0(Int32 min, Int32 max, Int32 nodeIndex, Int32 recursionLevel)
   at Jamarino.IntervalTree.QuickIntervalTree`2.<Build>g__BuildRec|18_0(Int32 min, Int32 max, Int32 nodeIndex, Int32 recursionLevel)
.......