jameelmoses / acf-flexible-content-extended Goto Github PK

PHP 8.1 Issue

Thanks for awesome work team
When we update php to 8.1 it throw following error, Can you please fix this on next update?
"Warning: The magic method FCP\Singleton::__wakeup() must have public visibility"

Version information

• Plugin version: 2.0.0
• ACF version: 6.0..5
• PHP: 8.0
• WordPress: 6.1.1

Steps to reproduce

Try editing a layout on any page

Expected result

The modal pops up and lets you edit it

Actual result

When a layout is edited the modal pops up but cannot be edited because a dark grey overlay is covering it.

I can't get the custom image path to work. The default image path works fine.

• My ACF layout is named main_content_row and my image is named main-content-row.jpg (the default path works, so it's not an issue with field/image naming)
• The image lives at THEME/assets/images/acf-flexible-content-extended
• Here's my filter statement:
  • add_filter( 'acf-flexible-content-extended.images_path', 'assets/images/acf-flexible-content-extended' );
• It resorts to the default image

Version information

• Plugin version: 2.0.0
• ACF version: 6.1.6
• PHP: 8.0.22
• WordPress: 6.2

The modal option means that the TinyMCE fields contained as subfields of the layout field aren't initialised and the content cannot be edited.

Version information

• Plugin version: 2.0.0
• ACF version: 6.2.3
• PHP: 8.0
• WordPress: 6.4.1

Hey there,

I really like this plugin but unfortunately under Requirements it says "PHP 5.6+", whereas in composer.json it's ">=8.0". So I cannot install this anymore. Maybe you could update the README to erase any misunderstanding.

Best regards
Nick

Version information

• Plugin version: 2.0
• ACF version: 6.1.4
• PHP: 8.1
• WordPress: 6.2

Is it possible to add search functionality to the modal popup? When you start having quite a lot of blocks it gets takes a bit of time to actually find the one you're looking for.

Hi there

Is it possible to use only the modal for the element selection, but edit then the layout normal (aka not in the modal)?

Thanks,
Christoph

When you create a flexible layout, duplicate it (using the built-in ACF quick action) and then keep the fields intact in the copy by just renaming them, they keep their internal key. Thats means they are being mistakenly skipped as duplicates by this retrieve_flexible_keys_from_fields() check in /classes/main.php:

if ( ! empty( $keys[ $layout_field['key'] ] ) ) {

and ignored, which means the preview for any but the most recent layouts is missing.

I have fixed it by combining the parent layout key (which does change upon duplication) with the field key so the key is really unique, like this:

if ( ! empty( $field['key'] . '-' . $layout_field['key'] ] ) ) {
	continue;
}
$keys[ $field['key'] . '-' . $layout_field['key'] ] = $layout_field['name'];

Happy to provide you with an example or with a PR if you'd like.

Only .jpg extensions are supported. Could you add some other image formats?

Hello can we use this plugin but only for specific flexible field ?