Chrome Canary, Firefox Dev Edition, etc aren't shown about james

[tomitm]

Couple of options:

• Submit a fix to browser-launcher2 to identify the names differently (chrome-canary), then update James to show the different icons.
• Add an additional logic to look at the path as well. For example, Chrome Canary has Chrome SxS in it's path. Seems a bit sketchy, though, as paths are likely not guaranteed.
• Display the browsers in a list instead, showing the name + version number. Even though paths aren't guaranteed, at least version numbers are reliable.

Lemme know which approach you want to take, and I'll implement it.

[kokarn]

I'd say try to get browser-launcher2 to identify the names differently.
Should be in their best interest as well.

On Mon, Feb 1, 2016 at 4:32 AM Tomi [email protected] wrote:

Couple of options:

• Submit a fix to browser-launcher2 to identify the names differently (
  chrome-canary), then update James to show the different icons.
• Add an additional logic to look at the path as well. For example,
  Chrome Canary has Chrome SxS in it's path. Seems a bit sketchy,
  though, as paths are likely not guaranteed.
• Display the browsers in a list instead, showing the name + version
  number. Even though paths aren't guaranteed, at least version numbers are
  reliable.

Lemme know which approach you want to take, and I'll implement it.

—
Reply to this email directly or view it on GitHub
#90 (comment).

[mitchhentges]

It would be awesome if browser-launch was more reliable at showing the browsers. At the same time, I think that putting the browsers in a nice UI list would be cool, too.

[tomitm]

This is fixed with #91.

Also, browser-launcher just launches, it's actually win-detect-browsers that does the actual detection. I filed an issue, but it doesn't sound like the author is too keen on the idea, preferring to keep things simple.

So, #91 has a pretty simple check for the browser name based on the command. In that case that the check doesn't manage to figure out the difference, the UI list update does at least show the version, so you can figure it out yourself.

Hope that works out for everyone, lemme know if you have any objections on the PR.

[mitchhentges]

It's a little cheesy (SxS for detecting canary?) But it's a definite improvement.