jameshome / anduril-guide Goto Github PK

Idea: It might be helpful to display two ramps next to each other in the present ramp image, one ramp for Simple UI and one ramp for Advanced UI, cf. this rough concept (Turbo could be moved to the Advanced UI ramp only, and Toggle ramp style could be moved below the Advanced UI ramp):

This way, e.g. #16 could be addressed, with 2H from OFF leading to Ceiling in Simple UI and to Turbo in Advanced UI.

Moreover, the different ramp defaults in Simple UI and Advanced UI could be displayed in each of the two ramps, including the step count for Stepped ramp (5 and 7; presently, from Floor to Ceiling, 7 steps are displayed).

In accordance with #1, obviously also the other reference to Reset underneath Thermal config would need to be changed from 13C to 13H (cf. attached screenshot).

In Simple UI, the ON ahead of immediate Turbo (marked red in the attached screenshot) is smaller in font size than the other three ON (marked green). This might extend to more than only the ON, but that is hard to tell, and I only noticed this slight visual inconsistency for ON.

In continuation of #11 and #15, it might be helpful to add possible Inherited by Simple UI indicators to the description of 1H and 2H from LOCKOUT.

These refer to the lowest floor and (if memory is not set) to the highest floor of smooth floor vs stepped floor (which can cause confusion esp. when the default values of those two floors are the same in a light, as then 1H = 2H from LOCKOUT, but that is an individual light issue/configuration).

Generally speaking, there are three floors:

• smooth floor (Advanced UI)
• stepped/discrete floor (Advanced UI)
• Simple UI floor

and only smooth floor and stepped floor are of relevance here, no matter what Simple UI floor is set to. So, in Simple UI (in contrast to ON mode, for which there is Simple UI floor), in LOCKOUT mode for 1H and 2H, the smooth floor and stepped floor settings of Advanced UI are inherited by Simple UI.

As far as I can tell, this inheritance only goes for 1H and 2H from LOCKOUT, as e.g. 4H from LOCKOUT in Simple UI leads to Simple UI floor. I am happy to be corrected in any of this, esp. as apparently this is not entirely specified in ToyKeeper's text manual, which reads for Simple UI:

In Lockout mode with Simple UI, there are a few functions:

  - 1H: Momentary moon
  - 2H: Momentary low

and in the UI Reference Table at the end:

Lockout		Any	1C/1H	Momentary moon (lowest floor)
Lockout		Any	2C/2H	Momentary moon (highest floor, or manual mem level)

Question(s): I might be getting a little confused here, but I am wondering: What does Moon below Floor in the ramp image refer to (cf. screenshot)? Visually it looks like this Moon is representing a lower brightness level than Floor.

Moon comes up in Momentary Moon underneath LOCKOUT, cf. #11, and in 3 Set Moon style: underneath RAMP EXTRAS. All of these essentially relate to Floor, so should Moon be displayed next to Floor rather than below Floor in the ramp image, or possibly not at all?

A detail that I recently came across during use is that presently, in RAMP configuration, Stepped ramp comes first, although the standard default ramp style appears to be Smooth ramp; in addition, in the ramp image, Smooth ramp style is located on the left, and thus from left to right is usually read or looked at first. So, in RAMP configuration, I was expecting Smooth ramp at the top, but found myself in Stepped ramp instead.

This is why it might be useful and consistent to have Smooth ramp first and Stepped ramp second in RAMP configuration. This order would also correspond to the order in ToyKeeper's text manual:

Ramp Config Menu
----------------

While the light is on in a ramping mode, click 7 times (but hold the 
final click) to access the config menu for the current ramp.

Or, to access the ramp config for Simple UI, make sure the Simple UI is 
not active, then do a 10H action from Off.

For smooth ramping mode, there are three menu options:

  1. Floor.  (default = 1/150)
  2. Ceiling.  (default = 120/150)
  3. Ramp speed.  (default = 1, fastest speed)

For the stepped ramping mode, there are three menu options:

  1. Floor.  (default = 20/150)
  2. Ceiling.  (default = 120/150)
  3. Number of steps.  (default = 7)

For the Simple UI mode, there are four menu options.  The first three 
are the same as stepped ramping mode.

  1. Floor.  (default = 20/150)
  2. Ceiling.  (default = 120/150)
  3. Number of steps.  (default = 5)
  4. Turbo style.  (default = 0, no turbo)

Default values are different for each model of flashlight.  The numbers 
above are only examples.

A line could be added to the Auto Lockout description containing the relevant information that

0C = Disabled

or, as 0 is the default value (cf. lockout-mode.h at revision 653, #define DEFAULT_AUTOLOCK_TIME 0 // autolock time in minutes, 0 = disabled), this additional line for Auto Lockout could read

0C = Disabled (Default)

If limited space is of concern, in order to save a line, e.g. the description above might do without being turned and read After blink, click number of minutes to wait before entering Lockout after Off.

In continuation of #13, 3H from ON Momentary turbo for Single channel lights (Advanced UI only) looks a bit disconnected, so here is a concept to add a connection to the ramp image (green):

From Ceiling to Turbo, the added dashed line indicating momentary effect could be situated next to the already present solid line from 2C from ON, as 2C from ON can lead to turbo with continuous effect, cf. #22.

At the same time, 3H for Single channel lights (Advanced UI only) and 3H for Multi-channel lights could switch their present position.

But this way, the added dashed line on the right side of the ramp image might collide e.g. with Ramp up and Ramp down, so, alternatively, a dashed line could be added from 3H from ON running on the left side of the ramp image and connecting to the dashed line of 2H from OFF (blue):

But this alternative might become visually confusing in combination with #16 (depending on how that issue is addressed), as 2H from OFF leads to momentary Turbo in Advanced UI, whereas it leads to momentary Ceiling in Simple UI.

Either way, in both cases, 3H from ON Momentary turbo would be visually connected to Turbo in the ramp image.

A Simple UI function indicator should be added to 1H underneath LOCKOUT, as this functions also in Simple UI (cf. screenshot).

It might be useful to add some more defaults to the configuration menus, esp. to RAMP EXTRAS.

If preferred, the text next to Configuration Menus could e.g. read Defaults (on the right) vary by light, so there would be no need to indicate Default in the individual menus below, cf. screenshot:

For the RAMP EXTRAS configuration menu, I have come across the defaults for Set Memory timer, Set Moon style, and Set Turbo style, cf. also #22 (for Clear Memory, 1+C, cf. #21, a default appears to be not applicable):

• Set Memory timer: 0, cf. ramp-mode.h at revision 653
• Set Moon style: 0, cf. ramp-mode.h at revision 653
• Set Turbo style: 2, cf. ramp-mode.h at revision 653
  (notable variation in hank-cfg.h: 1, cf. hank-cfg.h at revision 653)

For the MISC configuration menu, I have not come across defaults so far, but I figure RAMP EXTRAS could be a good place to start.

This is to suggest to add an indicator for Inherited by Simple UI (color, indicator symbol shape, and positioning on the page just for illustration purposes):

According to ToyKeeper's text manual:

Other options are inherited from Advanced UI:

  - ramp style (smooth / stepped)
  - smooth ramp speed
  - ramp-after-moon style
  - memory settings
  - auto-lock settings
  - aux LED settings
  - voltage calibration
  - thermal regulation settings
  - hardware-specific "misc menu" settings

This would result in the following locations (14) for the Inherited by Simple UI indicator symbol:

• ramp style (smooth / stepped) - 3C from ON (1)
• smooth ramp speed - 3 of Smooth ramp in RAMP configuration (2)
• ramp-after-moon style - 3 in RAMP EXTRAS configuration (3)
• memory settings - 10C from ON and 1 & 2 in RAMP EXTRAS configuration (4,5,6)
• auto-lock settings - 10H from LOCKOUT (7)
• aux LED settings - 7C & 7H from OFF and 7C & 7H from LOCKOUT (8,9,10,11)
• voltage calibration - 7H from Check battery (12)
• thermal regulation settings - 7H from Check temp (13)
• hardware-specific "misc menu" settings - MISC configuration (14)

Adding such an Inherited by Simple UI indicator could be a helpful addition to the present Simple UI function indicator, and clarify at a glance the relation between Advanced UI and Simple UI (color and indicator shape just for illustration purposes):

An immediate visual connection between 3C Toggle ramp style (from ON) and the vertical ON line is missing, cf. this screenshot:

Recently, this resulted in me going down the vertical ON line in search of 3C, and it taking me a while to actually locate it. To remedy this, it might be helpful to add a corresponding horizontal line between the vertical ON line and 3C Toggle ramp style, e.g. as displayed in this illustration:

At the same time, this would also visually clarify instantly that 3C Toggle ramp style relates to ON and not to OFF.

In addition to changing from 13C to 13H, cf. #1, also a Simple UI function indicator should be added to Reset light & auto-calibrate temperature, as this functions also in Simple UI (cf. screenshot).

Fantastic to see that already Revision 653.8 is up und running, thank you! This issue is for suggesting to clearly differentiate between Aux LED for Off mode and Aux LED for Lockout mode (which can be configured separately), and to make these two configuration options more visible.

This could be achieved e.g. by adding For Off mode over the horizontal lines from 7C and 7H underneath OFF (pointing to the Aux LED details), as well as adding For Lockout mode over the dashed box containing 7C and 7H underneath LOCKOUT (encompassing the Aux LED details), cf. this illustration:

A possible alternative would be to add horizontal lines from 7C and 7H underneath LOCKOUT and add For Lockout mode over both of them, in order to correspond to the two lines from 7C and 7H underneath OFF with added For Off mode, but there seems to be no space for this.

And a further possibility would be to not only add two times For Off mode, but rather Aux LED pattern for Off mode and Aux LED color for Off mode, as it is a long way to follow from 7C and 7H underneath OFF to the Aux LED details underneath LOCKOUT, so this might be of help.

Finally, if visually helpful, also the icons for Aux LED pattern and Aux LED color could be added to the respective horizontal lines from 7C and 7H underneath OFF. Displaying these icons two times might help to clarify that there are two different Aux LED configurations, one for Off mode and one for Lockout mode.

Thank you very much for putting this out here, this is great! I figure for Reset light & auto-calibrate temperature on the bottom left it should read 13H instead of currently 13C.

For 1 in RAMP EXTRAS configuration, in order to Clear Memory ..., any value entered will be fine, not just exactly 1C. So, in accordance with 15+C from OFF for Version check, the present 1C could be changed to 1+C.

It might make sense to add a Simple UI function indicator to Check battery in Utility in order to clarify what the Simple UI function is for 3C from OFF, cf. screenshot:

(Love the diagram. Looks so much better than the defaults. Thanks for your works, James!)

2H from OFF in Advanced UI leads to momentary turbo, but in Simple UI it leads to momentary ceiling level. This appears to be somewhat tricky to visualise; here is a rough concept that adds a dashed line extension with a connection point to the Ceilingline and with a Simple UI description:

The present description for Set Turbe Style 2C in RAMP EXTRAS configuration as well as in SIMPLE UI configuration appears to be somewhat unclear. It appears to read that from ON, 2C will lead to Ceiling, which is correct, and then another 2C will lead to Turbo, which is not correct, as another 2C will lead to the previous lower brightness. It is only about one 2C from ON, which will lead to Ceiling, and if Ceiling has already been ramped up to before, this one 2C from ON will lead to Turbo.

In ToyKeeper's text manual it reads:

 - Item 4: Configure Advanced UI's turbo style:
              0: No turbo, only ceiling.
              1: Anduril 1 style.  Ramp -> 2C goes to full power.
              2: Anduril 2 style.  Ramp -> 2C goes to ceiling,
                 or goes to full power if user ramped up to ceiling first.
              This value also affects momentary turbo in Ramp and Off modes.

So, to keep this short, the text description might read Ceiling or Turbo (if at Ceiling).

Also, the second option, 1C, might accordingly simply read Turbo, as the present immediate appears to relate to the third option, 2C, which at the present description includes not immediate Turbo.

Moreover, the first option, 0C, might read Ceiling only, no Turbo, with the set brightness level (Ceiling) coming first, for clarity and consistency.

This would result in the following three options:

Ceiling only, no Turbo
Turbo
Ceiling or Turbo (if at Ceiling)

I will open a new issue for each of the two other options, so, if necessary, these can be addressed separately.

In continuation of #22, the text description for 1C could read Turbo.

The present description for Momentary Moon from LOCKOUT (cf. screenshot) is not quite accurate, as 1H always leads to the lowest floor of the ramp styles, no matter which ramp style is currently selected.

So the description could read Lowest floor of ramp styles for 1H and Memory (if set) or highest floor of ramp styles for 2H.

Moreover, as it should be clear that floor refers to the ramp, this could also be shortened to Lowest floor for 1H and Memory (if set) or highest floor for 2H.

In continuation of #22 and #23, the text description for 0C could read Ceiling only, no Turbo.

3H from ON is a Simple UI function for Multi-channel lights (Adjust), but it is not a Simple UI function for Single channel lights (Momentary turbo). A way to address this could be to add one more 3H, but this time without the indicator for Simple UI function, with both 3H from ON being visually grouped together in the present dashed box, cf. this illustration:

In the context of #11, as 2H underneath LOCKOUT leads to Memory (if set) or Floor, it arguably would make sense to add a connection point to the dashed line from 2H when it crosses the line to Memory, in addition to the already present connection point to the line to Floor at the end of the dashed line.

These two "line stops" from 2H would actually be an elegant way to visualise that the "first stop" is Memory, and if not set, it goes on to the "second stop", which is Floor, cf. this illustration (larger point for illustration purposes only):

It might be useful to specify 15+C for Version check on the bottom left instead of currently just 15C, as this means that counting to exactly 15 is not required, but rather any count from 15 upwards will be fine.

This might be visually tricky, since keeping the font size the same will result in a non-circle shape, whereas keeping the circle size the same will result in a smaller font size. A way to go about this could be adding the + to the present circle size as displayed in this illustration: