jamesking56 / jamesking.dev

My personal website

jamesking.dev's Issues

Google Analytics broken

Since moving to pug, Google analytics has stopped working.

Add `pa11y-ci` to CI test accessibility

https://github.com/pa11y/pa11y-ci

WIP: SEO

Results from an SEO test tool (http://seositecheckup.com/seo-audit/beta.jamesking56.uk) revealed these tasks:

• Add a meta description tag
• Add rel=nofollow to external links
• Add a robots.txt file
• Add a sitemap
• Add 'alt' attributes to images
• Remove inline CSS styles
• Decrease loading time (Currently 6.72 seconds - should be less than 5 seconds)
  • Minify JS
  • Minify CSS

WIP: Automated deployment

(Using CodeShip)

• master branch to deploy to Jamesking56.uk
• develop branch to deploy to beta.jamesking56.uk

Fix jQuery

jQuery is stuck at ^2 because of jquery.easing not seemingly working with jQuery ^3.

jquery.easing appears to be abandoned. Therefore, I think it would be a good idea to get rid of it and upgrade jQuery to ^3.

jQuery < 3.4 is also exhibiting some security vulnerabilities

Upgrade Node version

v12 is end of life on 30th April 2022

https://nodejs.org/en/about/releases/

Move to Netlify

Migrate the site to Netlify. Migrating offers these benefits:

1. Netlify supports automatic deployment from Git and PR deploy previews.
2. We can (eventually) remove the jamesking56.uk cPanel account
3. We can instantly test any Dependabot updates as a PR deploy preview will be generated by Netlify
4. We can store Netlify config as code
5. Netlify can handle the contact form, meaning spam prevention will also be provided (goodbye contact.php and recaptcha!)
6. Netlify allows us to inject scripts outside of the code, meaning we could inject Smartlook and other analytics without needing commits in this repo.
7. Allows me to completely delete my Codeship account

Todo

• Create Netlify Site and link to this repo.
• Add Netlify config to this repo.
• Convert contact form to use Netlify forms instead, removing contact.php completely.
• Move analytics scripts from code to Cloudflare (Google Tag Manager)
• Delete Codeship account
• Add custom domain jamesking56.uk to Netlify
• Update DNS for jamesking56.uk
• Delete Recaptcha site key
• Recycle Trustpilot API key

Fix '&#39;copy&#39; is assigned a value but never used.' issue in gulpfile.js

CodeFactor found an issue: 'copy' is assigned a value but never used.

It's currently on:
gulpfile.js:4

Create a `/uses` page

Create a /uses page detailing what technologies I use.

Once live, add to https://github.com/wesbos/awesome-uses

Auto generate XML sitemap

Instead of using a hard-coded sitemap. Use gulp-sitemap to generate it.

It can then be used for #64

A function should not mix return statements with and without a result.

Codacy detected an issue:

Message: A function should not mix return statements with and without a result.

Occurred on:

• Commit: 7d8ccc0
• File: js/waypoints.js
• LineNum: 212
• Code: function (i, waypoint) {

Currently on:

• Commit: c9f5f92
• File: js/waypoints.js
• LineNum: 212

Add Codementor badge.

Fix jQuery deprecations highlighted by jQuery Migrate

jQuery.fn.blur() event shorthand is deprecated
jQuery.fn.load() is deprecated
jQuery.fn.submit() event shorthand is deprecated
jQuery.fn.scroll() event shorthand is deprecated
jQuery.fn.bind() is deprecated
Number-typed values are deprecated for jQuery.fn.css( "font-size", value )
jQuery.isFunction() is deprecated
jQuery.isWindow() is deprecated
jQuery.fn.offset() requires a valid DOM element
jQuery.fn.click() event shorthand is deprecated
jQuery.fn.resize() event shorthand is deprecated

Fix js/libs/modernizr.min.js

js/libs/modernizr.min.js is no longer minified and should be ignored by Prettier.

1. Redownload the Modernizr file in its minified form
2. Add rule to Prettier config to ignore the file

Dependency Dashboard

This issue lists Renovate updates and detected dependencies. Read the Dependency Dashboard docs to learn more.

Ignored or Blocked

These are blocked by an existing closed PR and will not be recreated unless you click a checkbox below.

• Update dependency bootstrap to v4
• Update dependency bootstrap to v5

Detected dependencies

github-actions

.github/workflows/codeql.yml

• actions/checkout v4
• github/codeql-action v3
• github/codeql-action v3
• github/codeql-action v3

.github/workflows/percy.yml

• actions/checkout v4.1.1@b4ffde65f46336ab88eb53be808477a3936bae11
• bahmutov/npm-install v1.8.38

.github/workflows/prettier.yml

• actions/checkout v4.1.1@b4ffde65f46336ab88eb53be808477a3936bae11
• bahmutov/npm-install v1.8.38

npm

package.json

• bootstrap ^3.4.1
• easy-pie-chart ^2.1.7
• fittext.js ^1.2.0
• flexslider ^2.7.2
• font-awesome ^4.7.0
• jquery ^3.6.3
• jquery-migrate ^3.4.1
• jquery-waypoints ^2.0.3
• jquery.easing ^1.3
• patch-package ^8.0.0
• respond.js ^1.4.2
• bufferstreams 3.0.0
• clone 2.1.2
• gulp 4.0.2
• gulp-clean-css 4.3.0
• gulp-concat 2.6.1
• gulp-environments 1.0.1
• gulp-pug 5.0.0
• gulp-uglify 3.0.2
• prettier 3.2.5
• rimraf 5.0.5
• semver 7.6.0
• uglify-save-license 0.4.1

nvm

.nvmrc

---

• Check this box to trigger a request for Renovate to run again on this repository

Action Required: Fix Renovate Configuration

There is an error with this repository's Renovate configuration that needs to be fixed. As a precaution, Renovate will stop PRs until it is resolved.

Error type: Cannot find preset's package (github>Jamesking56/renovate-config)

Add captcha to contact form to stop spam emails.

Fix code scanning alert - Inclusion of functionality from an untrusted source

Tracking issue for:

• https://github.com/Jamesking56/jamesking.dev/security/code-scanning/3

A function should not mix return statements with and without a result.

Codacy detected an issue:

Message: A function should not mix return statements with and without a result.

Occurred on:

• Commit: 88bd463
• File: js/waypoints.js
• LineNum: 310
• Code: Waypoint.prototype.trigger = function (args) {

Currently on:

• Commit: c9f5f92
• File: js/waypoints.js
• LineNum: 315

Dependency deprecation warning: gulp-minify-css (npm)

On registry https://registry.npmjs.org/, the "latest" version (v1.2.4) of dependency gulp-minify-css has the following deprecation notice:

Please use gulp-clean-css

Marking the latest version of an npm package as deprecated results in the entire package being considered deprecated, so contact the package author you think this is a mistake.

Affected package file(s): package.json

If you don't care about this, you can close this issue and not be warned about gulp-minify-css's deprecation again. If you would like to completely disable all future deprecation warnings then add the following to your config:

"suppressNotifications": ["deprecationWarningIssues"]

Migrate Percy to use Percy CLI

https://docs.percy.io/docs/migrating-to-percy-cli

jamesking.dev

🎉 After a 2 year wait, I've finally managed to acquire jamesking.dev 🎉

Of course, we need some edits to this repo to get it setup and redirect jamesking56.uk to the new domain.

• Change GitHub Repo name #83
• Setup new Google Tag and add Google Analytics #81
• Add redirects for jamesking56.uk and jamesking56.co.uk #82

Implement honeypot field on contact form

https://docs.netlify.com/forms/spam-filters/#honeypot-field

Use ===/!== to compare with true/false or Numbers

Codacy detected an issue:

Message: Use ===/!== to compare with true/false or Numbers

Occurred on:

• Commit: 41e1037
• File: js/jquery.label_better.js
• LineNum: 171
• Code: if (settings.hidePlaceholderOnFocus == true) {

Currently on:

• Commit: c9f5f92
• File: js/jquery.label_better.js
• LineNum: 171