GithubHelp home page GithubHelp logo

janbar / pvr.mythtv Goto Github PK

View Code? Open in Web Editor NEW

This project forked from kodi-pvr/pvr.mythtv

33.0 33.0 19.0 61.38 MB

MythTV PVR for Kodi. See the user manual and useful links on project page:

Home Page: http://janbar.github.io/pvr.mythtv

License: GNU General Public License v2.0

CMake 0.61% C 5.27% C++ 94.12%

pvr.mythtv's People

Contributors

afedchin avatar alwinesch avatar b-pass avatar basilgello avatar enen92 avatar fernetmenta avatar fetzerch avatar hudokkow avatar jalle19 avatar janbar avatar ksooo avatar margro avatar martijnkaijser avatar mdeguzis avatar memphiz avatar metaron-uk avatar miwer avatar olafhering avatar opdenkamp avatar paxxi avatar phunkyfish avatar rbuehlma avatar rechi avatar ryangribble avatar sumpfralle avatar txtranslation avatar weblate avatar wsnipex avatar xhaggi avatar yasij avatar

Stargazers

 avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar

Watchers

 avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar

pvr.mythtv's Issues

Protocol version needs updating

Kodi version 15.1
Mythtv version: mythbackend version: master [v0.28-pre-3051-gd03d51d]

this is in my mythbackend.log:

Aug 21 18:45:46 mythtv mythbackend: mythbackend[6011]: C ProcessRequest mainserver.cpp:1549 (HandleVersion) MainServer: MainServer::HandleVersion - Client speaks protocol version 86 but we speak 87!

this is in my kodi.log

18:39:30 T:9152 ERROR: AddOnLog: MythTV PVR Client: (CPPMyth)Myth::ProtoBase::OpenConnection: failed to connect with any version

HD live TV channels buffering

Hello,

I've been using the Mythtv (backend v28) extension on OSMC for some for some time on a Raspberry Pi time and it's worked well. However ....

Over the last 6 or 8 weeks or so I've noticed that live HDTV channels have ceased to work. On the Pi, just a blank screen. SDTV channels worked fine. Video / TV recording replay also work as expected.

I've recently obtained Vero 4k and have the same problem, although in this case, the picture does display but is jerky. Audio seems fine.

Doing some googling, I increased the buffer size on the Vero but that hasn't cured the problem.

I've subsequently read that increasing the buffer size doesn't effect the myth extension as it uses a different mechanism. Do you have any idea what the problem may be?

I'm happy to provide logs etc so please let me know if you need anything to help diagnose the problem.

Audio sync problem with playing recordings

I am using Kodi Isengard version with pvr.mythtv Isengard source version from the download page, on Raspberry Pi 2

When playing a recording, if I use the forward and back arrows to skip commercials, the audio becomes unsynchronized. Lip-sync is incorrect. Stopping play and resuming fixes it, also switching from analog to digital audio and back to analog fixes it. Pausing does not help, when resuming it is still unsynchronized.

This problem also existed with the Helix version. It has got worse with isengard. With Helix it happened occasionally, but with Isengard it happens almost every time I skip.

first letter of recording filename being lowercased

Hi,

I hope I can explain this sufficiently. Please bear with me if it does not come across entirely clear the first time through.

It seems like your plugin, on Kodi 17.x at least, is converting the first letter of a recording's name to lowercase when it sends it to the Myth backend. So for example, for a recorded table entry of the following:

$ echo "select title,subtitle,basename from recorded where title = \"Arrow\" order by starttime;" | mysql -h pvr -u mythtv -p[redacted] mythconverg
title	subtitle	basename
Arrow	Legacy	Arrow: S05E01 - Legacy.mkv

When I try to play that recording on Kodi (17 on either Windows 10 or Android) the MythBE emits an error:

Feb 24 20:30:22 pvr mythbackend: mythbackend[3152]: E ProcessRequest mainserver.cpp:7944 (LocalFilePath) MainServer: ERROR: LocalFilePath unable to find local path for 'arrow: S05E01 - Legacy.mkv'.

So as you can see, the filename being sent to the BE has the first letter lowercased compared to what is in the BE database for the recording.

Admittedly one would normally never notice this for the more typical recordings in a MythBE since their names are typically all numeric digits, but in my case since I am manipulating the filenames post- recording, and updating the database accordingly, I am seeing this defect.

I don't believe I see this on Kodi 16 (on Linux) though.

Continually losing PIN code

I'm using a MythTV backend (Mythbuntu) and a linux (OpenSUSE Leaf) Kodi frontend (Isengard). The pvr.mythtv plugin keeps giving me an error message saying, "Failed to connect the API services of MythTV backend. Please check your PIN code or backend setup. The PIN code has to be configured in your backend to allow connections.
Do you want to retry?"

I have found that removing the PIN code from the pvr.mythtv addon, then re-adding it and enabling the addon will fix the problem for a while.

BTW, I am using a PIN code of "0000".

Teletext unavailable.

I'm having a difficult time understanding if this is actually supposed to work or not. Teletext is available in the stream as verified by viewing closed captions using the Myth Frontend, but Kodi states Teletext is unavailable when selecting the option while watching a channel.

Simplify project merging

@metaron-uk
@b-pass

I have to change my development branch to simplify merging with kodi-pvr project. Last times I missed some fixes and it becomes complex to keep things synchronized. So I have to replace the old branch "doityourself" by a new default branch named "devel". This one is just a fork from the master where I add one commit on HEAD to make it standalone. That's allow you to create some changes directly on a fork of the branch master and then you can make a PR to my branch devel. Also you can use the branch devel if , like me, you prefer make the addon without need of kodi sources. But each time I have to sync with pulled changes in master , because a PR has been merged, I will rebase the branch devel on master and then push it force to keep the commit "make standalone" at HEAD. You should have to do only a rebase to keep the branch clean.

br

Only sync "visible" channels

There are a few hundred channels here, but only about 20 are really interesting, so I set the others to visible=false in mythtv.
It would be nice if there where an option to sync only visible channels from mythtv, so the program guide in kodi does not get messed up with all the useless channels.

Repetitive segfaults while browsing recordings

Hi,

I am using v4.12.12 of this add-on with kodi 17.1. The problem below also occurs with v5.0.9.

Some months ago kodi started to crash while displaying mythtv recording lists (e.g. when entering a group / series folder). This effect is reproducible (happens again and again, when trying repeatedly). From time to time (e.g. half a day later) the problem disappears (even with an unchanged list of recordings).

When running kodi within gdb the following error is output during the segfault:

Thread 1 "kodi.bin" received signal SIGSEGV, Segmentation fault.
0x000055555601de20 in PVR::CPVRChannel::UniqueID() const ()

Do you have any hints how I could debug this issue?

Thank you for your time and this add-on!

Kodi 17 (Odroid C2)

I built the addon for Kodi v17 on Odroid C2, using the devel-17 branch. I cannot watch mpeg-2 sd channels in live-tv, playback is stuttering or freezes. It works when playing these files afterwards from the live-tv recordings folder (only after a reboot it seems), but not in live-tv mode. H264 channels work fine also in live-tv. This used to work in Kodi v16.1. If I disable hw acceleration for mpeg-2 it works, but cpu usage is very high and it also stutters sometimes.

Improving speed of EPG retrieval from MythTV backend

Is there any way to possibly make the MythTV PVR add-on retrieve EPG data from the backend faster? I tend to set it to only load a couple of days of EPG data but on start-up it seems to take a minute or so to load.

I see that Kodi's PVR interface seems to request this by making calls to GetEPGForChannel, specifying a channel and start/end time. However MythTV's GetProgramGuide API looks like it is capable of requesting information for multiple channels in one call.

This is really only an issue when Kodi is starting up (for some reason it never seems to store the EPG database regardless of whether I tell it to or not). If there's some way to check how many days of EPG Kodi wants, on startup the add-on could request all of the EPG data for all channels for that time period (so, basically pre-fetch it for Kodi's individual calls to GetEPGForChannel). Once Kodi has retrieved all the initial EPG data it wants (unsure how this would be determined - a period of EPG request inactivity?), just go back to the current behaviour.

It's a minor issue, just with the frequency which I have to restart Kodi (or it restarts itself), it can be quite frustrating to wait for it to finish populating the guide on start-up. I could remove some channels of course. I'd also like to have more days of EPG so loading it faster would be great.

I might try and have a look into how to do this once I get more familiar with how everything works.

There seems to be a side-effect of the slow EPG loading: Obviously, with debugging enabled (like I have now) it takes even longer (a couple of minutes perhaps?) so I've reduced the amount of data loaded to 1 day. However, on startup, Kodi restarts itself about 70% through loading the EPG data, repeatedly. I can prevent this by playing/stopping a channel every 20-25% until it finishes.

Whenever the restart happens I get a crash log showing an assertion relating to a mutex:

Thread 1 (Thread 0x60064370 (LWP 7816)):
#0 __GI_raise (sig=sig@entry=6) at ../sysdeps/unix/sysv/linux/raise.c:50
#1 0x74e46184 in __GI_abort () at abort.c:79
#2 0x74e532c8 in __assert_fail_base (fmt=0x74f4a298 "%s%s%s:%u: %s%sAssertion `%s' failed.\n%n", assertion=0x76f72ef0 "INTERNAL_SYSCALL_ERRNO (e, __err) != EDEADLK || (kind != PTHREAD_MUTEX_ERRORCHECK_NP && kind != PTHREAD_MUTEX_RECURSI
VE_NP)", assertion@entry=0x60064370 "\001", file=0x76f73130 "pthread_mutex_lock.c", file@entry=0x76f73028 <PRETTY_FUNCTION.12300> "__pthread_mutex_lock_full", line=422, line@entry=1995911472, function=function@entry=0x76f73028 <PRE
TTY_FUNCTION
.12300> "__pthread_mutex_lock_full") at assert.c:92
#3 0x74e53378 in __GI___assert_fail (assertion=0x60064370 "\001", file=0x76f73028 <PRETTY_FUNCTION.12300> "__pthread_mutex_lock_full", line=1995911472, line@entry=422, function=0x76f73028 <PRETTY_FUNCTION.12300> "__pthread_mutex
_lock_full") at assert.c:101
#4 0x76f67b6c in __pthread_mutex_lock_full (mutex=0x60064370) at pthread_mutex_lock.c:420
#5 0x009aa728 in ?? ()
Backtrace stopped: previous frame identical to this frame (corrupt stack?)
############# END STACK TRACE ###############

Of course, the above could just be Kodi not liking something else, but it doesn't happen once the EPG has finished loading so I wondered if it's timing out waiting for something and then deciding something's wrong so it needs to restart.

Stuttering 1080p MPEG-2 with MythTV addon

Using the latest builds, I have begun experiencing buffering issues when trying to watch 1080p MPEG2 LiveTV streams using the MythTV addon.

720p MPEG2 and 720p H.264 work well, likely because they require less data/bandwidth.

With this same build, switching to the NextPVR addon allows me to watch the same 1080p MPEG2 LiveTV stream with no problems, which leads me to believe the issue is with the MythTV addon.

I've determined that this issue began after the merge of ​xbmc/xbmc#12212 - which relates to VideoBuffer. My theory is that this change to VideoPlayer broke the MythTV addon, and the MythTV addon is no longer supplying data fast enough to fill the buffer.

Attached are some debug logs which may help.

kodi0218-mythtv-snip.log - excerpt of MythTV addon tuning to 1080p MPEG2 channel (NOT WORKING) - running Milhouse test build ​#0218

kodi0218-nextpvr-snip.log - excerpt of NextPVR addon tuning to 1080p MPEG2 channel (WORKING) - running Milhouse test build ​#0218

kodi0709-mythtv-snip.log - excerpt of MythTV addon tuning to 1080p MPEG2 channel (WORKING) - running Milhouse test build ​#0709 - last build before the VideoPlayer/VideoBuffer merge

kodi0710-mythtv-snip.log - excerpt of MythTV addon tuning to 1080p MPEG2 channel (NOT WORKING) - running Milhouse test build ​#0710 - first build after the VideoPlayer/VideoBuffer merge

Mark as watched doesn't work

I am running the addon with version 1.12.10 on an RPi 2 with OpenELEC 5.0.6 and have the following problem: If I watch a recording completely then it is not marked as watched. I can however manually mark it as watched. Any idea what causes this? Marking as partially watched (IsResumable=true) works automatically

Setting automatic bookmark on stop fails

Unfortunately, I'm not sure where this began as I had been ignoring some problems hoping a new release would solve them. Today, I packaged up, and installed 4.13.2. I'm running it against Kodi release 17. I am able to manually create bookmarks, but when it attempts to automatically create one on stop, it fails. Is there other information I can gather or troubleshooting I can perform to help solve this? This is what I see in my log:
NOTICE: AddOnLog: MythTV PVR Client: SetRecordingLastPlayedPosition: Setting Bookmark failed

remote mythtv backend not seen at startup

Hi,

I have a 24/7 always on Mythtv system on a home server (that also houses my media storage for the Kodi frontends. )

I have migrated the media frontend in the bedroom to openelec and am using the packaged version of the pvr.mythtv plugin.

Whenever I startup the machine or resume from suspend, I get a message that the backend is not available" Mythtv PVR no response from backend. (although it is never shut down)

I need to then go in a disable then re-enable the PVR system for the connection to be established.

Other info
The system is connected via gigabit ethernet.
I am using DHCP to assign a dynamic IP.

Is there a setting that I need to modify or is this a potential bug

Regards

Kodi can only play from backend through ssh tunnel if tunnel is bound to 127.0.0.1

I usually set the local port for my ssh tunnels to a specific loopback interface, for example 127.1.1.1:6543 and 127.1.1.1:6544 for mythtv.
This works fine for receiving metadata from the backend, but when I try to play a recording / livetv from the backend, the addon appears to try to connect to 127.0.0.1:6543 - which it obviously cannot do:

14:37:20.490 T:13496   DEBUG: AddOnLog: MythTV PVR Client: (CPPMyth)Myth::LiveTVPlayback::SpawnLiveTV: trying recorder num (4) channum (104)
14:37:20.490 T:13496   DEBUG: AddOnLog: MythTV PVR Client: (CPPMyth)Myth::ProtoBase::SendCommand: GET_RECORDER_FROM_NUM[]:[]4
14:37:20.542 T:13496   DEBUG: AddOnLog: MythTV PVR Client: (CPPMyth)Myth::ProtoBase::RcvMessageLength: 18
14:37:20.542 T:13496   DEBUG: AddOnLog: MythTV PVR Client: (CPPMyth)Myth::ProtoMonitor::GetRecorderFromNum75: open recorder 4 (127.0.0.1:6543)
14:37:21.133 T:2912   DEBUG: AddOnLog: MythTV PVR Client: PVRClientMythTV::RunHouseKeeping
14:37:21.545 T:13496   ERROR: AddOnLog: MythTV PVR Client: (CPPMyth)__connectAddr: failed to connect (10061)

If I forward 127.0.0.1:6543 to the backend, everything works.
So it appears that the address setting in the addon configuration gets ignored/overwritten?

Problem connecting to latest release of MythTV .29

Hi, I updated my MythTV backend yesterday and since the update, I have been receiving this message in Kodi:

mythtv pvr error message

I get this error message from my Linux Kodi as well as my Android Kodi. Any suggestions on what can be done to fix it? I haven't found any new release of the PVR addon that fixes it. Thanks for your help!

Use Kodi buffer (settings) for mythtv data stream

I am using Kodi v17 together with pvr.mythtv (4.12.7+git20161219-2). In general it works really fine.

I am connected to the mythtv server (in another building) via a wifi connection.
Sadly this wifi connection gets occassionally saturated for some seconds due to backups and other transfers. During these moments video playback tends to struggle (audio stuttering, pausing for buffering). This can be expected when only a small buffer (few seconds is used).

I followed a kodi wiki article and put the following lines into my local settings file:

$ cat .kodi/userdata/advancedsettings.xml 
<advancedsettings>
  <loglevel>0</loglevel>
  <cache>
    <memorysize>1073741824</memorysize>
    <buffermode>1</buffermode>
    <readfactor>4.0</readfactor>
  </cache>
</advancedsettings>

I expected to see the memory usage of kodi rise significantly while filling the buffer during mythtv video playback. I also expected to see consistently high network traffic after starting video playback while filling the buffer. Both did not happen.

Thus it feels like the pvr.mythtv plugin does not use the above buffer (settings).
Maybe there is another way to configure the buffer used by the plugin?
Or do I misunderstand something?

(Feature Request) Recording groups

On mythfrontend, each recording group can have a password, and you can only see the recordings in a group if you know the password. In kodi+pvr.mythtv, everything shows up in the list of recordings with no regard to which recording group it's in. IMO, what should happen is that a list of recording groups should be displayed under Settings/PVR with a switch to turn each on and off, and turning it on should request (and remember) the password; only recordings in enabled groups should be visible to the user. (Possibly the "Default" group shouldn't get a switch/should always be visible)

Kodi Recordings view doesn't list anything

I can't say if this issue is with Kodi or this addon. Things were working fine while I was on the previous manually downloaded Kodi Jarvis, but a couple days ago when I switched to the newly announced Windows Store version of Kodi Jarvis, I started experiencing this problem:

If I go to TV->Recordings in Kodi, then I see a blank list:

screenshot 44

Which is strange because Kodi is clearly connected to the mythtv backend, since it indicates how much free space I have on the backend and since it lists recently recorded videos on Kodi's TV page (which I can access just fine) and since Kodi's Guide page works just fine. I'm wondering if anyone else has experience this issue upon upgrading to the Windows Store version of Kodi Jarvis?

pvr.mythtv version 4.7.2
Windows 10
kodi Build 17.0-BETA2 Git:20160920-9998310-dirty

Feature request: Edit recordings / cut list / commercial skip

Back when I was using mythfrontend, an often useful feature was the ability to edit recordings, in order to exclude excess content before or after the recorded show (like when you setup the system to record a couple of minutes before and after the planned program time, to make sure you get it all).

https://www.mythtv.org/wiki/Editing_Recordings

I often used this feature together with the commercial detection (and editing erroneous commercial skips, if any), before transcoding any recordings I wanted to keep, so I would only keep the essential content of the recording, and have the transcoder permanently cut out unneeded content.

I would very much like to see such a feature in the MythTV kodi plugin. I have no idea if this is even possible, or some limitations in Kodi prevents this. But I'd like to think, that at least some crude cutlist editing functionality should be possible.

Feature request - option to select PVR_EDL_TYPE_SCENE instead of PVR_EDL_TYPE_COMBREAK

Commercial marking and skipping is one of the most compelling features of MythTV. Its ability to accurately mark every break, however, is less than stellar, given the plethora of broadcasters and their desire to have their commercial/advert content seen.

Kodi's default behavior for commercial skips when an EDL is present is to warn, then skip. There appears to be no way to disable automatic skipping behavior. On occasion, this will skip commercials at the end of the show and brief program content without the ability to skip back. This frequently occurs with some US programming where there will be a final minute long or less program conclusion followed by teasers for the upcoming episode. Missing this is quite upsetting since you basically miss the conclusion of the program.

The MythTV default behavior is to mark the commercial breaks, but not automatically skip, permitting the viewer to use the up/down navigation keys (or whatever mapping you prefer) to skip to the next mark. If the mark goes farther than you think it should, you can just skip back. Some argue that the same could be done for Kodi's default behavior; however if the skip was at the end, you are out of luck. You also need to be holding the remote to be able to respond to the erroneous skip in a timely fashion. I personally find MythTV's opt-in behavior much more appealing since if we do nothing, we will miss no programming. I can always grab the remote and skip if I choose. If the commercial break takes you to the end of the show or if there are no more breaks, MythTV will tell you as much and not do anything so you don't miss any content.

It would seem to me that Kodi with the pvr.mythtv addon could replicate MythTV frontend behavior by using the PVR_EDL_TYPE_SCENE marker type in place of the PVR_EDL_TYPE_COMBREAK. This could even be a selection in the addon configuration. The current options for "Enable commercial skips (EDL)" are: Always, Dialog, Never. This option could be renamed "Commercial mark action (EDL)" and its options could be Skip commercial, Mark scene, Dialog, and None.

Translation Files

@janbar

Just a heads up:

repo kodi-pvr/pvr.mythtv has recently had updated translation files committed.
Do you need to pull these into your repo ?

Mike

updated MYTHTV v.28 protocol

updated my beta mythtv VM and getting an error message in my 'mythbackend.log'

Jan 1 12:32:06 mythtv mythbackend: mythbackend[1730]: C ProcessRequest mainserver.cpp:1573 (HandleVersion) MainServer: MainServer::HandleVersion - Client speaks protocol version 87 but we speak 88!
Jan 1 12:33:21 mythtv mythbackend: mythbackend[1730]: N Expire autoexpire.cpp:264 (CalcParams) AutoExpire: CalcParams(): Max required Free Space: 1.0 GB w/freq: 15 min
Jan 1 12:33:21 mythtv mythbackend: mythbackend[1730]: N Expire autoexpire.cpp:641 (SendDeleteMessages) Expiring 2077 MB for 2256 at 2015-12-31T18:00:00Z => Unknown
Jan 1 12:33:23 mythtv mythbackend: mythbackend[1730]: C ProcessRequest mainserver.cpp:1573 (HandleVersion) MainServer: MainServer::HandleVersion - Client speaks protocol version 87 but we speak 88!
Jan 1 12:33:24 mythtv mythbackend: mythbackend[1730]: N DeleteThread mainserver.cpp:2398 (DeleteRecordedFiles) DeleteRecordedFiles - recording id 13964 filename /recordings/LIVE_TV/2256_20151231180000.ts
Jan 1 12:33:24 mythtv mythbackend: mythbackend[1730]: N DeleteThread mainserver.cpp:2476 (DoDeleteInDB) DoDeleteINDB - recording id 13964 (chanid 2256 at 2015-12-31T18:00:00Z)
Jan 1 12:33:28 mythtv mythbackend: mythbackend[1730]: C CoreContext programinfo.cpp:351 (ProgramInfo) ProgramInfo(): Failed to find recorded entry for 13964.
Jan 1 12:33:29 mythtv mythbackend: mythbackend[1730]: C ProcessRequest mainserver.cpp:1573 (HandleVersion) MainServer: MainServer::HandleVersion - Client speaks protocol version 87 but we speak 88!
Jan 1 12:35:25 mythtv mythbackend: mythbackend[1730]: C CoreContext programinfo.cpp:351 (ProgramInfo) ProgramInfo(): Failed to find recorded entry for 13964.
Jan 1 12:35:30 mythtv mythbackend: mythbackend[1730]: C ProcessRequest mainserver.cpp:1573 (HandleVersion) MainServer: MainServer::HandleVersion - Client speaks protocol version 87 but we speak 88!

I'm guessing pvr.mythtv needs to be updated so that they two can speak?

thanks!

Feature Request: Add option to set Default Recording Group as root for recordings

For users that only use one Recording Group (ie "Default"), can we create an option in the Add-On to set the Default Group as the root when browsing recordings? Currently when going to recordings, there is one folder, "Default", and then we have to go through another click to view the list of recordings. If the option is selected when you hit recordings, you would directly view everything in the Default recording group without the extra step of selecting Default.

Addon does not work on odroid C2

I am not able to use this addon on odroid C2. I compiled from source, both on arch linux and ubuntu, using kodi-16.1. The kodi log only shows

ERROR: ADDON: Dll MythTV PVR Client - Client returned bad status (6) from Create and is not usable

I can run the same version of the addon (v3.4.19) on x86_64 systems with kodi-16.1 and it also works on my odroid C1+, thus my mythbackend is not the problem. Using libreElec on odroid C2, the addon from the libreElec repository works fine, thus I guess it should be doable. What could be the issue?

Disable autoexpire for recording

There is an option "Keep LiveTV recording" in the PVR client specific actions. But it would be nice to have a feature for disabling auto-expire for normal recordings. ( I say "disable autoexpire" instead of "keep recording" because these seem to be 2 separate things in mythtv context at least in the 'recorded' table, but probably the wording "keep recording" is better for use in kodi, idk)

I'm new to kodi plugins but as far as I can tell from the source this would be as simple as renaming the menu entry and removing two lines in PVRClientMythTV::CallMenuHook

if (!it->second.IsLiveTV())
  return PVR_ERROR_NO_ERROR;

because IsLiveTV() only checks if the recording is in the LiveTV recording group. And undeleteRecording() should be ignorant if it handles livetv or normal recordings as it only calls the webAPI.

Furthermore it would be great if recordings in the list or details page would reflect the recordings auto-expire status.

have a nice day and thanks for that great plugin.

EDL commercial breaks not detected for H.264 recordings

I transcode many of my MythTV recordings to H.264 using ffmpeg to save space and to deinterlace 1080i OTA programming. This has worked great for me on the MythTV frontend; and I have no issues using this process there.

I can view ATSC MPEG2 OTA recordings that have commercial breaks in them on Kodi (V17 RC2 Kryptonite) using this addon with no issues. However when I try to view a recording that has been transcoded to H.264, no commercial breaks are found even though the mythfrontend detects and honors them when playing them back. Even stranger, although I can view the H.264 video and skip forward and backward or use fast forward or rewind, I the forward or back skip (10 min default or to end of commercial break with Krypton) is completely unresponsive. Also, the addon does not seem to honor the current bookmark/starting position when viewing the program as it does with MPEG2 programs. Here is are the debug log entries for when loading the video:

13:49:44.714 T:18446744072102411152 DEBUG: ReadEditDecisionLists - Checking for edit decision list (EDL) for PVR recording: pvr://recordings/tv/active/Default/Bob's Burgers/Bob%27s%20Burgers s06e01 (2015)%20Sliding%20Bobs, TV%20(WJWDT-1), 20150927_233000, 1081_1443396600_034.pvr
13:49:44.714 T:18446744072102411152 DEBUG: ReadPvr - Reading Edl for recording: Bob's Burgers
13:49:44.726 T:18446744072102411152 DEBUG: AddOnLog: MythTV PVR Client: GetRecordingEdl: Found 0 commercial breaks for: Bob's Burgers

Additionally, when I exit viewing the H.264 program, I get an error indicating 'The PVR Backend does not support this action. Check the log for more information about this message'. Here is the error log message:

15:52:32.945 T:18446744072076446608 ERROR: PVR - SetRecordingLastPlayedPosition - addon 'MythTV (mythtv):http://192.168.10.100:6544' returned an error: the command failed

I even forced MythTV to regenerate the commercial list with no change in behavior. Any ideas?

Implement API function GetStreamTimes

Due to recent Kodi PVR changes in master branch, time shifting commands (Pause, StepBack, StepForward, etc.) are currently non-functional with Live TV. Per @ksooo, to restore this functionality "mythtv add-on must implement the PVR add-on API function GetStreamTimes".

Mythtv Protocol 90

Hi Janbar

Just so it doesn't get forgotten Mythtv master (pre0.29) is now at protocol 90 BuzCut

Mike

Problem with recording resumepoints caused by inconsistent airdate

Hi Janbar,

I hope you're doing well! The addon is still working perfectly here and it's used almost every day! Nice job you did with wsapi and cppmyth!

I've spend some time to track down a problem, but I'm unsure how to fix it, hence no PR yet. The symptom is that recording resumepoints (kodi videodatabase) are not set/shown when the recording is new (unwatched).

To reproduce:

  • play a recording, seek, stop playback --> no resumepoint is down, the recording is unwatched
  • play it again, seek, stop playback --> resumepoint is saved and playback can be resumed.

The issue is caused by an inconsistency in the airdate field, which is filled into year, handed over to kodi and here used to identify a recording (PVRRecordingsPath.cpp). When the list of recordings is initially filled, the data is taken from the wsapi and the Airdate field is correctly field (for example with 2016-01-01). When you start playing the recording, the addon receives a RECORDING_LIST_CHANGE UPDATE event where the airdate field of the ProgramInfo is set to the current date time. I've double checked with wireshark that it's not a parsing problem. This causes the recording to be transferred to Kodi with year set to -1. When you now stop the playback, Kodi sets the resumepoint for an incorrect path. When you start the playback again, and stop it, it will work because the path now doesn't contain a year anymore.

Have you seen this behaviour? Could you try to reproduce it? Would be good to know if that's some local issue with my setup. How would we fix that in the addon? As a workaround I patched out saving the year, but that's not the solution.

BTW: Has there been any progress on storing the resume points again on the backend? Or still not possible with wsapi?

Ping also @metaron-uk who added that code in 8823704.

MythTV version: 0.28.0+fixes.20160506.0b08cb4-0ubuntu0mythbuntu2

Thanks much,
Christian

Bug: Wrong recording length on playback, affects seeking.

Hi,

I just want to report a bug I found in 5.8.10 - I think it's somehow related to issue #30, which was recently fixed.

Some of my recordings shows a length during playback that is shorter than it actually is (the pos/length time shown during playback). Common for these recordings is, that I started watching them, while the recording was in progress. While the fix in #30 makes the end time update, as the recording is progressing, when the recording is done, it seems to have 'stamped' (for a lack of better word) the length as it was at the time I started watching the recording.

Example:

  • Schedule recording at 20:00
  • Start watching recording at 20:12, while the recording is in progress
  • When recording is done, and I want to rewatch the recording, it now shows a length of 12 minutes, even though the recording might be an hour long.
    Also I cannot step skip beyond the 'false' recording length. Fast forward works.

Recording Metadata availability in Kodi

I know that Myth will find metadata for recordings (typically via a job run directly after the recording completes). This is data like the TVDB ID, show name, season, episode name/number, air date, etc of the recording. I'd like to make use of this information in Kodi, but as far as I can tell, the PVR addon isn't setting it anywhere. The only information I can find is the "label" which looks like "Show Name - Episode Name".

Once a video starts playing, I'm using the Player.GetItem method that Kodi provides (http://kodi.wiki/view/JSON-RPC_API/v6#Player.GetItem). This is returning data like this:

{u'item': {u'type': u'unknown', u'id': 4, u'label': u'The Flash - The Darkness and the Light'}}

There's an ID and that label. The ID doesn't seem to correspond to the Kodi media library, so I'm not sure what it's referring to. (I tried VideoLibrary.GetMovieDetails, VideoLibrary.GetEpisodeDetails, and VideoLibrary.GetTVShowDetails using the ID, but they all returned nothing.) The label appears to be the same value that I see in the recordings list.

Would it be possible to add the additional metadata that Myth knows to the video playback metadata? One possible method would be to set the video player InfoLabel values (http://kodi.wiki/view/InfoLabels#Video_player) like TVShowTitle, Episode, etc. Or fill in more values in the data structure returned by that Player.GetItem call.

Cannot compile for Kodi 17

I know this is a little premature, but I just installed Kodi 17 on my Fedora box and I can't get MythTV to compile for it.

-- kodi-platform url: https://github.com/xbmc/kodi-platform
-- kodi-platform depends: tinyxml;p8-platform
-- No platform specific file /home/gus/git/xbmc/project/cmake/addons/depends/linux/CMakeLists.txt found
CMake Error at CMakeLists.txt:400 (message):
  pvr.mythtv: invalid or missing addon source directory at
  /home/gus/git/xbmc/project/pvr.mythtv


-- Configuring incomplete, errors occurred!
See also "/home/gus/git/pvr.mythtv/build/CMakeFiles/CMakeOutput.log".
[gus@localhost build]$ 

The CMakeOutput did not seem to have anything useful.

Playing a recording sometimes makes UI unresponsive until end of recording

Some background to my setup:
I had an issue with LibreELEC (Krypton) 8.2.5 MR where Kodi's UI would completely freeze quite often when seeking backwards/forwards with either recordings or live TV. In an attempt to resolve this or at least be able to try and aid with debugging it, I'm trying out alpha builds of LibreELEC and have built it from source on 5th November.

The original problem seems to be gone but now there is something else happening: On some occasions, starting playback of a recording shows a circle in the middle of the screen while the recording plays. This remains on screen until the recording ends, at which point I am returned to the list of recordings as expected. During the entire playback however, I am unable to use the UI at all (can't seek forward/backward or even bring up the play/stop buttons.)

So far I have only experienced this when playing back recordings through the MythTV add-on. Other videos seem to play correctly, though admittedly a majority of the things I play are TV recordings so there is the possibility that this could be a Kodi issue in general.

Hardware is: Raspberry Pi 3 (model B) connected via ethernet (network booted with TFTP/NFS)
Kodi version is: 18.0-BETA5 Git:newclock5_18.0b5-Leia
LibreELEC version is: devel-20181105114526-e019ab9 9.0
MythTV backend is: 0.28

I manually generated a core-dump on the most recent occasion this happened (it's ~500MB large) but didn't have debug logging enabled at the time. I will try and capture some more of these if useful.

make install going to the wrong place?

I'm trying to package this for SteamOS, and everything seems to go fine, and pre-tests of make install put things into two directory paths, as noted in the install file. Is there some kind of reason why Kodi won't recognize this? As a test, I've also tried giving more (up to 777) permissions to the directory and sub directories.

desktop@steamos:~/pvr.mythtv/build$ ls -la /usr/local/share/kodi/addons/pvr.mythtv/total 1200
drwxr-xr-x 3 steam steam    4096 Nov 14 20:41 .
drwxr-sr-x 3 steam steam    4096 Nov 14 17:24 ..
-rw-r--r-- 1 steam steam   22152 Nov 14 20:39 addon.xml
-rw-r--r-- 1 steam steam    4695 Nov 14 20:39 changelog.txt
-rw-r--r-- 1 steam steam   54653 Nov 14 20:39 icon.png
-rw-r--r-- 1 steam steam 1122624 Nov 14 17:23 pvr.mythtv.so
drwxr-xr-x 3 steam steam    4096 Nov 14 20:41 resources
``

End time doesn't update while watching recording in progress

As the title. While watching a recording in progress, the end time of the show doesn't update.

To duplicate:

  • Create a recording in mythtv
  • Wait until it has recorded some period of time
  • Start playback of that recording
  • Fast forward, end time will not update

Expected behaviour:

  • Similar to mythfrontend, the time display updates as the recording progresses

This is a great addon, stable and works very well, having this fixed would take away one of those annoyances.

Padding time is defaulted to 30 minutes

When I go to the main screen for "TV" in the kodi program and click guide, I will right click the show I want to record - select "Record" and it seems okay - it starts at the designated time slot however my half hour shows become and hour, and my hour shows become an hour and a half.

However I noticed after I look at the timers section under the tv, after setting the recording it states the end padding time is 30 minutes, I have to manually change it to 0 otherwise the tv show will have extra "junk" in the file when played.

I checked the settings under kodi bin app for "live tv" under system settings and their default end pad is 0 minutes - I am assuming this is a bug in the addon.

Post Processing Options

Currently using Kodi 17.4, MythTV PVR Client v4.15.3, Ubuntu v16.04.

This is a request for Mythtv "Post Processing" options located in the "Recording Template / Internal" section of the addon to be available in the "Timer Settings" section of Kodi.

Searching for programs and scrolling the EPG for new programs to record in Kodi is significantly faster than in MythWeb, so it's preferable to schedule through Kodi for that reason, but it can be impractical if you need to adjust any of the post processing options. Can they be added to the "Timer Settings" section or is it a limitation caused by Kodi?

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.