GithubHelp home page GithubHelp logo

Comments (5)

BryanDonovan avatar BryanDonovan commented on August 16, 2024

That's a good point. I'll fix that.

from cache-manager.

PuKoren avatar PuKoren commented on August 16, 2024

Thanks for your quick answer

from cache-manager.

BryanDonovan avatar BryanDonovan commented on August 16, 2024

This is available in the latest develop branch (see https://github.com/BryanDonovan/node-cache-manager/compare/develop). I want to make a few more updates before the next release, so I won't publish this to npm quite yet. Can you please give the develop branch a try and see if it fixes the issue for you?

Thanks!

from cache-manager.

BryanDonovan avatar BryanDonovan commented on August 16, 2024

This is available in 1.0.0 release.

from cache-manager.

PuKoren avatar PuKoren commented on August 16, 2024

Thanks for the fix and sorry for the delay
Unfortunately, redis returns null when data is not present, and this is considered as valid value for cache.
I made a PR there: #29 but this implies a lot of stuff and multi caching may be a pain.

Is it ok for you to consider undefined AND null should not be stored as valid cached value? So we can still store 0 and false.

Cheers

from cache-manager.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.