Comments (13)
Hi, sorry, I'm not too familiar with gridfs and what it is. Is this just an option in the driver?
If so you can do this by passing the option down to the driver through the storage adapter. You can see an example of how this is done with keyv-sqlite
. You can see how the table
and busyTimeout
options are passed through there.
from keyv.
It's different class in same driver http://mongodb.github.io/node-mongodb-native/3.1/api/GridFSBucket.html
I will implement it in my fork so you have reference implementation. It's very crucial feature for me so I am not creating PR for now as I need it very fast.
from keyv.
I have published new package here: https://www.npmjs.com/package/keyv-mongo-gridfs You can refer to it anytime. Let me know if you need any help.
from keyv.
Hi @adityapatadia thanks for your improvements, do you consider making a pull request now?
You can also clarify how to use the adapter in your readme:
// How to use this adapter
import Keyv from 'keyv'
import MongoAdapter from 'keyv-mongo-gridfs'
const store = new MongoAdapter({
url: process.env.MONGO_CONNECTION_STRING,
db: 'some-db',
})
const keyv = new Keyv(connectionString, { store })
from keyv.
I have stopped development of the same but that module was pretty stable. I am not able to create PR right now. May be after some I will do it.
I have updated the readme.
from keyv.
@adityapatadia - do you have the source code available for this as I was looking to see if we should add this in as a feature?
from keyv.
Source code is here: https://github.com/gumlet/keyv-mongo-gridfs
from keyv.
@adityapatadia - I am considering rolling this into the main driver as an option and was wondering if you would be ok with that?
from keyv.
from keyv.
I am perfectly fine as long as you acknowledge my contribution. Please feel free to take any code. — Regards, Aditya Patadia
…
On 21-Oct-2021, at 8:04 PM, Jared Wray @.***> wrote: @adityapatadia - I am considering rolling this into the main driver as an option and was wondering if you would be ok with that? — You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub, or unsubscribe. Triage notifications on the go with GitHub Mobile for iOS or Android.
Will add you in the pull request when we do this! Thanks so much
from keyv.
@adityapatadia and @thgh - this is now part of the core MongoDB and will be fully live on NPM today.
@adityapatadia - Would you like us to just list the idea as a contributor as we ended up not using any of your code but want to recognize your work on this. Just let us know!
from keyv.
from keyv.
Will do. Working on adding in contributions as a listing :-)
from keyv.
Related Issues (20)
- Keyv v5 - Features and Release Plans 🎉 HOT 18
- Question HOT 4
- Data not being stored using KeyvRedis - Issue With Typescript HOT 3
- Download failed HOT 1
- `@keyv/redis`: `useRedisSets` option does not take effect when providing `ioredis` instance HOT 1
- RedisJSON with Keyv HOT 5
- Use Redis UNLINK instead of Redis DEL HOT 2
- Check the namespace provided to Redis doesn not include ":" HOT 7
- MaxListenersExceededWarning: Possible EventEmitter memory leak detected. HOT 1
- flaky behaviour for the .has method HOT 5
- Strange compile error after upgrading @keyv/redis to 2.8.1 HOT 4
- How does the TTL work? HOT 1
- import or require webpack error. HOT 4
- sqlite adapter iterator stack overflows HOT 4
- SSL/TLS Support for Redis Connections HOT 3
- Support for later versions of MongoDB Node.js Driver HOT 3
- Get rid of json-buffer HOT 3
- ⚠️ Critical dependency: the request of a dependency is an expression HOT 1
- Namespace will be missed using KeyvMongo HOT 2
- Support for setting multiples keys HOT 1
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from keyv.