jarretmoses / blockchain-developer-bootcamp-final-project Goto Github PK

Add Jest and React Testing Library for client unit tests

Right now I am lazily storing memories as their complete strings where I should probably hash them in order to minimize storage size

Netlify or Vercel

Its possible someone is connected to the correct network but their selected account hasnt been added to the storage of the smart contract

The client app is using typescript and the .json files for the created abi's are dynamic. Explore using https://github.com/dethcrypto/TypeChain to generate typescript typings for contract abis

Hi Jarret Moses – I am Kuldeep, a mentor who is assisting with the grading. Congratulations, your Final Project passed! We'll be approving it on the course itself in a week or two, but here's your feedback in the meanwhile:

Frontend Comments:

• Frontend looks cool. Looks like a journal for sure. Really liked it. Works well too.
• Ropsten testnet
• Vercel has been used for the front-end deployment. Github pages can be used to deploy an MVP easily.

Testing comments:

• Structured properly using Describe stt. All test cases pass successfully.
• Coverage of all test cases possible for Smart Contract methods.

Contract Comments:

• Smart contract looks fine. Optimization is needed for sure like a lot of storage will be used.
• Inheritance and access control have been used. Simple design patterns but implemented alright.
• Floating pragma and Modifier used only for validation attack patterns had been addressed.
• Ownable has been used from Openzeppelin.

Overall:

• A unique idea is the key feature of the project.
• Good to have either a MetaMask ""Switch Network"" button or an easier way to users to switch or at least not render content before. I had to refresh the page after changing networks, probably build it in an event listener or some other method to do that automatically.
• The same goes for account change. It will be a good addition to the user experience.
• No issue on the front-end but good to show the user's address on top.
• The idea is good and UI is implemented superbly with good UI/UX. I will suggest you try hackathons after this and try to learn more in the blockchain field.

Hope you enjoyed the learning journey so far and can continue building on this.