jarrett / ichiban Goto Github PK

It refers to the wrong class name.

Guard doesn't support 1.9.3. Although Guard suggests Ruby 2.2.2, most of Ichiban was developed on 2.1.0, and it still works there as far as we can tell. So Ichiban should either fail or warn if running on Ruby < 2.1.0.

We don't use it anymore.

It's not currently testing all code paths. Consider using SimpleCov.

Background: To compile JavaScript, we shell out to UglifyJS2.

Issue: If the UglifyJS2 executable is not in the $PATH, compilation fails ungracefully.

Solution: Check if UglifyJS2 exists based on exit status of:

type uglifyjs >/dev/null 2>&1

Then check that the version is at least 2.4.10:

uglifyjs --version

Possible bug reported by a user.

When compilation fails with "RuntimeError: Layout does not exist," the backtrace should list the offending HTML file.

Probably should be solved along with #13.

Consider using ActiveSupport::BacktraceCleaner.

Steps to reproduce: Create an HTML file. mkdir and git mv HTML file to new directory. You should see a blue deletion message and a green compilation message. Instead, it's a blue deletion message and an error that the destination directory doesn't exist.

Should automatically reload config.rb and recompile all.

Currently, Ichiban generates a source map and provide its URL in the minified JS file. However, Ichiban does not automatically copy the original files into the compiled folder. It should. This is necessary in order for the in-browser debugger to download the files identified in the source map. As it stands, source mapping is broken unless you manually copy the original JS files into compiled/js.

AssetCompiler is built as if it will know how to compile all compilable assets, e.g. SCSS. Yet we do our EJS in a separate class. That's a mistake.

EJSCompiler is fairly complex. So it probably shouldn't be rolled into AssetCompiler. Thus, our policy should be that AssetCompiler only handles files that need no transformation. SCSS compilation would be moved to its own class.