jasontdc / com.jasontdc.webcamphoto Goto Github PK

The image saved when taking a webcam photo is cropped to 480x480px. The crop values should be customizable so that users can save photos will different aspect ratios and resolutions.

When taking a photo for a contact that already has a photo, the old photo is displayed for a moment after clicking the Save button, before being abruptly replaced by the new photo when the upload is complete. The old photo should be replaced by a loading/progress indicator during the upload.

Steps to reproduce:

1. Open a contact that already has a photo
2. Take a photo using the Photo tab, and click Save
3. Notice that the old photo is still displayed for a moment before being replaced

When saving a new photo for a contact, the contact's old photo is left on the filesystem.

Users or administrators should have the option to delete or overwrite old photos when saving a new one.

The Photo tab does not work when using an older model webcam that has a maximum resolution that is lower than 640x480. An error is displayed when the user clicks the "Take a photo" button.

The reason for this is that the dest_height and dest_width parameters are hard-coded to 640x480. These values should be user/administrator-configurable, and/or the tab should attempt to fall-back to a lower resolution when a higher one doesn't work.

See also issue #1

After taking a photo for a new contact that did not already have one, the photo that is displayed in the Summary tab is not updated to show the new photo.

Steps to reproduce:

1. Create a new contact
2. Take a photo for the contact via the Photo tab
3. Notice that the photo does not display on the Summary tab (BAD)
4. Refresh the page (the photo now shows up on the Summary page)
5. Take another photo for the same contact
6. Notice that the photo on the Summary page is updated (GOOD)

The strings in the UI messages are hard-coded and don't use the ts() function, so they can't be localized to other languages.

After saving a new photo in the Photo tab, the webcam is not properly released, and remains active until the user reloads the page or navigates to a new page.

Steps to reproduce:

1. Open the Photo tab and click Take a photo
2. Notice that the active webcam indicator in your browser is displayed (as is the hardware indicator on your webcam if it has one)
3. Click Save to save a new photo
4. Notice that the active webcam indicator is still displayed
5. Refresh the page
6. Notice that the active webcam indicator disappears