javaplus / picoprojects Goto Github PK

• "Hey your smoother than zero duty cycle!" - "your" to "you're"

• "..brighter the LED will be because you the average output voltage will be higher.", simple grammar issue

• "This code should look familiar it's pretty much" - comma, or maybe colon after "familiar"

• Your challenge is to use a for loop, but you also add a while loop. It is the same principle as the button, so should be very easy to figure out for anyone but may not hurt to say something about "scanning without stopping" just to indicate where the "while" came from

The link to "Lab 1" in the main readme gives a 404. I don't feel like fork/PR-ing just for this. Just say'n.

• Cleaning up the code us a nice touch. Maybe give that as a challenge too, since you said about making sure it still works. Though that is a lot less about Pico stuff, so probably not necessary for this lab

" how fast the servo's should be scanning, but increasing the speed" - should "but" be "by"?

• "Use another wire to connnect the servo's yellow wire to GPIO 15", yellow to orange

• this probably won't be an issue since you will be visually presenting, but for instealling the servo horns, should indicate how to put it on
  and that you don't need the screws at this step(especially confusing since they are pictured)

• Not that it really matters but just feels odd that the SG90 library code requires a new tab, despite really just being code like everything else. It saves space and is still straighforward, but just a thought

Add our models we printed for the game to the repo.

Forget which lab I realized this in, I might have even commented on it already but it might be helpful to mention that things like "GPIO 15" isn't necessarily the 15th connection point, since it is row 20(specifically thinking of Lab12 but meant to mention this in a previous lab)

"...set the duty cyle with highest value of 65535 being the max or 100% and 0 being the lowest allowed value which is 0%"
- Grammar feels a little off here. maybe something like "...set the duty cycle. The max is 65535, or 100%. 0 is the lowest,
whihc is 0%". Or along those lines anyways, it just kind of runs together as it is right now. I read it as "100% and 0 being the
lowest allowed", like 100% is the lowest as well

As usual people should be able to figure it out, but maybe mention something about the starter Thonny Screen, where you can pick language and basic setup. It seems like you don't need to change anything, so even something like: "on welcome screen, just click next", since your presentation display won't have the welcome screen.

• For me trying to think of how to fix the debouncing without the code at first felt a little harder. Looking at the code,
  it all makes sense but think there was just several little things in there. One thought would be suggesting a time to wait in between
  switching in the text. In my opinion, telling them to attempt on their own "Fix bouncing by keeping track of timing in between
  clicks. 500ms is a good time to try" just gives a little grounding point/orientation. Might have just been me though. I am tired =)

Title

in the "what to do" section for plugging in the photoresistor, no step mentions plugging a red power wire into the power rail and photoresistor. It is seen in the diagram but not in text. You mentioned to leave power wires in, but the previous lab(threading) does not have a power wire there

• I didn't realize at first that I had to click stop in prder to run again you mentioned this about saving, and said it would give you a busy warning, this did not give a warning it was easy to figure out, but just a thought

• Maybe mention saving it to the Pico still requires Thonny to run it(at least as far as I know in Lab6) but that you can open it in Thonny from the Pico, so it still saves it, just something I didn't realize right away, more about after the lab, not during

• fill the LED
• arm moves but button stops it for X time
• percentage of light
• speed up the rotation as you hit it/// rounds each time you have a successful hit?
• rainbow lights after winning or something
• digit displays to show a score or percent or something?

Add links at the bottom of each lab to go to the next to make flow easier... maybe add link at top of lab to take you back to previous lab.