GithubHelp home page GithubHelp logo

hotprices-au's People

Contributors

hcnguyen111 avatar javex avatar

Stargazers

 avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar

Watchers

 avatar  avatar

Forkers

hcnguyen111

hotprices-au's Issues

Encode search term in URL

If there's a space in the search term it breaks URLs when e.g. pasting them so the part query should be URL encoded

Missing product

Searching for Arnott caramel crowns only turns up coles but woolies has it too. Why is it missing?

Does this approach only capture prices at one (store) location?

I have noticed on the Coles page, that you can set your location for e.g. click and collect. I have also noticed that if you set your location to a different store, you get different prices for some items e.g. bananas. Not surprising because location does affect availability of things in different locations.

I couldn't see anything in the code that attempts to set headers, cookies, request params etc that might attempt to gather prices from different store/locations. Is this something you have attempted?

Make sure analysis is idempotent

When re-running analysis the code should not break things like price history if the same scraped snapshot is used (i.e. we didn't re-scrape, just re-analyse). However, at the moment I've noticed in some cases this breaks in odd ways, not sure why. For example, even though the items are all there, the prices changes page somehow filtered out all items, possibly because of the price history got cleared. I haven't reproduced it yet so I'm not sure what exactly is happening there.

Add organic products

There didn't seem to be a straightforward way so I skipped it for the initial version. Maybe a simple string match will do.

Some table headers untranslated

On mobile opening product search I see headers in the table like “Kette” instead of chain or store and also Preis and Aktionen. Those should be translated.

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.