jaw187 / mlbprobablepitchers

Get JSON object with MLB Probable Pitchers for a given day

mlbprobablepitchers

Get JSON object with MLB Probable Pitchers for a given day

Install

npm install mlbprobablepitchers

Usage

const Probables = require('mlbprobablepitchers');
const day = '2011/07/23';

Probables.get(day, (err, matchups) => {

  // do something
});

Example matchup

{
    "id": "2011/07/23/houmlb-chnmlb-1",
    "startTime": "2011-07-23T12:05:00",
    "easternTime": "2011-07-23T13:05:00",
    "timezone": "CDT",
    "teams": {
        "away": "112",
        "home": "117"
    },
    "pitchers": {
        "away": {
            "id": "434643",
            "name": "Wandy Rodriguez",
            "throws": "LHP"
        },
        "home": {
            "id": "448694",
            "name": "Randy Wells",
            "throws": "RHP"
        }
    }
}

mlbprobablepitchers's Issues

Undefined fields

Hello,
Thank you very much for this initiative.

I'm running some simple examples as it's shown in the readme file but printing the json recursively to see the inner objects and I'm getting some undefined fields.

For example:
const Probables = require('mlbprobablepitchers');
const day = '2016/05/03';
var util = require('util');
Probables.get(day, (err, matchups) => {
console.log(util.inspect(matchups, false, null));
});

The response of this contains some empty ids and some fields as "undefined".

I'm pretty new with nodejs so I don't know if there's something wrong with the code that I'm running.

Thank you in advance for any help you could provide me!

This isn't working

The tests fail, and the MLB API has clearly changed. I'd be happy to contribute a PR to make this work, but maybe this project is dead?

startTime is undefined

Currently startTime and easternTime are undefined. I'll do another PR and add tests.

Pitcher Names

Thank you for this module.

I was wondering the best way to get the names of the pitchers rather than the player id. Is there a specific reason you are getting the id instead?

This is a sample of the json I am currently getting for a single game:

 {
    id: '2016/04/06/chamlb-oakmlb-1',
    startTime: '2016-04-06T19:05:00',
    easternTime: '2016-04-06T22:05:00',
    timezone: 'PDT',
    teams: { away: '133', home: '145' },
    pitchers: { away: '607074', home: '605135' } 
}