jaypha / fixed Goto Github PK

DUB does nothing with your library because the target type is sourceLibrary, wouldn't it make more sense to change it to library ?

if you add alias toString = asString to the Fixed structure this would allow pretty printing and automating formating of the value (write, writeln, format, std.conv.to, etc.).

Any reason explaining why you don't use it ?

Now does the speed of this compare to floats or plain longs? Have you done any benchmarking?

First, the whole reason to have a fixed-point system is to avoid the vagaries of floating point. I do not want a string to parse in a fixed representation that will be incorrect. e.g.:

auto f = Fixed!2("10000000000000005.00");
writeln(f); // 10000000000000004.00

Second, it requires sscanf, under the hood. It does black magic. I'd rather not rely on black magic. Or libc if possible ;)

Third, parsing 2 integers instead of a double is way faster. Again parsing floating point is black magic, and really really hard to get right. It's why D still relies on sscanf.

I was considering using this in a project of mine. But I can't accept this limitation. I may create a PR if this might be approved. But the statement in the readme saying "Perhaps change the string -> fixed algorithm to avoid using floating point. Not sure if it is worth the effort" gives me pause.

Let me know.

@jaypha Are you going to abandon this project?

I plan to maintain it and move to:

https://github.com/dlang-community

If you got a change to reply.

Thanks.