Refactor setup.py (remove test setup, and the like) about django-analytical

[skulegirl]

Correction: Installing from pypi works fine, but installing from source fails, even before 2.3.0 release. So it's not that commit, but something else.

[jcassee]

Not sure, but the stacktrace seems to indicate the problem is with the installation of Django?

[skulegirl]

Well, I don't have sqlite3 installed, but I shouldn't need it for this app. I did actually figure out the issue, the setup.py file tries to set the env to include the tests.settings automatically, which requires sqlite3. Remove the following from the setup.py file:

-try:
 -    import django
 -    os.environ.setdefault(
 -        "DJANGO_SETTINGS_MODULE",
 -        "analytical.tests.settings"
 -    )
 -    django.setup()
 -except ImportError:
 -    print(
 -        "Could not import django. "
 -        "This is fine, unless you intend to run unit tests."
 -    )
 -

[bittner]

Thanks @skulegirl, for identifying the issue! 👍 This translates to: We need to

1. refactor setup.py reducing the logic for just packaging,
2. run tests "from outside" (and without) setup.py, e.g. using pytest,
3. optionally, move the tests out of the analytical module and make sure they're not included when the package is built to PyPI.

[bittner]

@skulegirl PR #171 removed the code you objected about, reducing the overall complexity of our setup.py.

Hence, it's very likely that your issue is now fixed. Please, let us know if this is not the case.