Comments (8)
Hi Tinnet,
Sorry for the delay. I would like to keep Python 2.6 support until Debian Wheezy is out, but I think it is absolutely required to start supporting Python 3.
The specific problem you cite luckily occurs only once in the code (templatetags/analytical.py, line 72). I think we can remove the exception logging in this particular case, because the exception should only occur if the code in django-analytical itself is buggy.
Are there any other fundamental problems that you are aware of? How far do you think we can go without dropping Python 2.6 support?
from django-analytical.
This: https://docs.djangoproject.com/en/dev/topics/python3/ suggests targeting ">=2.6.5" and the (current) django 1.6 release notes do not mention dropping 2.6 support (https://docs.djangoproject.com/en/dev/releases/1.6/).
I think keeping 2.6 around will be ok for quite a while (no need to move faster than django itself, right?), but 2.5 will be tricky/impossible. This would be fine for debian squeeze and wheezy :)
from django-analytical.
Sounds good, let's support versions 2.6.5 and up. I noticed you have been coding Python 3 stuff in your repo. Do you want to contribute these changes?
from django-analytical.
Sure, i'll get the branch updated and open a PR soon.
from django-analytical.
I took a quick look, but something about the override_settings decorator is broken with python3.2 and 3.3 (django version does not matter):
https://github.com/jcassee/django-analytical/blob/master/analytical/tests/utils.py#L86-88
File "~/devel/django-analytical/analytical/tests/utils.py", line 87, in __getattr__
return self.__dict__["default_settings"]
KeyError: 'default_settings'
The decorator itself has changed in django, maybe pulling the current version in would fix things, but i'll not be able to try before later tonight.
https://github.com/django/django/blob/master/django/test/utils.py#L188
from django-analytical.
What's the current state of django-analytical Python 3 support? @jcassee is it on your schedule?
from django-analytical.
@laike9m I have not worked on this myself. @tinnet Do you still intend to work on this?
from django-analytical.
Fixed by @amadornimbis in #52, merged as aab1cfc and release as 0.21.0.
from django-analytical.
Related Issues (20)
- Gitter Sidecar integration
- New release and follow-up tasks HOT 1
- Clickmap link in README links to spammy website HOT 2
- Support for Google Analytics 4 tags HOT 9
- Default value for SECURE_REFERRER_POLICY in Django 3.1 breaks Clicky HOT 2
- how to set enhanced eCommerce in google analytics HOT 2
- how to set identity_func HOT 3
- Ability to push custom commands to Matomo
- Respecting Consent ( Possible fix for #141 ) HOT 6
- Ability to pass FACEBOOK_PIXEL_ID directly in template tag HOT 1
- GA not tracking logged in users, GTAG user_id seems to require a different syntax now HOT 4
- support for python 3.10 HOT 1
- Rename default branch (master ➜ main) HOT 1
- Support for Posthog HOT 1
- Allow to set a custom location for google analytics js - support for proxy HOT 2
- Matomo ReDoS vulnerability (regex denial of service)
- Latest docs must build from `main` (not `master`) HOT 3
- basic mixpanel tracking HOT 4
- Setting google_analytics_gtag_identity does not work HOT 3
- Usage in Docker HOT 2
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from django-analytical.