GithubHelp home page GithubHelp logo

Comments (8)

jcassee avatar jcassee commented on September 25, 2024

Hi Tinnet,

Sorry for the delay. I would like to keep Python 2.6 support until Debian Wheezy is out, but I think it is absolutely required to start supporting Python 3.

The specific problem you cite luckily occurs only once in the code (templatetags/analytical.py, line 72). I think we can remove the exception logging in this particular case, because the exception should only occur if the code in django-analytical itself is buggy.

Are there any other fundamental problems that you are aware of? How far do you think we can go without dropping Python 2.6 support?

from django-analytical.

tinnet avatar tinnet commented on September 25, 2024

This: https://docs.djangoproject.com/en/dev/topics/python3/ suggests targeting ">=2.6.5" and the (current) django 1.6 release notes do not mention dropping 2.6 support (https://docs.djangoproject.com/en/dev/releases/1.6/).

I think keeping 2.6 around will be ok for quite a while (no need to move faster than django itself, right?), but 2.5 will be tricky/impossible. This would be fine for debian squeeze and wheezy :)

from django-analytical.

jcassee avatar jcassee commented on September 25, 2024

Sounds good, let's support versions 2.6.5 and up. I noticed you have been coding Python 3 stuff in your repo. Do you want to contribute these changes?

from django-analytical.

tinnet avatar tinnet commented on September 25, 2024

Sure, i'll get the branch updated and open a PR soon.

from django-analytical.

tinnet avatar tinnet commented on September 25, 2024

I took a quick look, but something about the override_settings decorator is broken with python3.2 and 3.3 (django version does not matter):

https://github.com/jcassee/django-analytical/blob/master/analytical/tests/utils.py#L86-88

File "~/devel/django-analytical/analytical/tests/utils.py", line 87, in __getattr__
    return self.__dict__["default_settings"]
KeyError: 'default_settings'

The decorator itself has changed in django, maybe pulling the current version in would fix things, but i'll not be able to try before later tonight.

https://github.com/django/django/blob/master/django/test/utils.py#L188

from django-analytical.

laike9m avatar laike9m commented on September 25, 2024

What's the current state of django-analytical Python 3 support? @jcassee is it on your schedule?

from django-analytical.

jcassee avatar jcassee commented on September 25, 2024

@laike9m I have not worked on this myself. @tinnet Do you still intend to work on this?

from django-analytical.

jcassee avatar jcassee commented on September 25, 2024

Fixed by @amadornimbis in #52, merged as aab1cfc and release as 0.21.0.

from django-analytical.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.