Comments (27)
Nice job @johnnyrockets
@gregmuellegger - Please fix and upload a new version on pip repository.
from django-floppyforms.
Fixed here: #193
from django-floppyforms.
+1
from django-floppyforms.
I confirm the problem on django 1.11.4
floppyforms/widgets.py in render(self, name, value, attrs, **kwargs)
get_context() got an unexpected keyword argument 'renderer'
on django==1.11.2 works fine!
from django-floppyforms.
+1
from django-floppyforms.
Btw, we don't use floppyforms anymore.
from django-floppyforms.
Has the issue been fixed?
from django-floppyforms.
+1
from django-floppyforms.
+1
from django-floppyforms.
+1
from django-floppyforms.
+1
from django-floppyforms.
+1
from django-floppyforms.
+1
from django-floppyforms.
+1
from django-floppyforms.
+1
from django-floppyforms.
Is there any chance of including the fix in a new release? Or is there any proposed official temp workaround?
I am now upgrading an older Django to 2.0. The project makes use of floppyforms to a great extent, so this would really be a requirement.
THanks
from django-floppyforms.
Please!
from django-floppyforms.
I have simillar problem on django 2.0.2 , please help somebody
from django-floppyforms.
Fix 193 from @manojrege works for me!
from django-floppyforms.
@lokkomokko try @manojrege's fix, it worked for me on django 2.0.2
from django-floppyforms.
+1
from django-floppyforms.
@manojrege Thanks man!
from django-floppyforms.
+1
from django-floppyforms.
There is a larger issue here that shows up in django >= 2.1. All but one of the of the render
methods in widgets.py need to have , renderer=None
added to their argument list. E.g.
def render(self, name, value, attrs=None, choices=()):
needs to be
def render(self, name, value, attrs=None, choices=(), renderer=None):
from django-floppyforms.
I know that this is an old issue but to circumvent the problem i monkeypatched like this:
from floppyforms import widgets
old_render = widgets.Input.render
def patched_render(self, name, value, attrs=None, **kwargs):
renderer = kwargs.pop('renderer', None)
if renderer:
from floppyforms.compat import flatten_contexts
template_name = kwargs.pop('template_name', None)
if template_name is None:
template_name = self.template_name
context = self.get_context(name, value, attrs=attrs or {}, **kwargs)
context = flatten_contexts(self.context_instance, context)
return renderer.render(template_name, context)
else:
return old_render(self, name, value, attrs, **kwargs)
widgets.Input.render = patched_render
I know this is ugly but as a quick fix it does its job.
There is a similar issues with passing extra attrs
for the widgets.
from django-floppyforms.
We use django-floppyforms in a few of our projects and would greatly appreciate a fix that works with Python 3 and Django 2.2. If you need any help updating this project I offer my assistance.
from django-floppyforms.
I believe that all of y'all's issues should be fixed with the latest release (1.8.0
).
If you hit any issues still with that release, please re-open this issue/create a new issue and we'll see what we can do
from django-floppyforms.
Related Issues (20)
- How to use bootstrap style to `datalist`?!
- gis warning when I don't want to use gis HOT 5
- VariableDoesNotExist: Failed lookup for key [help_text] in u'iban' HOT 1
- Custom radioselect required attrs Widget or rendered? HOT 1
- Endless Loop with django-debug-toolbar HOT 2
- the image_thumbnail.html example causes an error when image exist HOT 3
- Django 2.1 update causing for error, renderer() HOT 4
- Widgets not rendering extra attrs HOT 2
- Removed ORGException causes issues when using GeoDjango after 2.0 HOT 1
- Prepare 1.8.0 release
- Implement Jazzband guidelines for project django-floppyforms HOT 4
- [1.8.0 release blocker] Django templates breaking change? HOT 1
- GeoDjango widgets in admin site cannot be used as regular widgets with the Meta widgets attribute HOT 3
- Django 3 'six' incompatability HOT 2
- Is this project dead? HOT 7
- geodjango floppyform issue
- set extent of map using map_options HOT 3
- How to filter widget input datalist with user name
- Drop support for Python 3.6
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from django-floppyforms.