GithubHelp home page GithubHelp logo

Comments (27)

lzanuz avatar lzanuz commented on July 3, 2024 6

Nice job @johnnyrockets
@gregmuellegger - Please fix and upload a new version on pip repository.

from django-floppyforms.

manojrege avatar manojrege commented on July 3, 2024 3

Fixed here: #193

from django-floppyforms.

johnnyrockets avatar johnnyrockets commented on July 3, 2024 1

+1

from django-floppyforms.

lzanuz avatar lzanuz commented on July 3, 2024

I confirm the problem on django 1.11.4
floppyforms/widgets.py in render(self, name, value, attrs, **kwargs)
get_context() got an unexpected keyword argument 'renderer'
on django==1.11.2 works fine!

from django-floppyforms.

loge-gh avatar loge-gh commented on July 3, 2024

+1

from django-floppyforms.

bnisevic avatar bnisevic commented on July 3, 2024

Btw, we don't use floppyforms anymore.

from django-floppyforms.

Jasper-Koops avatar Jasper-Koops commented on July 3, 2024

Has the issue been fixed?

from django-floppyforms.

amenoni avatar amenoni commented on July 3, 2024

+1

from django-floppyforms.

eyesee1 avatar eyesee1 commented on July 3, 2024

+1

from django-floppyforms.

skar3 avatar skar3 commented on July 3, 2024

+1

from django-floppyforms.

oTree-org avatar oTree-org commented on July 3, 2024

+1

from django-floppyforms.

fronbasal avatar fronbasal commented on July 3, 2024

+1

from django-floppyforms.

brent960 avatar brent960 commented on July 3, 2024

+1

from django-floppyforms.

chrnolte avatar chrnolte commented on July 3, 2024

+1

from django-floppyforms.

intelef avatar intelef commented on July 3, 2024

+1

from django-floppyforms.

joaobarcia avatar joaobarcia commented on July 3, 2024

Is there any chance of including the fix in a new release? Or is there any proposed official temp workaround?

I am now upgrading an older Django to 2.0. The project makes use of floppyforms to a great extent, so this would really be a requirement.

THanks

from django-floppyforms.

skar3 avatar skar3 commented on July 3, 2024

Please!

from django-floppyforms.

lokkomokko avatar lokkomokko commented on July 3, 2024

I have simillar problem on django 2.0.2 , please help somebody

from django-floppyforms.

davewilliamstx avatar davewilliamstx commented on July 3, 2024

Fix 193 from @manojrege works for me!

from django-floppyforms.

alemangui avatar alemangui commented on July 3, 2024

@lokkomokko try @manojrege's fix, it worked for me on django 2.0.2

from django-floppyforms.

jojjo64 avatar jojjo64 commented on July 3, 2024

+1

from django-floppyforms.

nnamdiib avatar nnamdiib commented on July 3, 2024

@manojrege Thanks man!

from django-floppyforms.

amirasaad avatar amirasaad commented on July 3, 2024

+1

from django-floppyforms.

n6151h avatar n6151h commented on July 3, 2024

There is a larger issue here that shows up in django >= 2.1. All but one of the of the render methods in widgets.py need to have , renderer=None added to their argument list. E.g.

def render(self, name, value, attrs=None, choices=()):

needs to be

def render(self, name, value, attrs=None, choices=(), renderer=None):

from django-floppyforms.

aquilante avatar aquilante commented on July 3, 2024

I know that this is an old issue but to circumvent the problem i monkeypatched like this:

from floppyforms import widgets
old_render = widgets.Input.render

def patched_render(self, name, value, attrs=None, **kwargs):
    renderer = kwargs.pop('renderer', None)
    if renderer:
        from floppyforms.compat import flatten_contexts
        template_name = kwargs.pop('template_name', None)
        if template_name is None:
            template_name = self.template_name
        context = self.get_context(name, value, attrs=attrs or {}, **kwargs)
        context = flatten_contexts(self.context_instance, context)
        return renderer.render(template_name, context)        
    else:
        return old_render(self, name, value, attrs, **kwargs)

widgets.Input.render = patched_render

I know this is ugly but as a quick fix it does its job.

There is a similar issues with passing extra attrs for the widgets.

from django-floppyforms.

ramonakira avatar ramonakira commented on July 3, 2024

We use django-floppyforms in a few of our projects and would greatly appreciate a fix that works with Python 3 and Django 2.2. If you need any help updating this project I offer my assistance.

from django-floppyforms.

rtpg avatar rtpg commented on July 3, 2024

I believe that all of y'all's issues should be fixed with the latest release (1.8.0).

If you hit any issues still with that release, please re-open this issue/create a new issue and we'll see what we can do

from django-floppyforms.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.