GithubHelp home page GithubHelp logo

Comments (38)

andruten avatar andruten commented on July 30, 2024 4

@brianmay Could you please publish a new release? :) Thanks!

from django-revproxy.

andruten avatar andruten commented on July 30, 2024 4

Finally, version 0.11.0 has been released 🥲

I'm closing this.

from django-revproxy.

andruten avatar andruten commented on July 30, 2024 1

I think a new release could be released as some tasks from #129 have been resolved.

from django-revproxy.

brianmay avatar brianmay commented on July 30, 2024 1

Unfortunately I have no time to even look at this package. Is the CHANGELOG.rst up to date for the next release? If not it would help if somebody provided a PR to update this.

from django-revproxy.

andruten avatar andruten commented on July 30, 2024 1

Done! #162

from django-revproxy.

brianmay avatar brianmay commented on July 30, 2024 1

My 1st attempt to release failed. https://github.com/jazzband/django-revproxy/actions/runs/4267415470/jobs/7428996053

Probably something trivial wrong, no idea what.

from django-revproxy.

andruten avatar andruten commented on July 30, 2024 1

Thank you! I'm looking into this...

from django-revproxy.

brianmay avatar brianmay commented on July 30, 2024 1

output

Looks like not set to me. Similar if I click variables.

from django-revproxy.

andruten avatar andruten commented on July 30, 2024 1

Ok, thank you! Who could add that secrets? 🤔

I've joined the Jazzband organization and I've assigned to myself as a team member.

I think I can publish releases and manage issues now but my PRs still need at least one approval.

from django-revproxy.

brianmay avatar brianmay commented on July 30, 2024 1

Lets see then if you can publish this release :-)

from django-revproxy.

andruten avatar andruten commented on July 30, 2024 1

Yes! :D I've merged it and I've created a new release... Hope it works...

from django-revproxy.

andruten avatar andruten commented on July 30, 2024 1

Not yet as 0.11.0 is not available in PyPi. There is an issue in the jazzband/help repository.

from django-revproxy.

brianmay avatar brianmay commented on July 30, 2024 1

No, that is not a work around we can implement. It is just asking the user to download djang-revproxy from github instead of PyPi.

from django-revproxy.

acangiani avatar acangiani commented on July 30, 2024 1

Ok, sorry for creating noise, very much appreciate it.

from django-revproxy.

brianmay avatar brianmay commented on July 30, 2024

I think we need to fix the items in #129 first. At least as many as possible.

Unfortunately, I simply do not have time to look at this.

from django-revproxy.

smit-mehta25 avatar smit-mehta25 commented on July 30, 2024

@seocam @brianmay Any updates on this one?

from django-revproxy.

JeroenJADS avatar JeroenJADS commented on July 30, 2024

This has been fixed in #148!

from django-revproxy.

chiatt avatar chiatt commented on July 30, 2024

Hi @JeroenJADS, this fix works great, but to @my-umd's question, it's not yet released on PyPi. This is a problem because the latest django-revproxy (with the fix) can't be used as a dependency in a requirements.txt file for a project published on PyPi. Locally the github url to the master branch can be used, but PyPi will reject that for security reasons.

from django-revproxy.

matjazsu avatar matjazsu commented on July 30, 2024

Hi @JeroenJADS,

Hi @JeroenJADS, this fix works great, but to @my-umd's question, it's not yet released on PyPi. This is a problem because the latest django-revproxy (with the fix) can't be used as a dependency in a requirements.txt file for a project published on PyPi. Locally the github url to the master branch can be used, but PyPi will reject that for security reasons.

any news regarding ^^?

from django-revproxy.

medihack avatar medihack commented on July 30, 2024

I can confirm that the current master branch works correctly with Django 4.1. So a new release would be nice.

from django-revproxy.

andruten avatar andruten commented on July 30, 2024

Thank you for your time. I'll take a look. I think this is happening because of the version declared in the __init__.py file.

from django-revproxy.

andruten avatar andruten commented on July 30, 2024

#163 may fix the issue :).

from django-revproxy.

andruten avatar andruten commented on July 30, 2024

@brianmay 0.11.0 tag may be removed and recreated again using HEAD commit of master branch. Thanks in advance.

from django-revproxy.

andruten avatar andruten commented on July 30, 2024

I see it is still giving 500 error during upload process... :(

from django-revproxy.

brianmay avatar brianmay commented on July 30, 2024

I did that, but it didn't work out. Oh, crap that was my fault. Somehow I thought my git repo was up-to-date when it wasn't which led to a sequence of errors on my end.

Yes, still not working. No idea why.

from django-revproxy.

andruten avatar andruten commented on July 30, 2024

@brianmay Is the JAZZBAND_RELEASE_KEY secret filled?

from django-revproxy.

brianmay avatar brianmay commented on July 30, 2024

Not 100% sure, but it doesn't look like it to me.

from django-revproxy.

andruten avatar andruten commented on July 30, 2024

Once secret it's set you can't see it anymore. You may see it blank but it can be there.

from django-revproxy.

andruten avatar andruten commented on July 30, 2024

I'll remove 0.11.0 and 0.11.1 tags and I'll recreate again.

from django-revproxy.

brianmay avatar brianmay commented on July 30, 2024

Sounds good. Don't forget to update the CHANGELOG.rst and revproxy/__init__.py files also :-)

from django-revproxy.

andruten avatar andruten commented on July 30, 2024

Oops! On it!

from django-revproxy.

andruten avatar andruten commented on July 30, 2024

Done!

from django-revproxy.

brianmay avatar brianmay commented on July 30, 2024

Approved. I think you should be able to merge it. Once the CI is done.

from django-revproxy.

brianmay avatar brianmay commented on July 30, 2024

Doesn't look good :-(

from django-revproxy.

andruten avatar andruten commented on July 30, 2024

It didn't 🥲. I think this is related to that secret.

from django-revproxy.

andruten avatar andruten commented on July 30, 2024

I've published an issue in jazzband help repository. I'll let you know...!

from django-revproxy.

medihack avatar medihack commented on July 30, 2024

Can this be closed?

from django-revproxy.

acangiani avatar acangiani commented on July 30, 2024

@andruten or @brianmay there is a comment on how to fix the release of 0.11.0 on the Jazzband issue, can you try it out?

from django-revproxy.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.