Comments (6)
At the very least this is something where I would have wanted to put in documentation to confirm that this was indeed a thing that happens. Having to manage migrations on library upgrades, I'm often having to go in and figure out why something has changed or not.
It seems like this change happened in the 3.2 -> 4.0
move (how I figured this out: installing various Djangos, then running PYTHON_PATH=$(pwd) DJANGO_SETTINGS='tests' django-admin makemigrations --dry-run --check
to find where we started to add a bunch of stuff. You can also see the difference by checking Through2.tag.field.deconstruct()
and seeing that related_name
is filled in in 3.2, and is an untouched template in 4.0).
The related Django change is in the 4.0 release notes:
As a side-effect, running makemigrations might generate no-op AlterField operations for ManyToManyField and ForeignKey fields in some cases.
Reading through this though, in practice it sounds like something where we would notice the issue while upgrading to Django 4 on the "real" project.
I'm going to set up a tests that tests for changes to the test file migrations, so we can at least signal this sort of stuff in the release notes (even if it's redundant)
from django-taggit.
I'm just wanting to know if this is actually a problem. I have a feeling it isn't actually a problem but the migrations just need updating.
I guess one test would be to check if that backref is still working, and if it is then it's probably just a matter of updating the migrations.
from django-taggit.
I tested if the backref is still working and it is still working just fine using the old name.
I tried some_tag.blog_blogpostpagetag_items.all()
and it worked the same, so this is a non-issue.
So perhaps this is just how Django now represents this in migrations and I will update my migrations, considering this is a non-issue.
I'm happy to close this issue, or perhaps someone else will run into this.
from django-taggit.
Thanks for the report! This indeed sounds like an issue with django-taggit. Going to attempt a reproduction of this issue
from django-taggit.
I don't think there is anything you can do about it other than to update the migration.
It's a non-issue as per my last comment and it isn't Taggit, it's Django 4.2+ that does this
from django-taggit.
I'm happy to close this issue as I long moved on by just updating my initial migration.
from django-taggit.
Related Issues (20)
- Add support for initialising tags via a list on object creation HOT 1
- Add support for new async api HOT 2
- Getting this error while running tests: 'index_together' is deprecated. Use 'Meta.indexes' in 'taggit.TaggedItem' instead. HOT 5
- tag entered in Cyrillic be displayed in Latin
- Tag Ordering Inconsistent HOT 4
- Tags longer than 100 chars raise 500 error HOT 15
- Django Taggit 5.0 is not compatible with Django <4.1 HOT 4
- RTD builds are broken HOT 1
- Multiple queries when adding tags HOT 3
- Reverse query name for 'XXX' clashes
- New 5.0.0 migrations fails: Found wrong number (0) of indexes HOT 3
- DRF - Incorrectly processed Tag input string HOT 2
- Cannot query using tags__name__in HOT 1
- Ticket objects need to have a primary key value before you can access their tags HOT 1
- Add Django 5.0 Support
- Update Python Support
- Offer Tag Merging HOT 2
- [October 2024] Remove Support of Python 3.8
- Mypy Support For TaggableManager HOT 1
- Getting 'Python int too large to convert to SQLite INTEGER' when adding tags in DRF application HOT 1
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from django-taggit.