Comments (7)
I've started a branch to fix this but looks like the update breaks some test fixtures so I'll have to go through and fix those before merging.
from urlify.
@lux, do you have an update for us? Really looking forward to Laravel 9 support! Anything we can do to help?
from urlify.
@madman-81 I updated the requirement to voku/portable-ascii:^2.0
which you can see in this broken PR but a bunch of test fixtures broke and I haven't had time to figure out which ones need updating. I have half a mind to remove most of them if they're already covered in that underlying library but also haven't had time to look into that possibility.
Any help on getting those tests passing would be great since I'd love to get back to compatible with Laravel and the latest Voku dependencies 😄
from urlify.
@lux, I'm not familiar with the portable-ascii package, but from what I see in the code and the change log, they changed the way Russian characters are converted by replacing "GOST 7.79-2000(B)" with "Passport (2013), ICAO", amongst others. This also has an effect on other, similar, languages like Bulgarian. Not sure if this is expected behaviour, but since there is no 'source language' specified when strings are converted, this might indeed happen (that Russian characters are used when a Bulgarian sentence is converted).
If you look at this Bulgarian sentence "Bulgarian: Жълтата дюля беше щастлива, че пухът, който цъфна, замръзна като гьон", it was converted to "bulgarian-zltata-dyulya-bese-shhastliva-ce-puxt-koito-cfna-zamrzna-kato-gyon" with the 1.6 version, but with version 2.0 it would become "bulgarian-zieltata-diulia-bese-shhastliva-ce-puxiet-koito-ciefna-zamriezna-kato-gyon".
In a bit more detail: the "ъ" character is now converted to "ie" (used to be "l"). This matches with the GOST/Passport change:
src/voku/helper/data/ascii_by_languages.php on line 1223 in the new version (the link isn't fully working some how).
So the first question that needs to be answered is: Is it OK that the new version of voku/portable-ascii
will change the output that is generated?
from urlify.
@lux Any thoughts on this?
from urlify.
@madman-81 I think it's okay for the output to change since the best practice would be to generate the slug one time and store it somewhere instead of generating it fresh for every request. That wouldn't be great for performance reasons. So I think we're safe to update things to match the underlying voku/portable-ascii changes.
from urlify.
@lux, I've updated the expected output. See PR #71
from urlify.
Related Issues (20)
- Ó => o HOT 1
- stop after & symbol HOT 3
- preserve case feature HOT 1
- Please retain license HOT 1
- Unable to urlify properly HOT 2
- Replacing underscores with spaces HOT 1
- Wider language support for transliteration? HOT 1
- Support more characters by default HOT 1
- save file extension when $file_name = true HOT 1
- Lithuanian map :) HOT 1
- Make use of PHP's Transliterator class HOT 3
- Missing A char HOT 2
- Passing certain characters to add_chars() method causes "preg_match_all(): Unknown modifier ']'" HOT 1
- Why is $underscoreToSpace removed ? HOT 4
- how to reverse url slug HOT 1
- All word lowercase
- 1.2.4 changed transliteration behaviour HOT 2
- Difficulty generating a slug with / and , HOT 1
- Underscores as spaces HOT 1
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from urlify.