jcwangxp / crossline Goto Github PK

hi,
I found a problem, crossline_readline function do not support for chinese charactor input.
when input chinese char, example program does not display the char that input, and nothing will be shown.
on msys2 platform, the program will stuck, and can not be killed.

so I'm using this library for my own Interpreter, because I have cross-platform need so I can't use GNU Readline.
It's been all good til' I need to have filepath completion, is it possible to add this function? how?

Would you like to add more error handling for return values from functions like the following?

• printf ⇒ crossline_cursor_set
• sigaction ⇒ crossline_winchg_reg

I would like to point out that an identifier like “__CROSSLINE_H” does not fit to the expected naming convention of the C++ language standard.
Would you like to adjust your selection for unique names?

I would like to be able to use completion support with C++ however the completion callback does not have a user argument. If I could pass the this pointer of an object as user data I could integrate completion into my C++ program.

I am thinking about adding a new callback type and call to maintain backwards compatibility:

typedef void (*crossline_user_completion_callback) (void* user, const char *buf, crossline_completions_t *pCompletions);
extern void  crossline_user_completion_register (crossline_user_completion_callback pCbFunc, void* user);

If a crossline_user_completion_callback is registered it is called else the crossline_completion_callback is called if registered.

Would you be interested in a pull request for such a change?