GithubHelp home page GithubHelp logo

Comments (3)

ScottTrenda avatar ScottTrenda commented on August 14, 2024

This version of compileFn should be backwards compatible:

  function compileFn(tmpl, options) {

    options = (typeof options == 'boolean') ? { flushRequests: options } : options || {}

    return function compile(scopeParams) {
      scopeParams = scopeParams || {}
      var scope = $rootScope.$new()

      angular.extend(scope, scopeParams)

      var el = $compile(tmpl)(scope)
      scope.$digest()

      if (options.flushRequests || options.flushRequests === undefined) $httpBackend.flush()

      return angular.extend({ scope: scope }, DomHelper(el))
    }

  }

from angular-test-tool-box.

ScottTrenda avatar ScottTrenda commented on August 14, 2024

Actually, let's kill another few birds with this stone and do it this way:

function compileFn(tmpl, options) {

  options = (typeof options == 'boolean') ? { flushRequests: options } : options || {}

  return function compile(scopeParams, overrideOptions) {
    scopeParams = scopeParams || {}
    var scope = $rootScope.$new()

    angular.extend(scope, scopeParams)
    var callOptions = angular.extend({}, options, overrideOptions)

    var cloneAttachFn
    if (callOptions.attach) cloneAttachFn = function(clone) { angular.element('body').append(clone) }

    var el = $compile(tmpl)(scope, cloneAttachFn)
    scope.$digest()

    if (callOptions.flushRequests || callOptions.flushRequests === undefined) $httpBackend.flush()

    return angular.extend({ scope: scope }, DomHelper(el))
  }

}

Allowing options to be passed on the compile() call will solve the annoying case where we want the requests to be flushed on compile for every test except one in a suite. We'll be able to pass { flushRequests: false } for only that call.

The attach option is there because we might as well, while we're updating this. I'd love to also automate detaching the element at the end of the current test run if attach is passed, but I don't know if or how we can add an afterEach from within an it block. The tests using { attach: true } will have to manually detach their own element afterward, until we can figure that out.

from angular-test-tool-box.

ScottTrenda avatar ScottTrenda commented on August 14, 2024

Addressed in #9

from angular-test-tool-box.

Related Issues (5)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.