jdalt / angular-test-tool-box Goto Github PK

Most of the time we grab dom.text() we want the text to reflect what the user sees in the browser. If dom.text() can normalize text (while being overriden to get raw text) it will make testing easier and consistent.

This will be a breaking change and require a major version bump.

In the backported param serializer, isDate and toJson are used in serializeValue, but they are not defined anywhere in the code. Either add these params to avoid errors in this provider, or remove the provider entirely.

Also, since Emrah came across this bug when using expectMany incorrectly, it may be a good idea to do a more in-depth param sniff at the beginning of those functions, and throw an error if any are provided incorrectly.

When using dom.text('[test-id="pair-text"]') in a test it seemed that all text (from various parts of the ui) were printed out. However, dom.find('[test-id="pair-text"]').$el.text() gave me the text that I was actually interested in (the text from a single element).

dom.val('') does not change the element's value. This is because the check is for if (value), which bypasses the line that sets the value.

The last param DirectiveHelper.compileFn() is confusing and it's use is not obvious. Replace it with an options object literal that can alter the compile mechanism in predefined ways.