jeff-lewis / mobile-bookmark-bubble Goto Github PK

What steps will reproduce the problem?
1. Testing with JQuery Mobile jquery.mobile-1.0rc2.min.js
2. upon loading, page moves to left and an empty page is displayed with the 
bubble
3.

What is the expected output? What do you see instead?
bubble should be displayed on the homepage and not cause firstpage to move to 
left

What version of the product are you using? On what operating system?
Tested with all iphones and ipad versions

Please provide any additional information below.

What steps will reproduce the problem?
1. Use an apple-touch-icon larger then 57 x 57 pixels (e.g. 129px or 512px)
2. Launch mobile-bookmark-bubble enabled page.


What is the expected output? What do you see instead?
See only top-left corner of icon in bubble :-(


What version of the product are you using? On what operating system?
iPhone 3G (iOS 4.0)


Please provide any additional information below.

Pretty easy to fix. Add the following after line 525: -


  icon.style.WebkitBackgroundSize = '57px';


Sorted!

What steps will reproduce the problem?
1. Write a jQuery Mobile page
2. Use the mobile-bookmark-bubble script with the example ?bmb=1 hash param

What is the expected output? What do you see instead?

Ideally, it would not conflict.  Since jQuery Mobile uses hash params as a page 
addressing scheme, the usage of hash parameter here conflicts, and jquery 
mobile tries to load a page via xhr e.g. "HTTP GET /bmb=1".

What version of the product are you using? On what operating system?

Latest HG head.  iOS 4.x.

Please provide any additional information below.

I used a local variable instead, but am not completely familiar with the 
ramifications.  I'm not sure where/if this behavior should be changed or just 
documented.


$(document).ready(function() {
  setTimeout(function() {
    var bubble = new google.bookmarkbubble.Bubble();

    var varForHashParameter = false;

    bubble.hasHashParameter = function() {
      return varForHashParameter;
    };

    bubble.setHashParameter = function() {
      varForHashParameter = true;
    };

    bubble.showIfAllowed();

  }, 1000);
});

What steps will reproduce the problem?
1. Book mark add to the home screen and type the address then go to site.
2.
3.

What is the expected output? What do you see instead?
bubble should not show after it add to the home screen.

What version of the product are you using? On what operating system?
ipad 1 and iphone 4 on simulator 

Please provide any additional information below.
I add the following code to the template 

<script type="text/javascript">
              window.addEventListener(\'load\', function() {
                window.setTimeout(function() {
                var bubble = new google.bookmarkbubble.Bubble();
                var parameter = \'bmb=1\';
                bubble.hasHashParameter = function() {
                    return window.location.hash.indexOf(parameter) != -1;
                };
                bubble.setHashParameter = function() {
                    if (!this.hasHashParameter()) {
                        window.location.hash += parameter;
                    }
                };
                bubble.showIfAllowed();
                }, 1000);
            }, false);
            </script> 

What steps will reproduce the problem?
1. Load bookmarkbubble inside of a webpage/webapp running Beta 2 of jQuery 
Mobile
2. Wait for the bubble to appear, and try clicking on the [x] and it will not 
close

What is the expected output? What do you see instead?
The bubble should close on the tap event on the [x]


What version of the product are you using? On what operating system?
iOS simulator 4.3.2, iOS 4.1.2 (iPhone 4 hardware)


Please provide any additional information below.

What steps will reproduce the problem?
1. Load the webapp within a web view inside some non-Safari app.
2. The bubble appears, pointing at a non-existent Bookmark button.

What is the expected output? What do you see instead?

The bubble should not appear if the user isn't viewing the web app with Mobile 
Safari. It does appear.


What version of the product are you using? On what operating system?

The version listed as revision b3d04bb1ed17 in the change log. Downloaded on 
July 25, 2011. Hosting on Mac OS X 10.6.7, and viewing on iOS 4.3.5. 


Please provide any additional information below.

The regex that tests for Safari actually only tests for a web view on an 
iPhone, iPod, or iPad. It should actually test for safari, since web views 
within non-Safari apps leave that out of the user agent (which is otherwise the 
same). 

SOLUTION: Change the regular expression for detecting Mobile Safari, 
MOBILE_SAFARI_USERAGENT_REGEX_, to the following:
/(iPhone|iPod|iPad).*Safari/

That works properly, at least when tested with a web app running within 
FileMaker Go versus the same web app running with Mobile Safari. Both return 
true when only testing for /iPhone|iPod|iPad/ 

Hi, I would like to know if it possible to work for this script also on Android 
devices.

What steps will reproduce the problem?
1. Open a site with the bubble on the iPad
2. Bubble positioned at the bottom of the screen pointing to nothing.

What is the expected output? What do you see instead?

Bubble should be positioned along the top and underneath the bookmark button

What version of the product are you using? On what operating system?

iPad 1st Gen (iOS 3.2)

Please provide any additional information below.

Diff with alternate positioning for iPad attached. Working example here: 
http://digitalize.ca/mobile-bookmark/example.html

fsdf

test

test

I am installing this on www.raucous.com.au/test/test/testbubble.html before 
adding to my site, however the bubble comes up REALLY small - not like the 
YouTube version.

How do I increase this size?

akane test

Hi, I would like to know if it possible to create shortcut on mobile when the 
bubble clicked?

akane test

What steps will reproduce the problem?
1. Go to http://www.gwpahs.org/m/index.html
2. mobile-bookmark-bubble does not appear
3. No error messages or anything.... Just doesn't appear

What is the expected output? What do you see instead?

I am using iphonenav.js for our mobile site and have changed the following to 
localStorage as described in the comments of example.js but no 
mobile-bookmark-bubble is displayed:

bubble.setHashParameter = function() {
      if (!this.hasHashParameter()) {
        window.localStorage += parameter;
      }
    };

What version of the product are you using? On what operating system?

iPhone 4 (4.2.1) + Xcode iOS SDK Emulator (iPad/iPhone etc) on OS X for some 
testing

Please provide any additional information below.

Links to significant files:

http://www.gwpahs.org/m/bookmark_bubble.js
http://www.gwpahs.org/m/example.js
http://www.gwpahs.org/m/iphonenav.js

As mentioned above, I have changed the following to localStorage as described 
in the comments of example.js but is still not working (am I missing something 
or is there more too it):

bubble.setHashParameter = function() {
      if (!this.hasHashParameter()) {
        window.localStorage += parameter;
      }
    };

Maybe I need to make more changes but Im not too sure where....?

The '+' button for creating a new bookmark has changed to a new symbol. See the 
screenshot here:
http://reviews.cnet.com/2300-6452_7-10005619-10.html

We should update the instructional text inside the bubble to say something like 
"tap the arrow" instead of "tap '+'" when we detect an iOS >= 4.2 User-Agent 
string.

What steps will reproduce the problem?
1. Bubble keeps appearing even after I have added web app.
2.
3.

What is the expected output? What do you see instead?

Hi,

I am setting up a small mobile website for a client of mine and have 
implemented the bookmark_bubble into it.

I have got the bubble popping up perfectly with the icon and I have also edited 
the text that shows. However, even if I place a web app link on my home screen, 
then refresh the site, the bubble will re-appear and still keep popping up and 
prompting to add the web app to my phone.

I thought it was supposed to acknowledge that the user has added the web app or 
not so it can determine whether to keep prompting them.

What version of the product are you using? On what operating system?

Not sure..?

Please provide any additional information below.

Someone please help; any information is greatly appreciated!

Links to the bubble_bookmark javascript files being used are below:

http://insiteeyewear.com.au/sdo/m/js/bookmark.js

http://insiteeyewear.com.au/sdo/m/js/bubble.js

This works great on iPhone and iPad as long as you are using Safari, however it 
does not work with Chrome Mobile. The bookmark bubble comes up in Chrome 
mobile, but it will not allow the user to bookmark. Does anyone know how to 
make this work for Chrome Mobile browser too?

It would be nice if this library would be compatible with google's own closure 
compiler.

When trying to use advanced compilation closure spits the following error:

JSC_TYPE_MISMATCH: assignment to property boundScrollHandler_ of 
google.bookmarkbubble.Bubble found : (Function|null) required: function (): ? 
at line 65 character 0
this.boundScrollHandler_ = google.bind(this.setPosition, this);
^
JSC_INEXISTENT_PROPERTY: Property standalone never defined on 
Window.prototype.navigator at line 369 character 9
return !!window.navigator.standalone;

More over, since the library doesn't declare anything as external by default, 
the whole code will be optimized away (assuming those warnings are removed).

What steps will reproduce the problem?
1.bug  jquery mobile combined with bookmark_bubble when add to homescreen and 
loaded the webapp


What is the expected output? What do you see instead?
i click on the icon on the springboard the page loaded and after ... there is 
just a blank page. 


What version of the product are you using? On what operating system?
i use jquery mobile 1.0.2 with the latest revision of bookmark_bubble and the 
problem is on a iPhone 4 4.2.1


Please provide any additional information below.
if i delete these two lines who call the bookmark_bubble script my web app runs:
    <script type="text/javascript" src="js/bookmark_bubble.js"></script>
    <script type="text/javascript" src="js/example.js"></script>

and here is my code between <head> </head>
<head>
    <meta charset="utf-8" />
    <meta content="yes" name="apple-mobile-web-app-capable" />
    <link href="pics/logo.png" rel="apple-touch-icon" />
    <link href="pics/startup.png" rel="apple-touch-startup-image" />
    <link rel="apple-touch-icon-precomposed" href="IMG/icon_calendar.png" />
    <title></title>
    <link rel="stylesheet"  href="themes/default" />
    <link rel="stylesheet" href="docs/_assets/css/jqm-docs.css" />
    <link rel="stylesheet" href="themes/default/accueil.css" />
    <script src="js/"></script>
</head> 

What steps will reproduce the problem?
1. you are loading the site on a iPad(iOS 6.1)
2. the arrow to the bookmark icon in the safari browser will not displayed
3. after a slide down or up of 1 or 2 px the arrow will be shown

What is the expected output? What do you see instead?
The arrow should be shown.

What version of the product are you using? On what operating system?
I use a xCode simulator for IPhone and IPad with iOS 6.1 (up to date) on MAC OS 
X vs. 10.8.4

Please provide any additional information below.
When you scroll down or up in all modes(landscape and portrait) on the IPad the 
arrow of the bubble will be displayed. When you don't do that the arrow will 
not shown.. 

See attached. Have tweaked Bookmark Bubble for Android devices

In previous versions of iOS there was a "+" to add a page to the homescreen, 
but however in iOS 4.2 there´s another icon. 

So "...tap + and then.." isn´t right any more.

It would be great to insert this new icon to the project!

Thanks, Johannes

What steps will reproduce the problem?
1. Hold iPad 2 in portrait position
2. Open Safari
3. Open website (publizar.com)

What is the expected output? What do you see instead?
Bubble should be placed underneath the bookmark icon in Safari. It is currently 
more to the left.

What version of the product are you using? On what operating system?
An iPad 2 with latest OS version

Please provide any additional information below.

K

What steps will reproduce the problem?
1.Trying to change the style of the bubble.
2.I try to find the images and I found it in base 64.
3.I want to use my own images, so I change it.

What is the expected output? What do you see instead?
I expect to see a bubble with my local images. Insted, I see the normal bubble 
without the new images.


What version of the product are you using? On what operating system?
iPhone 3G with iOS 4.1.


Please provide any additional information below.

I don't know how to change the urls of the images. It's not more easy if you 
can add you own? I think it's a great idea. And don't need to depend for 2nd 
servers is good too. Nobody knows when these can be deleted or moved.

Thanks!

What steps will reproduce the problem?
1. visit http://m.mysamplepossystem.com/test-bookmark.php
2. no bookmark popup shows

No version number is included in the JS file, but I am using the latest version 
downloaded just a few days ago (around Sept 1, 2011).

The sample page above has been stripped of all extraneous stuff that could have 
been conflicting.  Still unable to get the popup to appear when testing.

My test user-agent string is:
Mozilla/5.0 (iPhone; U; CPU iPhone OS 4_1 like Mac OS X; en-us) 
AppleWebKit/532.9 (KHTML, like Gecko) Version/4.0.5 Mobile/8B117 
Safari/6531.22.7

What steps will reproduce the problem?
1.Insert the bubble script in a jQuery Mobile web app.
2.Acces to the homepage

What is the expected output? What do you see instead?
The expected is see the bubble like in the example, but when you add this to a 
jQuery Mobile web app, the page shows a loading box included in the framework. 
If you let the time pass, the bubble hides correctly, but if you press the 
close button, 2 another loading boxes comes up, the first with the loading and 
the second with the message "Error loading page".

It is functional, but I want to avoid the loading boxes because it's not clean.


What version of the product are you using? On what operating system?
iPhone 3G with iOS 4.1.

Please provide any additional information below.

I think the framework loads the content via AJAX and produces a little conflict 
showing the box. Any idea how to obviate this?

What steps will reproduce the problem?
1. Open on a iPhone where the language is Spanish
2.
3.

What is the expected output? What do you see instead?
Since only English, French and Japanese translations are defined, I expect it 
to default to English. It defaults to Japanese.

What version of the product are you using? On what operating system?
Latest version, iPhone 5S running current iOS7.

Please provide any additional information below.

What steps will reproduce the problem?
1.the bookmark GUI is not IOS 7 compatible 
2.
3.

What is the expected output? What do you see instead?
new UI and support the new safari.

What version of the product are you using? On what operating system?
IOS 7

Please provide any additional information below.

What steps will reproduce the problem?
Use the library and open the website for the first time clearing all the caches.

What is the expected output? What do you see instead?
The bubble should show be animated smoothly. But the bubble animates, suddenly 
disappears and comes back again

What version of the product are you using? On what operating system?
Source code revision c6dfec3762. On ipod touch 3 and 4.

Please provide any additional information below.

The bubble refers to a feature ("Add to Homescreen"), but that does not exist 
on iPhone 4.3. iPhone 4.2 was the last to support it.

Is that true?
Does you know another way to do that with >= iOS4.3

Under the download section there are no files. Where have they gone? or does 
anyone have any alternative places to get this script? Thanks.