jeidnx / untismerger Goto Github PK

As seen, when loading a new week from the untis server, the color values are wrong and then when loading from cache everything is back to normal.

Enable the QR Code login for mobiles.

This functionality could be introduced as Express middleware for easier readability and easier maintenance.

In the front end, add a proper display for the 502 return incase the server is unavailable

Wirtschaft im Untis enthält unzutreffende Kurse.
Es wurden im Wirtschaftsplan scheinbar irgendwelche Sport bzw Relikurse.
Muss irgendwie gefiltert werden.

It would be cool to get a scope of the project. How many registered users do we have? How many request are made etc..
Maybe something for you @Tallerik ?

On the setup page, when using the JWT Key option, pressing enter won't work. When manually pressing the submit button, it works as intended.

This dumb piece a shit works on the github.com page on the action workflows and makes 3001204010420124 commits!!!!

In Untis there is the ability to have multiple Lessons at the same time. Untismerger only shows one. This should be changed because when a Lesson is replaced with another it shows in untis that the normal Lesson is canceled but also shows the new Lesson. In this case Untismerger only shows the canceled lesson which implements that there is no Lesson.

Rewrite the codebase to send request to the Untis api from the client instead of trough the server

On the current devel version the server sometimes returns an Error: Cannot read properties of null (reading 'sessionId'). This error is thrown server side and is probably an issue with webuntis. Because this issue does not exist on the current main branch, misbehavior of the untis api can most likely be ruled out.

Additionally, if the client encounters this error before the first week is loaded, it crashes (if the error is encountered after the first week is loaded, the error gets caught fine). I couldn't yet figure out more details on this client side issue, because i only encountered it in the production build, which makes errors unreadable.

For example when pressing multiple times the key D the timetables both show up and not just the last one.
Like this:

Probably you need to cancel the first request when doing the next one. Else all requests will appear after they loaded.

Currently notifications don't really work for a variety of reasons that need to be taken care of:

1. The notification handler doesn't know for which lessons notifications have been sent. The current Redis implementation is just broken
2. There is no periodic checking for cancelled lessons. Lessons just get checked for cancellation if a users requests data for the day that said lesson is on
3. Currently only the Discord notification provider works

Following issues are known on Webkit browsers (Safari):

• Pull to refresh doesn't work
• Broadcast API (I think?) does not work, resulting in not seeing the current Service Worker version
• the JWT Key is not displayed in the Settings

Religion (evangelisch,katholisch) doesn't have a background color in the timetable.
Suggesting to add these colors in the colorEnum constant in timetable.js.

Add push notifications if a class is canceled

For the "Elektrotechnik" course the Untis API doesn't return a subject name.
How it should look:

How it looks:

• Add client side caching for stale assets to Service Worker
• Add support for Web Push notifications

If a lesson is canceled but doesn't have a name, it crashes here:

The frontend npm project has a broken dependency resolution due to the react-charts package. This means that the project dependencies have to be installed with the --force option. I am considering the following options:

• Find an alternative for react-charts (preferred)
• Remove the statistics page entirely (very easy)
• Just accept the broken dependency resolution and hope they fix it some day
• Create a fork of react-charts that doesn't have this Issue

JSON Response for relevant date:

[
    {
        "startZeit": 800,
        "fach": "Deutsch",
        "lehrer": "-",
        "raum": "-",
        "code": "irregular"
    },
    {
        "startZeit": 800,
        "fach": "Physik",
        "lehrer": "-",
        "raum": "-",
        "code": "cancelled"
    },
    {
        "startZeit": 845,
        "fach": "Deutsch",
        "lehrer": "-",
        "raum": "-",
        "code": "irregular"
    },
    {
        "startZeit": 845,
        "fach": "Physik",
        "lehrer": "-",
        "raum": "-",
        "code": "cancelled"
    },
    {
        "startZeit": 945,
        "fach": "Deutsch",
        "lehrer": "-",
        "raum": "-",
        "code": "regular"
    },
    {
        "startZeit": 1030,
        "fach": "Deutsch",
        "lehrer": "-",
        "raum": "-",
        "code": "regular"
    },
    {
        "startZeit": 1130,
        "fach": "Evangelisch Religion",
        "lehrer": "-",
        "raum": "-",
        "code": "regular"
    },
    {
        "startZeit": 1215,
        "fach": "Evangelisch Religion",
        "lehrer": "-",
        "raum": "-",
        "code": "regular"
    },
    {
        "startZeit": 1330,
        "fach": "Sport",
        "lehrer": "-",
        "raum": "-",
        "code": "regular"
    },
    {
        "startZeit": 1415,
        "fach": "Sport",
        "lehrer": "-",
        "raum": "-",
        "code": "regular"
    }
]

Shown timetable:

Expected behavior:

After scrolling forwards you can't scroll backwards anymore.

a switch to turn off notifications ?

We should add legal documents like an imprint aswell as an FAQ on the setup page. Do we need a cookie disclaimer? Also a form for users to submit issues.

The Settings page is missing any sort of Styling.

For example:
Englisch Nachhilfe

There is no issue with navigation through the weeks, but when you want back to the current week, nothing happens and this error apear:

Reproduce:

1. Go on https://untismerger.tk [Assuming logged in]
2. Navigate with [D] through multiple weeks
3. Use [A] to go back. It will work, but the last page (current work) wont be accessible again.

Workaround:
F5